mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace useless lcl_throwIllegalArgumentException function

Browse Source 
Change-Id: I0ee09c6882ea36a62a837fc3938f33e4c43f28d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157589
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Julien Nabet
2023-10-05 13:01:33 +02:00
parent b20d44d301
commit 7b0e834f33
1 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
fpicker/source/office/OfficeControlAccess.cxx
View File

@@ -150,13 +150,6 @@ namespace svt
return m_sLookup.equalsAscii(rProp.pPropertyName); return m_sLookup.equalsAscii(rProp.pPropertyName);
} }
}; };
void lcl_throwIllegalArgumentException( )
{
throw IllegalArgumentException();
// TODO: error message in the exception
}
} }
OControlAccess::OControlAccess(IFilePickerController* pController, SvtFileView* pFileView) OControlAccess::OControlAccess(IFilePickerController* pController, SvtFileView* pFileView)
@@ -221,11 +214,11 @@ namespace svt
ControlPropertyIterator aPropDesc = ::std::find_if( s_pProperties, s_pPropertiesEnd, ControlPropertyLookup( rControlProperty ) ); ControlPropertyIterator aPropDesc = ::std::find_if( s_pProperties, s_pPropertiesEnd, ControlPropertyLookup( rControlProperty ) );
if ( aPropDesc == s_pPropertiesEnd ) if ( aPropDesc == s_pPropertiesEnd )
// it's a completely unknown property // it's a completely unknown property
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
if ( !( nPropertyMask & aPropDesc->nPropertyId ) ) if ( !( nPropertyMask & aPropDesc->nPropertyId ) )
// it's a property which is known, but not allowed for this control // it's a property which is known, but not allowed for this control
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
return implGetControlProperty( pControl, aPropDesc->nPropertyId ); return implGetControlProperty( pControl, aPropDesc->nPropertyId );
} }
@@ -247,7 +240,7 @@ namespace svt
// if not found 'til here, the name is invalid, or we do not have the control in the current mode // if not found 'til here, the name is invalid, or we do not have the control in the current mode
if ( !pControl ) if ( !pControl )
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
// out parameters and outta here // out parameters and outta here
if ( _pId ) if ( _pId )
@@ -268,7 +261,7 @@ namespace svt
// look up the property // look up the property
ControlPropertyIterator aPropDesc = ::std::find_if( s_pProperties, s_pPropertiesEnd, ControlPropertyLookup( rControlProperty ) ); ControlPropertyIterator aPropDesc = ::std::find_if( s_pProperties, s_pPropertiesEnd, ControlPropertyLookup( rControlProperty ) );
if ( aPropDesc == s_pPropertiesEnd ) if ( aPropDesc == s_pPropertiesEnd )
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
// set the property // set the property
implSetControlProperty( nControlId, pControl, aPropDesc->nPropertyId, rValue, false ); implSetControlProperty( nControlId, pControl, aPropDesc->nPropertyId, rValue, false );
@@ -554,7 +547,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -568,7 +561,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -582,7 +575,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -596,7 +589,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -621,7 +614,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -638,7 +631,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -655,7 +648,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;
@@ -672,7 +665,7 @@ namespace svt
} }
else if ( !_bIgnoreIllegalArgument ) else if ( !_bIgnoreIllegalArgument )
{ {
lcl_throwIllegalArgumentException(); throw IllegalArgumentException();
} }
} }
break; break;