mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer switch-case to cascaded ifs

Browse Source 
Change-Id: Ic3fdf87c3028ae6367447f168a04cdc6fd2b0559
This commit is contained in:
Matteo Casalin
2015-12-15 21:34:20 +01:00
parent 6b9fdc5860
commit 7cd9eba81d
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
sw/source/uibase/docvw/srcedtw.cxx
View File

@@ -744,26 +744,28 @@ void SwSrcEditWindow::ImpDoHighlight( const OUString& rSource, sal_uInt16 nLineO
void SwSrcEditWindow::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint ) void SwSrcEditWindow::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
{ {
if ( dynamic_cast<const TextHint*>(&rHint) ) if ( !dynamic_cast<const TextHint*>(&rHint) )
return;
const TextHint& rTextHint = static_cast<const TextHint&>(rHint);
switch (rTextHint.GetId())
{ {
const TextHint& rTextHint = static_cast<const TextHint&>(rHint); case TEXT_HINT_VIEWSCROLLED:
if( rTextHint.GetId() == TEXT_HINT_VIEWSCROLLED )
{
pHScrollbar->SetThumbPos( pTextView->GetStartDocPos().X() ); pHScrollbar->SetThumbPos( pTextView->GetStartDocPos().X() );
pVScrollbar->SetThumbPos( pTextView->GetStartDocPos().Y() ); pVScrollbar->SetThumbPos( pTextView->GetStartDocPos().Y() );
} break;
else if( rTextHint.GetId() == TEXT_HINT_TEXTHEIGHTCHANGED )
{ case TEXT_HINT_TEXTHEIGHTCHANGED:
if ( pTextEngine->GetTextHeight() < pOutWin->GetOutputSizePixel().Height() ) if ( pTextEngine->GetTextHeight() < pOutWin->GetOutputSizePixel().Height() )
pTextView->Scroll( 0, pTextView->GetStartDocPos().Y() ); pTextView->Scroll( 0, pTextView->GetStartDocPos().Y() );
pVScrollbar->SetThumbPos( pTextView->GetStartDocPos().Y() ); pVScrollbar->SetThumbPos( pTextView->GetStartDocPos().Y() );
SetScrollBarRanges(); SetScrollBarRanges();
} break;
else if( ( rTextHint.GetId() == TEXT_HINT_PARAINSERTED ) ||
( rTextHint.GetId() == TEXT_HINT_PARACONTENTCHANGED ) ) case TEXT_HINT_PARAINSERTED:
{ case TEXT_HINT_PARACONTENTCHANGED:
DoDelayedSyntaxHighlight( (sal_uInt16)rTextHint.GetValue() ); DoDelayedSyntaxHighlight( (sal_uInt16)rTextHint.GetValue() );
} break;
} }
} }