mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fdo#69873 FixedText (label) is implemented as no value

Browse Source 
And the actual label is put as *body* of the cell.
I'd prefer that the value be put as string-value attribute of the cell,
but since in the report definition the label is as body
(as opposed to as an attribute), it is easier that way.

We could move (actually *copy* for backwards compatibility reasons)
the label to an attribute of the rpt:fixed-content element
(similar to the rpt:formula attribute of rpt:formatted-text)
but it is not obvious this is completely desirable:
Indeed it would keep us from putting anything more complex than a string there
(which we don't do anyway now, but thinking of future extensibility here);
I'll leave the exploration of that idea to the indefinite future.

Change-Id: Ia0f7460718ee35a971117e2f79c0997e17e1095e
This commit is contained in:
Lionel Elie Mamane 2014-02-05 07:39:31 +01:00
parent bd9db38e45
commit 7ce47d69b3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/TableCellLayoutController.java
View File

@ -74,11 +74,12 @@ public class TableCellLayoutController extends SectionLayoutController
FormatValueUtility.applyValueForCell(value.getValue(), attributeMap, valueType);
}
// #i114108#: except on form elements, the only value-type that can
// occur without an accompanying value attribute is "string"
// occur without an accompanying value attribute is "string";
// the content is then in the body.
else if (!"string".equals(valueType))
{
attributeMap.setAttribute(OfficeNamespaces.OFFICE_NS,
FormatValueUtility.VALUE_TYPE, "void");
FormatValueUtility.VALUE_TYPE, "string");
}
}
catch (Exception e)