mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extend loplugin:redundantinline to catch inline functions w/o external linkage

Browse Source 
...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense.  (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)

All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.

Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2018-10-09 10:28:48 +02:00
parent 664db0d945
commit 7ceee0f1ec
316 changed files with 823 additions and 771 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cppu/source/uno/lbmap.cxx
View File

@@ -268,7 +268,7 @@ uno_Mediate_Mapping::uno_Mediate_Mapping(
}
static inline OUString getMappingName(
static OUString getMappingName(
const Environment & rFrom, const Environment & rTo, const OUString & rAddPurpose )
{
OUStringBuffer aKey( 64 );
@@ -285,7 +285,7 @@ static inline OUString getMappingName(
return aKey.makeStringAndClear();
}
static inline OUString getBridgeName(
static OUString getBridgeName(
const Environment & rFrom, const Environment & rTo, const OUString & rAddPurpose )
{
OUStringBuffer aBridgeName( 16 );
@@ -302,7 +302,7 @@ static inline OUString getBridgeName(
#ifndef DISABLE_DYNLOADING
static inline void setNegativeBridge( const OUString & rBridgeName )
static void setNegativeBridge( const OUString & rBridgeName )
{
MappingsData & rData = getMappingsData();
MutexGuard aGuard( rData.aNegativeLibsMutex );
@@ -337,7 +337,7 @@ static uno_ext_getMappingFunc selectMapFunc( const OUString & rBridgeName )
#else
static inline bool loadModule(osl::Module & rModule, const OUString & rBridgeName)
static bool loadModule(osl::Module & rModule, const OUString & rBridgeName)
{
bool bNeg;
{
@@ -472,7 +472,7 @@ static Mapping getDirectMapping(
}
static inline Mapping createMediateMapping(
static Mapping createMediateMapping(
const Environment & rFrom, const Environment & rTo,
const Mapping & rFrom2Uno, const Mapping & rUno2To,
const OUString & rAddPurpose )