From 7fbfefaedec93d7b49d1f53e23aed3cbbb55b315 Mon Sep 17 00:00:00 2001
From: Seth Chaiklin <sdc.blanco@youmail.dk>
Date: Fri, 15 Apr 2022 03:11:45 +0100
Subject: [PATCH] tdf#126658 UI improvements to Arrow Styles tab in Line dialog
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

     * label "Organize Arrow Styles -> "Manage Arrow Styles"
     * label "Title" -> "Style _name"
     * button label "_Modify" -> "_Rename"
     + Add a tooltip for "Rename"
     - Remove label "Add..." (which was inadequate)
     + Add tooltip and extended tooltip for "Add" button

Change-Id: I0226b32158c3bb9ae2600f8bfce3739f2ddbe5c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
---
 cui/uiconfig/ui/lineendstabpage.ui | 28 ++++++++++------------------
 solenv/sanitizers/ui/cui.suppr     |  1 -
 2 files changed, 10 insertions(+), 19 deletions(-)

diff --git a/cui/uiconfig/ui/lineendstabpage.ui b/cui/uiconfig/ui/lineendstabpage.ui
index 2f63fcc1bec6..292159657ac0 100644
--- a/cui/uiconfig/ui/lineendstabpage.ui
+++ b/cui/uiconfig/ui/lineendstabpage.ui
@@ -63,7 +63,7 @@
                   <object class="GtkLabel" id="FT_TITLE">
                     <property name="visible">True</property>
                     <property name="can-focus">False</property>
-                    <property name="label" translatable="yes" context="lineendstabpage|FT_TITLE">_Title:</property>
+                    <property name="label" translatable="yes" context="lineendstabpage|FT_TITLE">Style _name:</property>
                     <property name="use-underline">True</property>
                     <property name="mnemonic-widget">EDT_NAME</property>
                     <property name="xalign">0</property>
@@ -124,21 +124,6 @@
                     <property name="top-attach">1</property>
                   </packing>
                 </child>
-                <child>
-                  <object class="GtkLabel" id="FI_TIP">
-                    <property name="visible">True</property>
-                    <property name="can-focus">False</property>
-                    <property name="valign">end</property>
-                    <property name="vexpand">True</property>
-                    <property name="label" translatable="yes" context="lineendstabpage|FI_TIP">Add a selected object to create new arrow styles.</property>
-                    <property name="xalign">0</property>
-                  </object>
-                  <packing>
-                    <property name="left-attach">0</property>
-                    <property name="top-attach">2</property>
-                    <property name="width">2</property>
-                  </packing>
-                </child>
               </object>
               <packing>
                 <property name="expand">False</property>
@@ -160,7 +145,13 @@
                     <property name="visible">True</property>
                     <property name="can-focus">True</property>
                     <property name="receives-default">True</property>
+                    <property name="tooltip-text" translatable="yes" context="lineendstabpage|BTN_ADD|tooltip_text">Adds selected shape as Arrow Style.</property>
                     <property name="use-underline">True</property>
+                    <child internal-child="accessible">
+                      <object class="AtkObject" id="BTN_ADD-atkobject">
+                        <property name="AtkObject::accessible-description" translatable="yes" context="lineendstabpage|extended_tip|BTN_ADD">To add a new Arrow Style, first select the shape in the document to be added, then open this dialog and press Add. If the selected shape is not permitted as an Arrow Style, then the Add button is not active.</property>
+                      </object>
+                    </child>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -170,10 +161,11 @@
                 </child>
                 <child>
                   <object class="GtkButton" id="BTN_MODIFY">
-                    <property name="label" translatable="yes" context="lineendstabpage|BTN_MODIFY">_Modify</property>
+                    <property name="label" translatable="yes" context="lineendstabpage|BTN_MODIFY">_Rename</property>
                     <property name="visible">True</property>
                     <property name="can-focus">True</property>
                     <property name="receives-default">True</property>
+                    <property name="tooltip-text" translatable="yes" context="lineendstabpage|BTN_MODIFY|tooltip_text">Applies changes to the Style name.</property>
                     <property name="use-underline">True</property>
                   </object>
                   <packing>
@@ -307,7 +299,7 @@
       <object class="GtkLabel" id="label1">
         <property name="visible">True</property>
         <property name="can-focus">False</property>
-        <property name="label" translatable="yes" context="lineendstabpage|label1">Organize Arrow Styles</property>
+        <property name="label" translatable="yes" context="lineendstabpage|label1">Manage Arrow Styles</property>
         <property name="xalign">0</property>
         <attributes>
           <attribute name="weight" value="bold"/>
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 7086f62b9ab5..b7e0c00c469d 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -80,7 +80,6 @@ cui/uiconfig/ui/insertoleobject.ui://GtkEntry[@id='urled'] no-labelled-by
 cui/uiconfig/ui/javastartparametersdialog.ui://GtkLabel[@id='label6'] orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkLabel[@id='FT_LINE_END_STYLE'] orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkComboBox[@id='LB_LINEENDS'] no-labelled-by
-cui/uiconfig/ui/lineendstabpage.ui://GtkLabel[@id='FI_TIP'] orphan-label
 cui/uiconfig/ui/linestyletabpage.ui://GtkSpinButton[@id='NUM_FLD_2'] no-labelled-by
 cui/uiconfig/ui/linestyletabpage.ui://GtkSpinButton[@id='MTR_FLD_LENGTH_2'] no-labelled-by
 cui/uiconfig/ui/macroselectordialog.ui://GtkLabel[@id='helpmacro'] orphan-label