mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Related: tdf#155266 Eliminate delayed scrollbar redrawing when swiping

Browse Source 
By default, the layout idle timer in the InterimWindowItem
class is set to TaskPriority::RESIZE. That is too high of
a priority as it appears that other timers are drawing
after the scrollbar has been redrawn.

As a result, when swiping, the content moves fluidly but
the scrollbar thumb does not move until after swiping
stops or pauses. Then, after a short lag, the scrollbar
thumb finally "jumps" to the expected position.

So, to fix this scrollbar "stickiness" when swiping,
setting the priority to TaskPriority::POST_PAINT causes
the scrollbar to be redrawn after any competing timers.

Change-Id: I8c0772fc40ddc690ee59c6267c1c50971f4ff238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161184
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
This commit is contained in:
Patrick Luby
2023-12-22 09:34:24 -05:00
parent c5cc7af60d
commit 8339bb40b2
3 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/vcl/InterimItemWindow.hxx
View File

@@ -34,6 +34,8 @@ public:
virtual void Draw(OutputDevice* pDevice, const Point& rPos, virtual void Draw(OutputDevice* pDevice, const Point& rPos,
SystemTextColorFlags nFlags) override; SystemTextColorFlags nFlags) override;
void SetPriority(TaskPriority nPriority);
protected: protected:
// bAllowCycleFocusOut of true allows focus to be moved out of the Control // bAllowCycleFocusOut of true allows focus to be moved out of the Control
// via tab key into a parent window or sibling window, false means focus // via tab key into a parent window or sibling window, false means focus

14
sc/source/ui/view/tabview.cxx
View File

@@ -232,6 +232,20 @@ void ScTabView::InitScrollBar(ScrollAdaptor& rScrollBar, tools::Long nMaxVal, co
rScrollBar.SetMouseReleaseHdl(LINK(this, ScTabView, EndScrollHdl)); rScrollBar.SetMouseReleaseHdl(LINK(this, ScTabView, EndScrollHdl));
rScrollBar.EnableRTL( aViewData.GetDocument().IsLayoutRTL( aViewData.GetTabNo() ) ); rScrollBar.EnableRTL( aViewData.GetDocument().IsLayoutRTL( aViewData.GetTabNo() ) );
// Related: tdf#155266 Eliminate delayed scrollbar redrawing when swiping
// By default, the layout idle timer in the InterimWindowItem class
// is set to TaskPriority::RESIZE. That is too high of a priority as
// it appears that other timers are drawing after the scrollbar has been
// redrawn.
// As a result, when swiping, the content moves fluidly but the scrollbar
// thumb does not move until after swiping stops or pauses. Then, after a
// short lag, the scrollbar thumb finally "jumps" to the expected
// position.
// So, to fix this scrollbar "stickiness" when swiping, setting the
// priority to TaskPriority::POST_PAINT causes the scrollbar to be
// redrawn after any competing timers.
rScrollBar.SetPriority(TaskPriority::POST_PAINT);
} }
// Scroll-Timer // Scroll-Timer

5
vcl/source/control/InterimItemWindow.cxx
View File

@@ -187,6 +187,11 @@ void InterimItemWindow::Draw(OutputDevice* pDevice, const Point& rPos,
m_xContainer->draw(*pDevice, rPos, GetSizePixel()); m_xContainer->draw(*pDevice, rPos, GetSizePixel());
} }
void InterimItemWindow::SetPriority(TaskPriority nPriority)
{
m_aLayoutIdle.SetPriority(nPriority);
}
void InterimItemWindow::ImplPaintToDevice(::OutputDevice* pTargetOutDev, const Point& rPos) void InterimItemWindow::ImplPaintToDevice(::OutputDevice* pTargetOutDev, const Point& rPos)
{ {
Draw(pTargetOutDev, rPos, SystemTextColorFlags::NONE); Draw(pTargetOutDev, rPos, SystemTextColorFlags::NONE);