mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SAL_INFO when vnd.sun.star.expand is considered exotic

Browse Source 
As discussed in the appertaining comments at
<https://gerrit.libreoffice.org/c/core/+/176645/3#message-1209b271ac4a330311eb90b2d6c16bbff57842ef>,
836d73a65180d89a077e36457f1f3aa1698c2058 "consider VndSunStarExpand an exotic
protocol" may have been a bit brittle:  "[vnd.sun.star.expand] originated from
the UNO configuration infrastructure, but indeed hard to tell if it then found
reasonable uses outside that area.  I guess the best we can do is get it in,
maybe mention it in the release notes, and see."  Turns out it is used at least
to handle %origin% in extensions, where that change caused
<https://bugs.documentfoundation.org/show_bug.cgi?id=165851> "Installing custom
default template via extension stopped working".

So to be better prepared to track down potential further breakage caused by that
change, note cases where it (legitimately or problematically) hits with a
SAL_INFO.

Change-Id: If742f4f0b0f223e5acf346d294567ccc09eaf49b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183659
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This commit is contained in:
Stephan Bergmann 2025-04-03 10:25:15 +02:00
parent 1aac139d50
commit 8b263f3a0b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/source/fsys/urlobj.cxx
View File

@ -4896,6 +4896,9 @@ bool INetURLObject::IsExoticProtocol() const
isSchemeEqualTo(u"vnd.sun.star.script") || isSchemeEqualTo(u"vnd.sun.star.script") ||
isSchemeEqualTo(u"service")) isSchemeEqualTo(u"service"))
{ {
SAL_INFO_IF(
m_eScheme == INetProtocol::VndSunStarExpand, "tools.urlobj",
"<" << m_aAbsURIRef.toString() << "> considered exotic");
return true; return true;
} }
if (m_eScheme == INetProtocol::VndSunStarPkg) { if (m_eScheme == INetProtocol::VndSunStarPkg) {