mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unnnecessaryvirtual

Browse Source 
Change-Id: I2aa9a8f14b6db2098931a14c6eed522a9d2653ed
Reviewed-on: https://gerrit.libreoffice.org/69682
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-03-25 14:59:02 +02:00
parent 99df964c96
commit 8bb04558b9
6 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compilerplugins/clang/unnecessaryvirtual-dead.results
View File

@@ -12,7 +12,7 @@ sc/source/core/opencl/formulagroupcl.cxx:1061
void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
slideshow/source/engine/animationfactory.cxx:443 slideshow/source/engine/animationfactory.cxx:443
void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,) void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
vcl/inc/salframe.hxx:135 vcl/inc/salframe.hxx:144
void SalFrame::SetRepresentedURL(const class rtl::OUString &,) void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salmenu.hxx:71 vcl/inc/salmenu.hxx:71
void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,) void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,)

22
compilerplugins/clang/unnecessaryvirtual.results
View File

@@ -72,6 +72,12 @@ include/comphelper/unique_disposing_ptr.hxx:169
void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,) void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,)
include/comphelper/weakeventlistener.hxx:120 include/comphelper/weakeventlistener.hxx:120
void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
include/oox/helper/graphichelper.hxx:77
int oox::GraphicHelper::getDefaultChartAreaLineStyle()const
include/oox/helper/graphichelper.hxx:80
short oox::GraphicHelper::getDefaultChartAreaLineWidth()const
include/sfx2/tabdlg.hxx:103
class SfxItemSet * SfxTabDialog::CreateInputItemSet(unsigned short,)
include/svl/svdde.hxx:237 include/svl/svdde.hxx:237
class DdeData * DdeTopic::Get(enum SotClipboardFormatId,) class DdeData * DdeTopic::Get(enum SotClipboardFormatId,)
include/svl/svdde.hxx:238 include/svl/svdde.hxx:238
@@ -108,10 +114,8 @@ include/vbahelper/vbareturntypes.hxx:40
void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,) void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,)
include/vbahelper/vbareturntypes.hxx:41 include/vbahelper/vbareturntypes.hxx:41
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
include/vcl/filter/PngImageReader.hxx:29 include/vcl/weld.hxx:95
void vcl::PngImageReader::~PngImageReader() void weld::Widget::set_visible(_Bool,)
include/xmloff/xmlstyle.hxx:217
unsigned short SvXMLStylesContext::GetFamily(const class rtl::OUString &,)const
sc/source/core/opencl/formulagroupcl.cxx:1053 sc/source/core/opencl/formulagroupcl.cxx:1053
_Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const
sc/source/core/opencl/formulagroupcl.cxx:1061 sc/source/core/opencl/formulagroupcl.cxx:1061
@@ -188,8 +192,8 @@ sc/source/ui/vba/vbapagebreak.hxx:48
void ScVbaPageBreak::Delete() void ScVbaPageBreak::Delete()
sc/source/ui/vba/vbapagebreak.hxx:49 sc/source/ui/vba/vbapagebreak.hxx:49
class com::sun::star::uno::Reference<class ooo::vba::excel::XRange> ScVbaPageBreak::Location() class com::sun::star::uno::Reference<class ooo::vba::excel::XRange> ScVbaPageBreak::Location()
sd/source/ui/inc/ViewClipboard.hxx:77 shell/inc/i_xml_parser_event_handler.hxx:41
unsigned short sd::ViewClipboard::InsertSlides(const class SdTransferable &,unsigned short,) void i_xml_parser_event_handler::~i_xml_parser_event_handler()
slideshow/source/engine/activities/activitiesfactory.cxx:173 slideshow/source/engine/activities/activitiesfactory.cxx:173
void slideshow::internal::(anonymous namespace)::FromToByActivity::startAnimation() void slideshow::internal::(anonymous namespace)::FromToByActivity::startAnimation()
slideshow/source/engine/activities/activitiesfactory.cxx:242 slideshow/source/engine/activities/activitiesfactory.cxx:242
@@ -210,11 +214,9 @@ slideshow/source/engine/animationfactory.cxx:447
void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,) void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
sw/inc/flypos.hxx:37 sw/inc/flypos.hxx:37
void SwPosFlyFrame::~SwPosFlyFrame() void SwPosFlyFrame::~SwPosFlyFrame()
sw/source/uibase/inc/drawbase.hxx:53 vcl/inc/salframe.hxx:144
_Bool SwDrawBase::MouseMove(const class MouseEvent &,)
vcl/inc/salframe.hxx:135
void SalFrame::SetRepresentedURL(const class rtl::OUString &,) void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salframe.hxx:180 vcl/inc/salframe.hxx:189
void SalFrame::Flush(const class tools::Rectangle &,) void SalFrame::Flush(const class tools::Rectangle &,)
vcl/inc/salinst.hxx:92 vcl/inc/salinst.hxx:92
_Bool SalInstance::SVMainHook(int *,) _Bool SalInstance::SVMainHook(int *,)

4
include/oox/helper/graphichelper.hxx
View File

@@ -74,10 +74,10 @@ public:
virtual sal_Int32 getDefaultChartAreaFillStyle() const; virtual sal_Int32 getDefaultChartAreaFillStyle() const;
/** Returns chartspace automatic default border style */ /** Returns chartspace automatic default border style */
virtual sal_Int32 getDefaultChartAreaLineStyle() const; static sal_Int32 getDefaultChartAreaLineStyle();
/** Returns chartspace automatic default border width in Emu */ /** Returns chartspace automatic default border width in Emu */
virtual sal_Int16 getDefaultChartAreaLineWidth() const; static sal_Int16 getDefaultChartAreaLineWidth();
// Device info and device dependent unit conversion ----------------------- // Device info and device dependent unit conversion -----------------------

2
include/sfx2/tabdlg.hxx
View File

@@ -100,7 +100,7 @@ friend class SfxTabDialogUIObject;
protected: protected:
virtual short Ok(); virtual short Ok();
// Is deleted in Sfx! // Is deleted in Sfx!
virtual SfxItemSet* CreateInputItemSet( sal_uInt16 nId ); static SfxItemSet* CreateInputItemSet( sal_uInt16 nId );
virtual void PageCreated( sal_uInt16 nId, SfxTabPage &rPage ); virtual void PageCreated( sal_uInt16 nId, SfxTabPage &rPage );
VclPtr<VclButtonBox> m_pActionArea; VclPtr<VclButtonBox> m_pActionArea;

4
oox/source/drawingml/chart/objectformatter.cxx
View File

@@ -823,8 +823,8 @@ LineFormatter::LineFormatter( ObjectFormatterData& rData, const AutoFormatEntry*
// set automatic border property for chartarea, because of tdf#81437 and tdf#82217 // set automatic border property for chartarea, because of tdf#81437 and tdf#82217
if ( eObjType == OBJECTTYPE_CHARTSPACE ) if ( eObjType == OBJECTTYPE_CHARTSPACE )
{ {
mxAutoLine->maLineFill.moFillType = rData.mrFilter.getGraphicHelper().getDefaultChartAreaLineStyle(); mxAutoLine->maLineFill.moFillType = oox::GraphicHelper::getDefaultChartAreaLineStyle();
mxAutoLine->moLineWidth = rData.mrFilter.getGraphicHelper().getDefaultChartAreaLineWidth(); mxAutoLine->moLineWidth = oox::GraphicHelper::getDefaultChartAreaLineWidth();
// this value is what MSO 2016 use as a default color for chartspace border // this value is what MSO 2016 use as a default color for chartspace border
mxAutoLine->maLineFill.maFillColor.setSrgbClr( 0xD9D9D9 ); mxAutoLine->maLineFill.maFillColor.setSrgbClr( 0xD9D9D9 );
} }

4
oox/source/helper/graphichelper.cxx
View File

@@ -165,12 +165,12 @@ sal_Int32 GraphicHelper::getDefaultChartAreaFillStyle() const
return XML_solidFill; return XML_solidFill;
} }
sal_Int32 GraphicHelper::getDefaultChartAreaLineStyle() const sal_Int32 GraphicHelper::getDefaultChartAreaLineStyle()
{ {
return XML_solidFill; return XML_solidFill;
} }
sal_Int16 GraphicHelper::getDefaultChartAreaLineWidth() const sal_Int16 GraphicHelper::getDefaultChartAreaLineWidth()
{ {
// this value is what MSO 2016 writes fixing incomplete MSO 2010 documents (0.75 pt in emu) // this value is what MSO 2016 writes fixing incomplete MSO 2010 documents (0.75 pt in emu)
return 9525; return 9525;