mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1371190 Missing move assignment operator

Browse Source 
Change-Id: I20991a31a82ff96292cdd1be4fd2c4779f9f5514
This commit is contained in:
Caolán McNamara 2016-09-11 21:01:42 +01:00
parent b9f5607ba8
commit 8bd5dd43a9
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/source/abpilot/datasourcehandling.cxx
View File

@ -328,7 +328,6 @@ namespace abp
*this = _rSource;
}
ODataSource& ODataSource::operator=( const ODataSource& _rSource )
{
if( this != &_rSource )
@ -338,13 +337,17 @@ namespace abp
return *this;
}
ODataSource& ODataSource::operator=( ODataSource&& _rSource )
{
m_pImpl = std::move(_rSource.m_pImpl);
return *this;
}
ODataSource::ODataSource( const Reference< XComponentContext >& _rxORB )
:m_pImpl(new ODataSourceImpl(_rxORB))
{
}
ODataSource::~ODataSource( )
{
}

4
extensions/source/abpilot/datasourcehandling.hxx
View File

@ -113,9 +113,11 @@ namespace abp
/// dtor
~ODataSource( );
/// assignment
/// copy assignment
ODataSource& operator=( const ODataSource& _rSource );
/// move assignment
ODataSource& operator=( ODataSource&& _rSource );
/// checks whether or not the object represents a valid data source
bool isValid() const;