mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields writerfilter,writerperfect

Browse Source 
Change-Id: I8863fcdb0751d2f1becea5b2487d4070e4fd4195
This commit is contained in:
Noel Grandin
2015-12-21 10:59:06 +02:00
parent 4c7ce41582
commit 8ee52d72f5
11 changed files with 15 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
writerfilter/source/dmapper/DomainMapper_Impl.hxx
View File

@@ -593,7 +593,7 @@ public:
SettingsTablePtr GetSettingsTable()
{
if( !m_pSettingsTable )
m_pSettingsTable.reset( new SettingsTable( m_xTextFactory ) );
m_pSettingsTable.reset( new SettingsTable );
return m_pSettingsTable;
}

11
writerfilter/source/dmapper/SettingsTable.cxx
View File

@@ -41,8 +41,6 @@ namespace dmapper
struct SettingsTable_Impl
{
const uno::Reference< lang::XMultiServiceFactory > m_xTextFactory;
OUString m_sCharacterSpacing;
OUString m_sDecimalSymbol;
OUString m_sListSeparatorForFields; //2.15.1.56 listSeparator (List Separator for Field Code Evaluation)
@@ -71,9 +69,8 @@ struct SettingsTable_Impl
std::vector<beans::PropertyValue> m_aCompatSettings;
uno::Sequence<beans::PropertyValue> m_pCurrentCompatSetting;
SettingsTable_Impl( const uno::Reference< lang::XMultiServiceFactory > & xTextFactory ) :
m_xTextFactory( xTextFactory )
, m_nDefaultTabStop( 720 ) //default is 1/2 in
SettingsTable_Impl() :
m_nDefaultTabStop( 720 ) //default is 1/2 in
, m_nHyphenationZone(0)
, m_bNoPunctuationKerning(false)
, m_doNotIncludeSubdocsInStats(false)
@@ -97,10 +94,10 @@ struct SettingsTable_Impl
};
SettingsTable::SettingsTable(const uno::Reference< lang::XMultiServiceFactory > & xTextFactory)
SettingsTable::SettingsTable()
: LoggedProperties("SettingsTable")
, LoggedTable("SettingsTable")
, m_pImpl( new SettingsTable_Impl(xTextFactory) )
, m_pImpl( new SettingsTable_Impl )
{
}

2
writerfilter/source/dmapper/SettingsTable.hxx
View File

@@ -45,7 +45,7 @@ class SettingsTable : public LoggedProperties, public LoggedTable
std::unique_ptr<SettingsTable_Impl> m_pImpl;
public:
SettingsTable(const css::uno::Reference<css::lang::XMultiServiceFactory>& xTextFactory);
SettingsTable();
virtual ~SettingsTable();
//returns default TabStop in 1/100th mm

1
writerfilter/source/dmapper/StyleSheetTable.cxx
View File

@@ -285,7 +285,6 @@ struct StyleSheetTable_Impl
std::vector< StyleSheetEntryPtr > m_aStyleSheetEntries;
StyleSheetEntryPtr m_pCurrentEntry;
PropertyMapPtr m_pDefaultParaProps, m_pDefaultCharProps;
PropertyMapPtr m_pCurrentProps;
StringPairMap_t m_aStyleNameMap;
/// Style names which should not be used without a " (user)" suffix.
std::set<OUString> m_aReservedStyleNames;

5
writerfilter/source/dmapper/TableData.hxx
View File

@@ -244,11 +244,6 @@ class TableData
typedef RowData::Pointer_t RowPointer_t;
typedef ::std::vector<RowPointer_t> Rows;
/**
the table properties
*/
TablePropertyMapPtr mpTableProps;
/**
the data of the rows of the table
*/

5
writerfilter/source/dmapper/TableManager.hxx
View File

@@ -51,11 +51,6 @@ class TableManager
{
class TableManagerState
{
/**
properties at the current point in document
*/
TablePropertyMapPtr mpProps;
/**
properties of the current cell
*/

11
writerfilter/source/filter/WriterFilterDetection.cxx
View File

@@ -33,10 +33,8 @@ class WriterFilterDetection : public cppu::WeakImplHelper
lang::XServiceInfo
>
{
uno::Reference<uno::XComponentContext> m_xContext;
public:
explicit WriterFilterDetection(const uno::Reference<uno::XComponentContext>& rxContext);
explicit WriterFilterDetection();
virtual ~WriterFilterDetection();
//XExtendedFilterDetection
@@ -50,8 +48,7 @@ public:
uno::Sequence<OUString> SAL_CALL WriterFilterDetection_getSupportedServiceNames() throw (uno::RuntimeException);
WriterFilterDetection::WriterFilterDetection(const uno::Reference<uno::XComponentContext>& rxContext)
: m_xContext(rxContext)
WriterFilterDetection::WriterFilterDetection()
{
}
@@ -135,9 +132,9 @@ uno::Sequence<OUString> WriterFilterDetection::getSupportedServiceNames() throw
return WriterFilterDetection_getSupportedServiceNames();
}
extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface* SAL_CALL com_sun_star_comp_Writer_WriterFilterDetector_get_implementation(uno::XComponentContext* pComp, uno::Sequence<css::uno::Any> const&)
extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface* SAL_CALL com_sun_star_comp_Writer_WriterFilterDetector_get_implementation(uno::XComponentContext* /*pComp*/, uno::Sequence<css::uno::Any> const&)
{
return cppu::acquire(new WriterFilterDetection(pComp));
return cppu::acquire(new WriterFilterDetection);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

1
writerperfect/inc/ImportFilter.hxx
View File

@@ -180,7 +180,6 @@ private:
css::uno::Reference< css::uno::XComponentContext > mxContext;
css::uno::Reference< css::lang::XComponent > mxDoc;
OUString msFilterName;
css::uno::Reference< css::xml::sax::XDocumentHandler > mxHandler;
};
}

1
writerperfect/qa/unit/WpftImportTestBase.hxx
View File

@@ -101,7 +101,6 @@ private:
private:
const rtl::OUString m_aFactoryURL;
css::uno::Reference<css::frame::XDesktop2> m_xDesktop;
css::uno::Reference<css::ucb::XSimpleFileAccess> m_xFileAccess;
css::uno::Reference<css::document::XFilter> m_xFilter;
css::uno::Reference<css::container::XNameAccess> m_xTypeMap;
const WpftOptionalMap_t *m_pOptionalMap;

8
writerperfect/source/writer/WordPerfectImportFilter.cxx
View File

@@ -280,8 +280,8 @@ throw (RuntimeException, std::exception)
}
WordPerfectImportFilterDialog::WordPerfectImportFilterDialog(const Reference< XComponentContext > &rContext) :
mxContext(rContext) {}
WordPerfectImportFilterDialog::WordPerfectImportFilterDialog()
{}
WordPerfectImportFilterDialog::~WordPerfectImportFilterDialog()
{
@@ -385,10 +385,10 @@ throw (RuntimeException)
return aRet;
}
Reference< XInterface > SAL_CALL WordPerfectImportFilterDialog_createInstance(const Reference< XComponentContext > &rContext)
Reference< XInterface > SAL_CALL WordPerfectImportFilterDialog_createInstance(const Reference< XComponentContext > &)
throw(Exception)
{
return static_cast<cppu::OWeakObject *>(new WordPerfectImportFilterDialog(rContext));
return static_cast<cppu::OWeakObject *>(new WordPerfectImportFilterDialog);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

4
writerperfect/source/writer/WordPerfectImportFilter.hxx
View File

@@ -38,7 +38,6 @@ protected:
css::uno::Reference< css::uno::XComponentContext > mxContext;
css::uno::Reference< css::lang::XComponent > mxDoc;
OUString msFilterName;
css::uno::Reference< css::xml::sax::XDocumentHandler > mxHandler;
bool SAL_CALL importImpl(const css::uno::Sequence< css::beans::PropertyValue > &aDescriptor)
throw (css::uno::RuntimeException, std::exception);
@@ -96,7 +95,6 @@ class WordPerfectImportFilterDialog : public cppu::WeakImplHelper <
css::beans::XPropertyAccess
>
{
css::uno::Reference< css::uno::XComponentContext > mxContext;
OUString msPassword;
css::uno::Reference< css::io::XInputStream > mxInputStream;
@@ -128,7 +126,7 @@ class WordPerfectImportFilterDialog : public cppu::WeakImplHelper <
css::uno::RuntimeException, std::exception) override;
public:
explicit WordPerfectImportFilterDialog(const css::uno::Reference< css::uno::XComponentContext > &rContext);
explicit WordPerfectImportFilterDialog();
};