mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#982278 Resource leak in object

Browse Source 
Change-Id: I0d0cf666ac8ecd55b4d3ba783b1e17670d6eb566
This commit is contained in:
Caolán McNamara
2014-08-07 14:00:44 +01:00
parent e5e24bdc33
commit 92c5536cd5
3 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
editeng/source/editeng/eerdll.cxx
View File

@@ -200,7 +200,6 @@ EditResId::EditResId( sal_uInt16 nId ):
EditDLL::EditDLL() EditDLL::EditDLL()
{ {
pGlobalData = new GlobalEditData; pGlobalData = new GlobalEditData;
pResMgr = ResMgr::CreateResMgr( "editeng", Application::GetSettings().GetUILanguageTag() );
} }
EditDLL::~EditDLL() EditDLL::~EditDLL()
@@ -208,4 +207,13 @@ EditDLL::~EditDLL()
delete pGlobalData; delete pGlobalData;
} }
static ResMgr* pResMgr=0;
ResMgr* EditDLL::GetResMgr()
{
if (!pResMgr)
pResMgr = ResMgr::CreateResMgr("editeng", Application::GetSettings().GetUILanguageTag());
return pResMgr;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

3
include/editeng/eerdll.hxx
View File

@@ -34,14 +34,13 @@ public:
class EditDLL class EditDLL
{ {
ResMgr* pResMgr;
GlobalEditData* pGlobalData; GlobalEditData* pGlobalData;
public: public:
EditDLL(); EditDLL();
~EditDLL(); ~EditDLL();
ResMgr* GetResMgr() const { return pResMgr; } static ResMgr* GetResMgr();
GlobalEditData* GetGlobalData() const { return pGlobalData; } GlobalEditData* GetGlobalData() const { return pGlobalData; }
static EditDLL& Get(); static EditDLL& Get();
}; };

6
svx/source/dialog/dialmgr.cxx
View File

@@ -24,12 +24,10 @@
static ResMgr* pResMgr=0; static ResMgr* pResMgr=0;
// struct DialogsResMgr --------------------------------------------------
ResMgr* DialogsResMgr::GetResMgr() ResMgr* DialogsResMgr::GetResMgr()
{ {
if ( !pResMgr ) if (!pResMgr)
pResMgr = ResMgr::CreateResMgr( "svx", Application::GetSettings().GetUILanguageTag() ); pResMgr = ResMgr::CreateResMgr("svx", Application::GetSettings().GetUILanguageTag());
return pResMgr; return pResMgr;
} }