mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in SvXMLImportItemMapper::handleSpecialItem

Browse Source 
Change-Id: Ie1a8fdafb64f6374ae9108dbb47592b044703cc9
Reviewed-on: https://gerrit.libreoffice.org/81008
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-17 13:12:25 +02:00
parent 49e0127419
commit 933592b201
4 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -343,9 +343,6 @@ sw/source/filter/ww8/wrtww8.hxx:863
sw/source/filter/xml/xmlexpit.hxx:84 sw/source/filter/xml/xmlexpit.hxx:84
void SvXMLExportItemMapper::handleElementItem(class SvXMLExport &,const struct SvXMLItemMapEntry &,const class SfxPoolItem &,const class SvXMLUnitConverter &,const class SfxItemSet &,enum SvXmlExportFlags,)const void SvXMLExportItemMapper::handleElementItem(class SvXMLExport &,const struct SvXMLItemMapEntry &,const class SfxPoolItem &,const class SvXMLUnitConverter &,const class SfxItemSet &,enum SvXmlExportFlags,)const
011000 011000
sw/source/filter/xml/xmlimpit.hxx:48
_Bool SvXMLImportItemMapper::handleSpecialItem(const struct SvXMLItemMapEntry &,class SfxPoolItem &,class SfxItemSet &,const class rtl::OUString &,const class SvXMLUnitConverter &,const class SvXMLNamespaceMap &,)
111110
vcl/inc/outdev.h:122 vcl/inc/outdev.h:122
_Bool ImplGlyphFallbackFontSubstitution::FindFontSubstitute(class FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString &,)const _Bool ImplGlyphFallbackFontSubstitution::FindFontSubstitute(class FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString &,)const
101 101

6
sw/source/filter/xml/xmlimpit.cxx
View File

@@ -133,8 +133,7 @@ void SvXMLImportItemMapper::importXML( SfxItemSet& rSet,
else else
{ {
bPut = handleSpecialItem( *pEntry, *pNewItem, rSet, bPut = handleSpecialItem( *pEntry, *pNewItem, rSet,
rValue, rUnitConverter, rValue, rUnitConverter );
rNamespaceMap );
} }
if( bPut ) if( bPut )
@@ -192,8 +191,7 @@ SvXMLImportItemMapper::handleSpecialItem( const SvXMLItemMapEntry& /*rEntry*/,
SfxPoolItem& /*rItem*/, SfxPoolItem& /*rItem*/,
SfxItemSet& /*rSet*/, SfxItemSet& /*rSet*/,
const OUString& /*rValue*/, const OUString& /*rValue*/,
const SvXMLUnitConverter& /*rUnitConverter*/, const SvXMLUnitConverter& /*rUnitConverter*/ )
const SvXMLNamespaceMap& /*rNamespaceMap*/ )
{ {
OSL_FAIL( "unsupported special item in xml import" ); OSL_FAIL( "unsupported special item in xml import" );
return false; return false;

3
sw/source/filter/xml/xmlimpit.hxx
View File

@@ -49,8 +49,7 @@ public:
SfxPoolItem& rItem, SfxPoolItem& rItem,
SfxItemSet& rSet, SfxItemSet& rSet,
const OUString& rValue, const OUString& rValue,
const SvXMLUnitConverter& rUnitConverter, const SvXMLUnitConverter& rUnitConverter );
const SvXMLNamespaceMap& rNamespaceMap );
/** this method is called for every item that has the /** this method is called for every item that has the
MID_SW_FLAG_NO_ITEM_IMPORT flag set */ MID_SW_FLAG_NO_ITEM_IMPORT flag set */

6
sw/source/filter/xml/xmlitemi.cxx
View File

@@ -63,8 +63,7 @@ public:
SfxPoolItem& rItem, SfxPoolItem& rItem,
SfxItemSet& rSet, SfxItemSet& rSet,
const OUString& rValue, const OUString& rValue,
const SvXMLUnitConverter& rUnitConverter, const SvXMLUnitConverter& rUnitConverter ) override;
const SvXMLNamespaceMap& rNamespaceMap ) override;
virtual bool virtual bool
handleNoItem(SvXMLItemMapEntry const& rEntry, handleNoItem(SvXMLItemMapEntry const& rEntry,
@@ -114,8 +113,7 @@ bool SwXMLImportTableItemMapper_Impl::handleSpecialItem(
SfxPoolItem& rItem, SfxPoolItem& rItem,
SfxItemSet& rItemSet, SfxItemSet& rItemSet,
const OUString& rValue, const OUString& rValue,
const SvXMLUnitConverter& rUnitConv, const SvXMLUnitConverter& rUnitConv )
const SvXMLNamespaceMap& )
{ {
bool bRet = false; bool bRet = false;
sal_uInt16 nMemberId = static_cast< sal_Int16 >(rEntry.nMemberId & MID_SW_FLAG_MASK); sal_uInt16 nMemberId = static_cast< sal_Int16 >(rEntry.nMemberId & MID_SW_FLAG_MASK);