mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sd edit diagram: dispose the diagram dialog after we don't need it

Browse Source 
Fixes:

soffice.bin: /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:110: VclPtr<reference_type>::~VclPtr() [with reference_type = VclAbstractDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed.

Change-Id: I4ac6a2e874f816f29ab593e3cbc87f3ddebb8109
Reviewed-on: https://gerrit.libreoffice.org/78840
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This commit is contained in:
Miklos Vajna
2019-09-12 20:15:53 +02:00
parent 7dfc3d2def
commit 9463ee0a10
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sd/source/ui/view/drviews3.cxx
View File

@@ -510,7 +510,7 @@ void DrawViewShell::ExecCtrl(SfxRequest& rReq)
if (oox::drawingml::DrawingML::IsDiagram(xShape)) if (oox::drawingml::DrawingML::IsDiagram(xShape))
{ {
VclAbstractDialogFactory* pFact = VclAbstractDialogFactory::Create(); VclAbstractDialogFactory* pFact = VclAbstractDialogFactory::Create();
VclPtr<VclAbstractDialog> pDlg ScopedVclPtr<VclAbstractDialog> pDlg
= pFact->CreateDiagramDialog(GetFrameWeld(), pObj->GetDiagramData()); = pFact->CreateDiagramDialog(GetFrameWeld(), pObj->GetDiagramData());
pDlg->Execute(); pDlg->Execute();
} }