mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

inline SfxPoolItem copy constructor

Browse Source 
as delegating constructor.
In preparation to remove default able copy constructors
of derived classes.

Change-Id: I516efa70ef2a06079194aafbf630e151138c6bbc
Reviewed-on: https://gerrit.libreoffice.org/42923
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
This commit is contained in:
Jochen Nitschke
2017-09-28 04:19:25 +02:00
parent a845cc8015
commit 950742b3ac
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/svl/poolitem.hxx
View File

@@ -137,7 +137,8 @@ private:
protected: protected:
explicit SfxPoolItem( sal_uInt16 nWhich = 0 ); explicit SfxPoolItem( sal_uInt16 nWhich = 0 );
SfxPoolItem( const SfxPoolItem& ); SfxPoolItem( const SfxPoolItem& rCopy)
: SfxPoolItem(rCopy.m_nWhich) {}
public: public:
virtual ~SfxPoolItem(); virtual ~SfxPoolItem();

7
svl/source/items/poolitem.cxx
View File

@@ -35,13 +35,6 @@ SfxPoolItem::SfxPoolItem(sal_uInt16 const nWhich)
} }
SfxPoolItem::SfxPoolItem( const SfxPoolItem& rCpy )
: m_nRefCount(0) // don't copy that
, m_nWhich(rCpy.m_nWhich)
, m_nKind(SfxItemKind::NONE)
{}
SfxPoolItem::~SfxPoolItem() SfxPoolItem::~SfxPoolItem()
{ {
assert((m_nRefCount == 0 || m_nRefCount > SFX_ITEMS_MAXREF) assert((m_nRefCount == 0 || m_nRefCount > SFX_ITEMS_MAXREF)