mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tdf#89329: use unique_ptr for pImpl in odbcconfig

Browse Source 
Change-Id: Ieba9b60dfa8e61d41a18096e1bddc3c8c70b2e2f
Reviewed-on: https://gerrit.libreoffice.org/28113
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
This commit is contained in:
Arnold Dumas
2016-08-14 21:39:51 +02:00
committed by Noel Grandin
parent 2a174c2f6f
commit 95abd2fcc7
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dbaccess/source/ui/dlg/odbcconfig.cxx
View File

@@ -147,7 +147,6 @@ OOdbcEnumeration::OOdbcEnumeration()
OOdbcEnumeration::~OOdbcEnumeration() OOdbcEnumeration::~OOdbcEnumeration()
{ {
freeEnv(); freeEnv();
delete m_pImpl;
unload(); unload();
} }

2
dbaccess/source/ui/dlg/odbcconfig.hxx
View File

@@ -53,7 +53,7 @@ class OOdbcEnumeration
oslGenericFunction m_pDataSources; oslGenericFunction m_pDataSources;
#endif #endif
OdbcTypesImpl* m_pImpl; std::unique_ptr<OdbcTypesImpl> m_pImpl;
// needed because we can't have a member of type SQLHANDLE: this would require us to include the respective // needed because we can't have a member of type SQLHANDLE: this would require us to include the respective
// ODBC file, which would lead to a lot of conflicts with other includes // ODBC file, which would lead to a lot of conflicts with other includes