mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

combine the pass-by-ref clang plugins

Browse Source 
Change-Id: Idac24afb7cb67fa2d539553fb9fa049c2d61ecf0
This commit is contained in:
Noel Grandin
2014-05-16 11:18:12 +02:00
parent 0bc869459b
commit 97d50c425f
2 changed files with 14 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
compilerplugins/clang/passsequencebyref.cxx
View File

@@ -1,63 +0,0 @@
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <string>
#include "plugin.hxx"
// Find places where com::sun::star::uno::Sequence is passed by value.
// It's not very efficient, because that copies a whole list
// They should rather be passed by reference.
namespace {
class PassSequenceByRef:
public RecursiveASTVisitor<PassSequenceByRef>, public loplugin::Plugin
{
public:
explicit PassSequenceByRef(InstantiationData const & data): Plugin(data) {}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitFunctionDecl(const FunctionDecl * decl);
};
bool PassSequenceByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
if (ignoreLocation(functionDecl)) {
return true;
}
// only warn on the definition/prototype of the function,
// not on the function implementation
if (functionDecl->isThisDeclarationADefinition() && functionDecl->getPreviousDecl() != nullptr) {
return true;
}
unsigned n = functionDecl->getNumParams();
for (unsigned i = 0; i != n; ++i) {
const ParmVarDecl * pvDecl = functionDecl->getParamDecl(i);
QualType t1 { pvDecl->getType() };
if (!t1->isClassType()) {
continue;
}
string typeName = t1.getUnqualifiedType().getCanonicalType().getAsString();
if (typeName.find("class com::sun::star::uno::Sequence") == 0) {
report(
DiagnosticsEngine::Warning,
"passing css::uno::Sequence by value, rather pass by reference .e.g. 'const css::uno::Sequence&' " + typeName,
pvDecl->getSourceRange().getBegin())
<< pvDecl->getSourceRange();
}
}
return true;
}
loplugin::Plugin::Registration< PassSequenceByRef > X("passsequencebyref");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

21
compilerplugins/clang/passstringbyref.cxx → compilerplugins/clang/passstuffbyref.cxx
View File

@@ -11,25 +11,25 @@
#include "plugin.hxx"
// Find places where OUString and OString are passed by value.
// Find places where various things are passed by value.
// It's not very efficient, because we generally end up copying it twice - once into the parameter and
// again into the destination OUString.
// again into the destination.
// They should rather be passed by reference.
namespace {
class PassStringByRef:
public RecursiveASTVisitor<PassStringByRef>, public loplugin::Plugin
class PassStuffByRef:
public RecursiveASTVisitor<PassStuffByRef>, public loplugin::Plugin
{
public:
explicit PassStringByRef(InstantiationData const & data): Plugin(data) {}
explicit PassStuffByRef(InstantiationData const & data): Plugin(data) {}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitFunctionDecl(const FunctionDecl * decl);
};
bool PassStringByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
bool PassStuffByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
if (ignoreLocation(functionDecl)) {
return true;
}
@@ -60,11 +60,18 @@ bool PassStringByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
pvDecl->getSourceRange().getBegin())
<< pvDecl->getSourceRange();
}
else if (typeName.find("class com::sun::star::uno::Sequence") == 0) {
report(
DiagnosticsEngine::Warning,
"passing css::uno::Sequence by value, rather pass by reference .e.g. 'const css::uno::Sequence&' " + typeName,
pvDecl->getSourceRange().getBegin())
<< pvDecl->getSourceRange();
}
}
return true;
}
loplugin::Plugin::Registration< PassStringByRef > X("passstringbyref");
loplugin::Plugin::Registration< PassStuffByRef > X("passstuffbyref");
}