mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove confusing casts between synonyms

Browse Source 
oslMutex and oslMutexImpl* are synonyms (via two typedefs).
Casting between them makes the reader believe some more nefarious trick is at hand.

Change-Id: Ib0e609fd1facca4d47242392ed2f8ff08451346b
This commit is contained in:
Lionel Elie Mamane
2013-09-07 09:39:47 +02:00
parent 8318ecfa88
commit 98f08e463d
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
sal/osl/unx/mutex.c
View File

@@ -42,7 +42,7 @@ typedef struct _oslMutexImpl
/*****************************************************************************/ /*****************************************************************************/
oslMutex SAL_CALL osl_createMutex() oslMutex SAL_CALL osl_createMutex()
{ {
oslMutexImpl* pMutex = (oslMutexImpl*) malloc(sizeof(oslMutexImpl)); oslMutexImpl* pMutex = malloc(sizeof(oslMutexImpl));
pthread_mutexattr_t aMutexAttr; pthread_mutexattr_t aMutexAttr;
int nRet=0; int nRet=0;
@@ -69,16 +69,14 @@ oslMutex SAL_CALL osl_createMutex()
pthread_mutexattr_destroy(&aMutexAttr); pthread_mutexattr_destroy(&aMutexAttr);
return (oslMutex) pMutex; return pMutex;
} }
/*****************************************************************************/ /*****************************************************************************/
/* osl_destroyMutex */ /* osl_destroyMutex */
/*****************************************************************************/ /*****************************************************************************/
void SAL_CALL osl_destroyMutex(oslMutex Mutex) void SAL_CALL osl_destroyMutex(oslMutexImpl *pMutex)
{ {
oslMutexImpl* pMutex = (oslMutexImpl*) Mutex;
OSL_ASSERT(pMutex); OSL_ASSERT(pMutex);
if ( pMutex != 0 ) if ( pMutex != 0 )
@@ -101,10 +99,8 @@ void SAL_CALL osl_destroyMutex(oslMutex Mutex)
/*****************************************************************************/ /*****************************************************************************/
/* osl_acquireMutex */ /* osl_acquireMutex */
/*****************************************************************************/ /*****************************************************************************/
sal_Bool SAL_CALL osl_acquireMutex(oslMutex Mutex) sal_Bool SAL_CALL osl_acquireMutex(oslMutexImpl *pMutex)
{ {
oslMutexImpl* pMutex = (oslMutexImpl*) Mutex;
OSL_ASSERT(pMutex); OSL_ASSERT(pMutex);
if ( pMutex != 0 ) if ( pMutex != 0 )
@@ -128,10 +124,8 @@ sal_Bool SAL_CALL osl_acquireMutex(oslMutex Mutex)
/*****************************************************************************/ /*****************************************************************************/
/* osl_tryToAcquireMutex */ /* osl_tryToAcquireMutex */
/*****************************************************************************/ /*****************************************************************************/
sal_Bool SAL_CALL osl_tryToAcquireMutex(oslMutex Mutex) sal_Bool SAL_CALL osl_tryToAcquireMutex(oslMutexImpl *pMutex)
{ {
oslMutexImpl* pMutex = (oslMutexImpl*) Mutex;
OSL_ASSERT(pMutex); OSL_ASSERT(pMutex);
if ( pMutex ) if ( pMutex )
@@ -151,10 +145,8 @@ sal_Bool SAL_CALL osl_tryToAcquireMutex(oslMutex Mutex)
/*****************************************************************************/ /*****************************************************************************/
/* osl_releaseMutex */ /* osl_releaseMutex */
/*****************************************************************************/ /*****************************************************************************/
sal_Bool SAL_CALL osl_releaseMutex(oslMutex Mutex) sal_Bool SAL_CALL osl_releaseMutex(oslMutexImpl *pMutex)
{ {
oslMutexImpl* pMutex = (oslMutexImpl*) Mutex;
OSL_ASSERT(pMutex); OSL_ASSERT(pMutex);
if ( pMutex ) if ( pMutex )