mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cppcheck inefficient checking for emptiness

Browse Source 
From cppcheck: Using xxxx.empty() instead of xxxx.size() can be faster.
 xxxx.size() can take linear time but xxxx.empty() is guaranteed to take
 constant time
This commit is contained in:
Kayo Hamid 2011-04-22 11:31:13 +02:00 committed by Cédric Bosdonnat
parent cdc7c5772a
commit 9ab9d69c7d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
basegfx/source/polygon/b2dpolypolygoncutter.cxx
View File

@ -933,7 +933,7 @@ namespace basegfx
// first step: prepareForPolygonOperation and simple merge of non-overlapping // first step: prepareForPolygonOperation and simple merge of non-overlapping
// PolyPolygons for speedup; this is possible for the wanted OR-operation // PolyPolygons for speedup; this is possible for the wanted OR-operation
if(aInput.size()) if(!aInput.empty())
{ {
std::vector< basegfx::B2DPolyPolygon > aResult; std::vector< basegfx::B2DPolyPolygon > aResult;
aResult.reserve(aInput.size()); aResult.reserve(aInput.size());
@ -942,7 +942,7 @@ namespace basegfx
{ {
const basegfx::B2DPolyPolygon aCandidate(prepareForPolygonOperation(aInput[a])); const basegfx::B2DPolyPolygon aCandidate(prepareForPolygonOperation(aInput[a]));
if(aResult.size()) if(!aResult.empty())
{ {
const B2DRange aCandidateRange(aCandidate.getB2DRange()); const B2DRange aCandidateRange(aCandidate.getB2DRange());
bool bCouldMergeSimple(false); bool bCouldMergeSimple(false);