mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comment the RTL_CONSTASCII_STRINGPARAM should be kept in regexp.cxx

Browse Source 
Change-Id: I3cd2129d98c3d936d8ec31f89554b37f12427c1c
This commit is contained in:
Chr. Rossmanith
2013-04-06 16:50:34 +02:00
parent 1a7f09b3eb
commit a07505865b
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ucb/source/regexp/regexp.cxx
View File

@@ -374,6 +374,9 @@ Regexp Regexp::parse(rtl::OUString const & rRegexp)
if (p == pEnd) if (p == pEnd)
throw lang::IllegalArgumentException(); throw lang::IllegalArgumentException();
// This and the matchString() calls below are some of the few places where
// RTL_CONSTASCII_STRINGPARAM() should NOT be removed.
// (c.f. https://gerrit.libreoffice.org/3117)
if (matchString(&p, pEnd, RTL_CONSTASCII_STRINGPARAM(".*"))) if (matchString(&p, pEnd, RTL_CONSTASCII_STRINGPARAM(".*")))
{ {
if (p != pEnd) if (p != pEnd)