clang-tidy:readability-redundant-member-init

Change-Id: I48e6fb31df732805423b89ed91b6e4363a69b668
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121150
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2021-08-27 15:28:13 +02:00
parent 05ff3d67d0
commit a125236448
53 changed files with 28 additions and 166 deletions

View File

@@ -82,8 +82,7 @@ namespace cppcanvas::internal
const OutDevState& rState ) :
CachedPrimitiveBase( rCanvas, true ),
mxBitmap( vcl::unotools::xBitmapFromBitmapEx( rBmpEx ) ),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
@@ -109,8 +108,7 @@ namespace cppcanvas::internal
const OutDevState& rState ) :
CachedPrimitiveBase( rCanvas, true ),
mxBitmap( vcl::unotools::xBitmapFromBitmapEx( rBmpEx ) ),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);

View File

@@ -34,8 +34,6 @@ namespace cppcanvas::internal
CachedPrimitiveBase::CachedPrimitiveBase( const CanvasSharedPtr& rCanvas,
bool bOnlyRedrawWithSameTransform ) :
mpCanvas( rCanvas ),
mxCachedPrimitive(),
maLastTransformation(),
mbOnlyRedrawWithSameTransform( bOnlyRedrawWithSameTransform )
{
// TODO(F2): also store last view transform, and refuse to

View File

@@ -2654,8 +2654,7 @@ namespace cppcanvas::internal
{
public:
explicit AreaQuery( const ::basegfx::B2DHomMatrix& rTransformation ) :
maTransformation( rTransformation ),
maBounds()
maTransformation( rTransformation )
{
}
@@ -2841,7 +2840,6 @@ namespace cppcanvas::internal
const GDIMetaFile& rMtf,
const Parameters& rParams )
: CanvasGraphicHelper(rCanvas)
, maActions()
, nFrameLeft(0)
, nFrameTop(0)
, nFrameRight(0)

View File

@@ -74,8 +74,7 @@ namespace cppcanvas::internal
const OutDevState& rState ) :
maStartPoint( rStartPoint ),
maEndPoint( rEndPoint ),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
maState.DeviceColor = rState.lineColor;

View File

@@ -75,8 +75,7 @@ namespace cppcanvas::internal
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
maPoint( rPoint ),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
maState.DeviceColor = rState.lineColor;
@@ -87,8 +86,7 @@ namespace cppcanvas::internal
const OutDevState& rState,
const ::Color& rAltColor ) :
maPoint( rPoint ),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
maState.DeviceColor = vcl::unotools::colorToDoubleSequence(

View File

@@ -89,9 +89,7 @@ namespace cppcanvas::internal
CachedPrimitiveBase( rCanvas, false ),
mxPolyPoly( ::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon( rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ),
maBounds( ::basegfx::utils::getRange(rPolyPoly) ),
mpCanvas( rCanvas ),
maState(),
maFillColor()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
@@ -111,9 +109,7 @@ namespace cppcanvas::internal
CachedPrimitiveBase( rCanvas, false ),
mxPolyPoly( ::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon( rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ),
maBounds( ::basegfx::utils::getRange(rPolyPoly) ),
mpCanvas( rCanvas ),
maState(),
maFillColor()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
@@ -263,7 +259,6 @@ namespace cppcanvas::internal
mxPolyPoly( ::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon( rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ),
maBounds( ::basegfx::utils::getRange(rPolyPoly) ),
mpCanvas( rCanvas ),
maState(),
maTexture( rTexture )
{
tools::initRenderState(maState,rState);
@@ -373,7 +368,6 @@ namespace cppcanvas::internal
mxPolyPoly( ::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon( rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ),
maBounds( ::basegfx::utils::getRange(rPolyPoly) ),
mpCanvas( rCanvas ),
maState(),
maStrokeAttributes( rStrokeAttributes )
{
tools::initRenderState(maState,rState);

View File

@@ -643,7 +643,6 @@ namespace cppcanvas::internal
mxFont( rState.xFont ),
maStringContext( rString, nStartPos, nLen ),
mpCanvas( rCanvas ),
maState(),
maTextDirection( rState.textDirection )
{
init( maState, mxFont,
@@ -664,7 +663,6 @@ namespace cppcanvas::internal
mxFont( rState.xFont ),
maStringContext( rString, nStartPos, nLen ),
mpCanvas( rCanvas ),
maState(),
maTextDirection( rState.textDirection )
{
init( maState, mxFont,
@@ -831,10 +829,7 @@ namespace cppcanvas::internal
mxFont( rState.xFont ),
maStringContext( rText, nStartPos, nLen ),
mpCanvas( rCanvas ),
maState(),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maLinesOverallSize(),
mxTextLines(),
maReliefOffset( rReliefOffset ),
maReliefColor( rReliefColor ),
maShadowOffset( rShadowOffset ),
@@ -873,10 +868,7 @@ namespace cppcanvas::internal
mxFont( rState.xFont ),
maStringContext( rText, nStartPos, nLen ),
mpCanvas( rCanvas ),
maState(),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maLinesOverallSize(),
mxTextLines(),
maReliefOffset( rReliefOffset ),
maReliefColor( rReliefColor ),
maShadowOffset( rShadowOffset ),
@@ -1071,9 +1063,7 @@ namespace cppcanvas::internal
const uno::Sequence< double >& rOffsets,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
mxTextLayout(),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
initLayoutWidth(mnLayoutWidth, rOffsets);
@@ -1096,9 +1086,7 @@ namespace cppcanvas::internal
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform ) :
mxTextLayout(),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
initLayoutWidth(mnLayoutWidth, rOffsets);
@@ -1288,9 +1276,7 @@ namespace cppcanvas::internal
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
mxTextLayout(),
mpCanvas( rCanvas ),
maState(),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maTextLinesHelper(mpCanvas, rState),
maReliefOffset( rReliefOffset ),
@@ -1328,9 +1314,7 @@ namespace cppcanvas::internal
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform ) :
mxTextLayout(),
mpCanvas( rCanvas ),
maState(),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maTextLinesHelper(mpCanvas, rState),
maReliefOffset( rReliefOffset ),
@@ -1677,16 +1661,13 @@ namespace cppcanvas::internal
mxTextPoly( rTextPoly ),
maOffsets( rOffsets ),
mpCanvas( rCanvas ),
maState(),
mnOutlineWidth( calcOutlineWidth(rState,rVDev) ),
maFillColor(
vcl::unotools::colorToDoubleSequence(
COL_WHITE,
rCanvas->getUNOCanvas()->getDevice()->getDeviceColorSpace() )),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maLinesOverallSize(),
maOutlineBounds( rOutlineBounds ),
mxTextLines(),
maReliefOffset( rReliefOffset ),
maReliefColor( rReliefColor ),
maShadowOffset( rShadowOffset ),
@@ -1723,16 +1704,13 @@ namespace cppcanvas::internal
mxTextPoly( rTextPoly ),
maOffsets( rOffsets ),
mpCanvas( rCanvas ),
maState(),
mnOutlineWidth( calcOutlineWidth(rState,rVDev) ),
maFillColor(
vcl::unotools::colorToDoubleSequence(
COL_WHITE,
rCanvas->getUNOCanvas()->getDevice()->getDeviceColorSpace() )),
maTextLineInfo( tools::createTextLineInfo( rVDev, rState ) ),
maLinesOverallSize(),
maOutlineBounds( rOutlineBounds ),
mxTextLines(),
maReliefOffset( rReliefOffset ),
maReliefColor( rReliefColor ),
maShadowOffset( rShadowOffset ),

View File

@@ -144,10 +144,7 @@ namespace cppcanvas::internal
mpGroupMtf( std::move(rGroupMtf) ),
mpAlphaGradient( std::move(rAlphaGradient) ),
maDstSize( rDstSize ),
mxBufferBitmap(),
maLastTransformation(),
mpCanvas( rCanvas ),
maState()
mpCanvas( rCanvas )
{
tools::initRenderState(maState,rState);
implSetupTransform( maState, rDstPoint );

View File

@@ -34,7 +34,6 @@ using namespace ::com::sun::star;
namespace cppcanvas::internal
{
CanvasGraphicHelper::CanvasGraphicHelper( const CanvasSharedPtr& rParentCanvas ) :
maClipPolyPolygon(),
mpCanvas( rParentCanvas )
{
OSL_ENSURE( mpCanvas && mpCanvas->getUNOCanvas().is(),

View File

@@ -32,8 +32,7 @@ namespace cppcanvas::internal
ImplBitmap::ImplBitmap( const CanvasSharedPtr& rParentCanvas,
const uno::Reference< rendering::XBitmap >& rBitmap ) :
CanvasGraphicHelper( rParentCanvas ),
mxBitmap( rBitmap ),
mpBitmapCanvas()
mxBitmap( rBitmap )
{
OSL_ENSURE( mxBitmap.is(), "ImplBitmap::ImplBitmap: no valid bitmap" );

View File

@@ -35,8 +35,6 @@ namespace cppcanvas::internal
{
ImplCanvas::ImplCanvas( const uno::Reference< rendering::XCanvas >& xCanvas ) :
maViewState(),
maClipPolyPolygon(),
mxCanvas( xCanvas )
{
OSL_ENSURE( mxCanvas.is(), "Canvas::Canvas() invalid XCanvas" );

View File

@@ -33,7 +33,6 @@ namespace cppcanvas::internal
ImplSprite( rParentCanvas,
rSprite,
rTransformArbiter ),
mpLastCanvas(),
mxCustomSprite( rSprite )
{
OSL_ENSURE( rParentCanvas.is(), "ImplCustomSprite::ImplCustomSprite(): Invalid canvas" );

View File

@@ -45,8 +45,6 @@ namespace cppcanvas::internal
rendering::PathCapType::ROUND,
rendering::PathCapType::ROUND,
rendering::PathJoinType::ROUND ),
maFillColor(),
maStrokeColor(),
mbFillColorSet( false ),
mbStrokeColorSet( false )
{

View File

@@ -33,7 +33,6 @@ namespace cppcanvas::internal
ImplSprite::ImplSprite( const uno::Reference< rendering::XSpriteCanvas >& rParentCanvas,
const uno::Reference< rendering::XSprite >& rSprite,
const ImplSpriteCanvas::TransformationArbiterSharedPtr& rTransformArbiter ) :
mxGraphicDevice(),
mxSprite( rSprite ),
mpTransformArbiter( rTransformArbiter )
{