mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:useuniqueptr: svl (clang-cl)

Browse Source 
Change-Id: Id8705c82ab87724b0542acbfe0ad165f889f267a
This commit is contained in:
Stephan Bergmann
2017-07-17 17:24:48 +02:00
parent 143b3a2f3c
commit a1467c8a52
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/svl/svdde.hxx
View File

@@ -180,7 +180,7 @@ class SVL_DLLPUBLIC DdeConnection
std::vector<DdeTransaction*> aTransactions; std::vector<DdeTransaction*> aTransactions;
DdeString* pService; DdeString* pService;
DdeString* pTopic; DdeString* pTopic;
DdeImp* pImp; std::unique_ptr<DdeImp> pImp;
public: public:
DdeConnection( SAL_UNUSED_PARAMETER const OUString&, SAL_UNUSED_PARAMETER const OUString& ); DdeConnection( SAL_UNUSED_PARAMETER const OUString&, SAL_UNUSED_PARAMETER const OUString& );

7
svl/source/svdde/ddecli.cxx
View File

@@ -23,7 +23,7 @@
#include <algorithm> #include <algorithm>
#include "ddeimp.hxx" #include "ddeimp.hxx"
#include <svl/svdde.hxx> #include <svl/svdde.hxx>
#include <o3tl/make_unique.hxx>
#include <osl/thread.h> #include <osl/thread.h>
#include <comphelper/solarmutex.hxx> #include <comphelper/solarmutex.hxx>
@@ -144,9 +144,9 @@ HDDEDATA CALLBACK DdeInternal::CliCallback( UINT nCode, UINT nCbType,
return nRet; return nRet;
} }
DdeConnection::DdeConnection( const OUString& rService, const OUString& rTopic ) DdeConnection::DdeConnection( const OUString& rService, const OUString& rTopic ):
pImp(o3tl::make_unique<DdeImp>())
{ {
pImp = new DdeImp;
pImp->nStatus = DMLERR_NO_ERROR; pImp->nStatus = DMLERR_NO_ERROR;
pImp->hConv = nullptr; pImp->hConv = nullptr;
@@ -206,7 +206,6 @@ DdeConnection::~DdeConnection()
ImpDeinitInstData(); ImpDeinitInstData();
} }
} }
delete pImp;
} }
bool DdeConnection::IsConnected() bool DdeConnection::IsConnected()

2
svl/unx/source/svdde/ddedummy.cxx
View File

@@ -77,6 +77,8 @@ void const * DdeData::getData() const
return nullptr; return nullptr;
} }
struct DdeImp {};
long DdeConnection::GetError() long DdeConnection::GetError()
{ {
return 0L; return 0L;