mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin unnecessaryparan improvements

Browse Source 
Change-Id: I73e945d6ec53537a0da45f6b6291018c7f251a7e
Reviewed-on: https://gerrit.libreoffice.org/39587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-07-05 14:30:39 +02:00
parent ee96ea7236
commit a1ead1a028
36 changed files with 78 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
compilerplugins/clang/unnecessaryparen.cxx
View File

@@ -31,6 +31,13 @@ public:
virtual void run() override
{
StringRef fn( compiler.getSourceManager().getFileEntryForID(
compiler.getSourceManager().getMainFileID())->getName() );
// fixing this makes the source in the .y files look horrible
if (loplugin::hasPathnamePrefix(fn, WORKDIR "/YaccTarget/unoidl/source/sourceprovider-parser.cxx"))
return;
if (loplugin::hasPathnamePrefix(fn, WORKDIR "/YaccTarget/idlc/source/parser.cxx"))
return;
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
@@ -45,7 +52,7 @@ bool UnnecessaryParen::VisitParenExpr(const ParenExpr* parenExpr)
if (parenExpr->getLocStart().isMacroID())
return true;
auto subParenExpr = dyn_cast<ParenExpr>(parenExpr->getSubExpr());
auto subParenExpr = dyn_cast<ParenExpr>(parenExpr->getSubExpr()->IgnoreImpCasts());
if (subParenExpr) {
if (subParenExpr->getLocStart().isMacroID())
return true;
@@ -62,7 +69,7 @@ bool UnnecessaryParen::VisitIfStmt(const IfStmt* ifStmt)
if (ignoreLocation(ifStmt))
return true;
if (auto parenExpr = dyn_cast<ParenExpr>(ifStmt->getCond())) {
if (auto parenExpr = dyn_cast<ParenExpr>(ifStmt->getCond()->IgnoreImpCasts())) {
if (parenExpr->getLocStart().isMacroID())
return true;
// assignments need extra parentheses or they generate a compiler warning