mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use UNO_QUERY_THROW instead of UNO_QUERY

Browse Source 
Previously, in SDK examples, de-referencing was done unconditionally
after obtaining a reference using UNO_QUERY. Now, we use UNO_QUERY_THROW
instead, to make sure cases where exceptions may occure can be handled
correctly.

Change-Id: Ic73ba3cfcad914dabb7ae3736ad1ae2bd6cc15bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164682
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
This commit is contained in:
Hossein
2024-03-12 10:21:32 +01:00
parent 1f93803aa1
commit a2265e8faa
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
odk/examples/DevelopersGuide/FirstSteps/FirstLoadComponent/cxx/FirstLoadComponent.cxx
View File

@@ -30,7 +30,6 @@
#include <com/sun/star/sheet/XSpreadsheetView.hpp> #include <com/sun/star/sheet/XSpreadsheetView.hpp>
#include <com/sun/star/table/CellVertJustify.hpp> #include <com/sun/star/table/CellVertJustify.hpp>
#include <com/sun/star/table/XCell.hpp> #include <com/sun/star/table/XCell.hpp>
#include <com/sun/star/uno/RuntimeException.hpp>
#include <com/sun/star/uno/Sequence.hxx> #include <com/sun/star/uno/Sequence.hxx>
#include <com/sun/star/uno/Type.hxx> #include <com/sun/star/uno/Type.hxx>
#include <com/sun/star/uno/XComponentContext.hpp> #include <com/sun/star/uno/XComponentContext.hpp>
@@ -63,20 +62,21 @@ SAL_IMPLEMENT_MAIN()
Reference<XInterface> desktop = xRemoteServiceManager->createInstanceWithContext( Reference<XInterface> desktop = xRemoteServiceManager->createInstanceWithContext(
"com.sun.star.frame.Desktop", xRemoteContext); "com.sun.star.frame.Desktop", xRemoteContext);
Reference<XComponentLoader> xComponentLoader Reference<XComponentLoader> xComponentLoader
= Reference<XComponentLoader>(desktop, UNO_QUERY); = Reference<XComponentLoader>(desktop, UNO_QUERY_THROW);
Sequence<PropertyValue> loadProps(0); Sequence<PropertyValue> loadProps(0);
Reference<XComponent> xSpreadsheetComponent = xComponentLoader->loadComponentFromURL( Reference<XComponent> xSpreadsheetComponent = xComponentLoader->loadComponentFromURL(
"private:factory/scalc", "_blank", 0, loadProps); "private:factory/scalc", "_blank", 0, loadProps);
Reference<XSpreadsheetDocument> xSpreadsheetDocument(xSpreadsheetComponent, UNO_QUERY); Reference<XSpreadsheetDocument> xSpreadsheetDocument(xSpreadsheetComponent,
UNO_QUERY_THROW);
Reference<XSpreadsheets> xSpreadsheets = xSpreadsheetDocument->getSheets(); Reference<XSpreadsheets> xSpreadsheets = xSpreadsheetDocument->getSheets();
xSpreadsheets->insertNewByName("MySheet", (sal_Int16)0); xSpreadsheets->insertNewByName("MySheet", (sal_Int16)0);
Type elemType = xSpreadsheets->getElementType(); Type elemType = xSpreadsheets->getElementType();
std::cout << elemType.getTypeName() << std::endl; std::cout << elemType.getTypeName() << std::endl;
Any sheet = xSpreadsheets->getByName("MySheet"); Any sheet = xSpreadsheets->getByName("MySheet");
Reference<XSpreadsheet> xSpreadsheet(sheet, UNO_QUERY); Reference<XSpreadsheet> xSpreadsheet(sheet, UNO_QUERY_THROW);
Reference<XCell> xCell = xSpreadsheet->getCellByPosition(0, 0); Reference<XCell> xCell = xSpreadsheet->getCellByPosition(0, 0);
xCell->setValue(21); xCell->setValue(21);
@@ -85,12 +85,12 @@ SAL_IMPLEMENT_MAIN()
xCell = xSpreadsheet->getCellByPosition(0, 2); xCell = xSpreadsheet->getCellByPosition(0, 2);
xCell->setFormula("=sum(A1:A2)"); xCell->setFormula("=sum(A1:A2)");
Reference<XPropertySet> xCellProps(xCell, UNO_QUERY); Reference<XPropertySet> xCellProps(xCell, UNO_QUERY_THROW);
xCellProps->setPropertyValue("CellStyle", Any(OUString("Result"))); xCellProps->setPropertyValue("CellStyle", Any(OUString("Result")));
Reference<XModel> xSpreadsheetModel(xSpreadsheetComponent, UNO_QUERY); Reference<XModel> xSpreadsheetModel(xSpreadsheetComponent, UNO_QUERY_THROW);
Reference<XController> xSpreadsheetController = xSpreadsheetModel->getCurrentController(); Reference<XController> xSpreadsheetController = xSpreadsheetModel->getCurrentController();
Reference<XSpreadsheetView> xSpreadsheetView(xSpreadsheetController, UNO_QUERY); Reference<XSpreadsheetView> xSpreadsheetView(xSpreadsheetController, UNO_QUERY_THROW);
xSpreadsheetView->setActiveSheet(xSpreadsheet); xSpreadsheetView->setActiveSheet(xSpreadsheet);
// ********************************************************* // *********************************************************
@@ -118,7 +118,7 @@ SAL_IMPLEMENT_MAIN()
// ********************************************************* // *********************************************************
// example for use of XEnumerationAccess // example for use of XEnumerationAccess
Reference<XCellRangesQuery> xCellQuery(sheet, UNO_QUERY); Reference<XCellRangesQuery> xCellQuery(sheet, UNO_QUERY_THROW);
Reference<XSheetCellRanges> xFormulaCells Reference<XSheetCellRanges> xFormulaCells
= xCellQuery->queryContentCells((sal_Int16)CellFlags::FORMULA); = xCellQuery->queryContentCells((sal_Int16)CellFlags::FORMULA);
Reference<XEnumerationAccess> xFormulas = xFormulaCells->getCells(); Reference<XEnumerationAccess> xFormulas = xFormulaCells->getCells();
@@ -126,8 +126,8 @@ SAL_IMPLEMENT_MAIN()
while (xFormulaEnum->hasMoreElements()) while (xFormulaEnum->hasMoreElements())
{ {
Reference<XCell> formulaCell(xFormulaEnum->nextElement(), UNO_QUERY); Reference<XCell> formulaCell(xFormulaEnum->nextElement(), UNO_QUERY_THROW);
Reference<XCellAddressable> xCellAddress(formulaCell, UNO_QUERY); Reference<XCellAddressable> xCellAddress(formulaCell, UNO_QUERY_THROW);
if (xCellAddress.is()) if (xCellAddress.is())
{ {
std::cout << "Formula cell in column " << xCellAddress->getCellAddress().Column std::cout << "Formula cell in column " << xCellAddress->getCellAddress().Column
@@ -136,7 +136,7 @@ SAL_IMPLEMENT_MAIN()
} }
} }
} }
catch (RuntimeException& e) catch (Exception& e)
{ {
std::cerr << e.Message << "\n"; std::cerr << e.Message << "\n";
return 1; return 1;