mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PVS: the 'bDummy' variable was not initialized.

Browse Source 
This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument.

Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This commit is contained in:
Xisco Fauli
2024-11-28 15:57:25 +01:00
parent 13ac356a32
commit a2dbdee29e
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
chart2/source/tools/ExplicitCategoriesProvider.cxx
View File

@@ -32,6 +32,7 @@
#include <DataSeries.hxx> #include <DataSeries.hxx>
#include <com/sun/star/chart2/AxisType.hpp> #include <com/sun/star/chart2/AxisType.hpp>
#include <com/sun/star/chart/ChartDataRowSource.hpp>
#include <o3tl/compare.hxx> #include <o3tl/compare.hxx>
#include <o3tl/safeint.hxx> #include <o3tl/safeint.hxx>
#include <rtl/ustrbuf.hxx> #include <rtl/ustrbuf.hxx>
@@ -108,11 +109,18 @@ ExplicitCategoriesProvider::ExplicitCategoriesProvider( const rtl::Reference< Ba
if( !aSeries.empty() ) if( !aSeries.empty() )
{ {
const rtl::Reference< DataSeries >& xSeriesSource = aSeries.front(); const rtl::Reference< DataSeries >& xSeriesSource = aSeries.front();
OUString aStringDummy; for(const auto& rArgument : xDataProvider->detectArguments( xSeriesSource))
bool bDummy; {
uno::Sequence< sal_Int32 > aSeqDummy; if ( rArgument.Name == "DataRowSource" )
DataSourceHelper::readArguments( xDataProvider->detectArguments( xSeriesSource), {
aStringDummy, aSeqDummy, bSeriesUsesColumns, bDummy, bDummy ); css::chart::ChartDataRowSource eRowSource;
if( rArgument.Value >>= eRowSource )
{
bSeriesUsesColumns = (eRowSource == css::chart::ChartDataRowSource_COLUMNS);
break;
}
}
}
} }
if( bSeriesUsesColumns ) if( bSeriesUsesColumns )
m_aSplitCategoriesList = comphelper::sequenceToContainer<std::vector<Reference<data::XLabeledDataSequence>>>(aColumns); m_aSplitCategoriesList = comphelper::sequenceToContainer<std::vector<Reference<data::XLabeledDataSequence>>>(aColumns);