mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove unnecessary "const &" qualifier from T* parameters

Browse Source 
e.g. convert code like
    foo(X * const & p)
to
    foo(X * p)
since the "const &" part of it adds nothing useful.

Change-Id: Icf5f2041517259e7b6e055b75ed1e0e77c547da5
This commit is contained in:
Noel Grandin 2014-07-18 11:45:07 +02:00
parent 9aa80fcb29
commit a517898052
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
connectivity/source/parse/sqlnode.cxx
View File

@ -822,7 +822,7 @@ void OSQLParser::killThousandSeparator(OSQLParseNode* pLiteral)
} }
} }
OSQLParseNode* OSQLParser::convertNode(sal_Int32 nType,OSQLParseNode*const& pLiteral) OSQLParseNode* OSQLParser::convertNode(sal_Int32 nType, OSQLParseNode* pLiteral)
{ {
if ( !pLiteral ) if ( !pLiteral )
return NULL; return NULL;
@ -940,7 +940,7 @@ OSQLParseNode* OSQLParser::convertNode(sal_Int32 nType,OSQLParseNode*const& pLit
return pReturn; return pReturn;
} }
sal_Int16 OSQLParser::buildPredicateRule(OSQLParseNode*& pAppend,OSQLParseNode* const pLiteral,OSQLParseNode*const & pCompare,OSQLParseNode* pLiteral2) sal_Int16 OSQLParser::buildPredicateRule(OSQLParseNode*& pAppend, OSQLParseNode* pLiteral, OSQLParseNode* pCompare, OSQLParseNode* pLiteral2)
{ {
OSL_ENSURE(inPredicateCheck(),"Only in predicate check allowed!"); OSL_ENSURE(inPredicateCheck(),"Only in predicate check allowed!");
sal_Int16 nErg = 0; sal_Int16 nErg = 0;
@ -969,7 +969,7 @@ sal_Int16 OSQLParser::buildPredicateRule(OSQLParseNode*& pAppend,OSQLParseNode*
return nErg; return nErg;
} }
sal_Int16 OSQLParser::buildLikeRule(OSQLParseNode* const& pAppend, OSQLParseNode*& pLiteral, const OSQLParseNode* pEscape) sal_Int16 OSQLParser::buildLikeRule(OSQLParseNode* pAppend, OSQLParseNode*& pLiteral, const OSQLParseNode* pEscape)
{ {
sal_Int16 nErg = 0; sal_Int16 nErg = 0;
sal_Int32 nType = 0; sal_Int32 nType = 0;

6
include/connectivity/sqlparse.hxx
View File

@ -172,7 +172,7 @@ namespace connectivity
OSQLParseNode* buildDate(sal_Int32 _nType,OSQLParseNode*& pLiteral); OSQLParseNode* buildDate(sal_Int32 _nType,OSQLParseNode*& pLiteral);
bool extractDate(OSQLParseNode* pLiteral,double& _rfValue); bool extractDate(OSQLParseNode* pLiteral,double& _rfValue);
void killThousandSeparator(OSQLParseNode* pLiteral); void killThousandSeparator(OSQLParseNode* pLiteral);
OSQLParseNode* convertNode(sal_Int32 nType,OSQLParseNode*const& pLiteral); OSQLParseNode* convertNode(sal_Int32 nType, OSQLParseNode* pLiteral);
// makes a string out of a number, pLiteral will be deleted // makes a string out of a number, pLiteral will be deleted
OSQLParseNode* buildNode_STR_NUM(OSQLParseNode*& pLiteral); OSQLParseNode* buildNode_STR_NUM(OSQLParseNode*& pLiteral);
OSQLParseNode* buildNode_Date(const double& fValue, sal_Int32 nType); OSQLParseNode* buildNode_Date(const double& fValue, sal_Int32 nType);
@ -240,9 +240,9 @@ namespace connectivity
sal_Int16 buildComparsionRule(OSQLParseNode*& pAppend,OSQLParseNode* pLiteral); sal_Int16 buildComparsionRule(OSQLParseNode*& pAppend,OSQLParseNode* pLiteral);
// pCompre will be deleted if it is not used // pCompre will be deleted if it is not used
sal_Int16 buildPredicateRule(OSQLParseNode*& pAppend,OSQLParseNode* const pLiteral,OSQLParseNode*const & pCompare,OSQLParseNode* pLiteral2 = NULL); sal_Int16 buildPredicateRule(OSQLParseNode*& pAppend,OSQLParseNode* const pLiteral,OSQLParseNode* pCompare,OSQLParseNode* pLiteral2 = NULL);
sal_Int16 buildLikeRule(OSQLParseNode* const& pAppend,OSQLParseNode*& pLiteral,const OSQLParseNode* pEscape); sal_Int16 buildLikeRule(OSQLParseNode* pAppend, OSQLParseNode*& pLiteral, const OSQLParseNode* pEscape);
sal_Int16 buildStringNodes(OSQLParseNode*& pLiteral); sal_Int16 buildStringNodes(OSQLParseNode*& pLiteral);
#else #else
#endif #endif

2
slideshow/source/inc/tools.hxx
View File

@ -70,7 +70,7 @@ namespace slideshow
typedef ::boost::shared_ptr< GDIMetaFile > GDIMetaFileSharedPtr; typedef ::boost::shared_ptr< GDIMetaFile > GDIMetaFileSharedPtr;
template <typename T> template <typename T>
inline ::std::size_t hash_value( T * const& p ) inline ::std::size_t hash_value( T const * p )
{ {
::std::size_t d = static_cast< ::std::size_t >( ::std::size_t d = static_cast< ::std::size_t >(
reinterpret_cast< ::std::ptrdiff_t >(p) ); reinterpret_cast< ::std::ptrdiff_t >(p) );

2
sw/inc/ndarr.hxx
View File

@ -80,7 +80,7 @@ struct CompareSwOutlineNodes
class SwOutlineNodes : public o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes> class SwOutlineNodes : public o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes>
{ {
public: public:
bool Seek_Entry(SwNode* const &rP, sal_uInt16* pnPos) const; bool Seek_Entry(SwNode* rP, sal_uInt16* pnPos) const;
}; };
class SW_DLLPUBLIC SwNodes class SW_DLLPUBLIC SwNodes

2
sw/source/core/docnode/ndnum.cxx
View File

@ -29,7 +29,7 @@ bool CompareSwOutlineNodes::operator()( SwNode* const& lhs, SwNode* const& rhs)
return lhs->GetIndex() < rhs->GetIndex(); return lhs->GetIndex() < rhs->GetIndex();
} }
bool SwOutlineNodes::Seek_Entry(SwNode* const &rP, sal_uInt16* pnPos) const bool SwOutlineNodes::Seek_Entry(SwNode* rP, sal_uInt16* pnPos) const
{ {
const_iterator it = lower_bound(rP); const_iterator it = lower_bound(rP);
*pnPos = it - begin(); *pnPos = it - begin();