loplugin:unusedfields

Change-Id: I726b8b9dee3a424f731078cd6b10027423454bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143086
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/sfx2/templatedlg.hxx

@@ -128,7 +128,6 @@ protected:
     std::unique_ptr<weld::CheckButton> mxCBXHideDlg;
     std::unique_ptr<weld::MenuButton> mxActionBar;
     std::unique_ptr<TemplateDlgLocalView> mxLocalView;
-    std::unique_ptr<weld::Menu> mxTemplateDefaultMenu;
     std::unique_ptr<weld::CustomWeld> mxLocalViewWeld;
     std::unique_ptr<weld::Toggleable> mxListViewButton;
     std::unique_ptr<weld::Toggleable> mxThumbnailViewButton;
@@ -145,9 +144,7 @@ private:
     bool mbIsNewCategory;
 
     std::unique_ptr<weld::TreeView> mxLBCategory;
-    std::unique_ptr<weld::Label> mxSelectLabel;
     std::unique_ptr<weld::Entry> mxNewCategoryEdit;
-    std::unique_ptr<weld::Label> mxCreateLabel;
     std::unique_ptr<weld::Button> mxOKButton;
 
 public:

include/svtools/PlaceEditDialog.hxx

@@ -42,7 +42,6 @@ public:
     std::unique_ptr<weld::Entry> m_xEDUsername;
     std::unique_ptr<weld::Label> m_xFTUsernameLabel;
     std::unique_ptr<weld::Button> m_xBTOk;
-    std::unique_ptr<weld::Button> m_xBTCancel;
     std::unique_ptr<weld::Button> m_xBTDelete;
     std::unique_ptr<weld::Button> m_xBTRepoRefresh;
     std::unique_ptr<weld::CheckButton> m_xCBPassword;

include/svx/rubydialog.hxx

@@ -64,8 +64,6 @@ class SvxRubyDialog final : public SfxModelessDialogController
     rtl::Reference<SvxRubyData_Impl> m_pImpl;
     weld::Entry* aEditArr[8];
 
-    std::unique_ptr<weld::Label> m_xLeftFT;
-    std::unique_ptr<weld::Label> m_xRightFT;
     std::unique_ptr<weld::Entry> m_xLeft1ED;
     std::unique_ptr<weld::Entry> m_xRight1ED;
     std::unique_ptr<weld::Entry> m_xLeft2ED;

package/source/xstor/switchpersistencestream.cxx

@@ -63,17 +63,13 @@ struct SPStreamData_Impl
 };
 
 SwitchablePersistenceStream::SwitchablePersistenceStream(
-        uno::Reference< uno::XComponentContext > xContext,
         const uno::Reference< io::XStream >& xStream )
-: m_xContext(std::move( xContext ))
 {
     SwitchPersistenceTo( xStream );
 }
 
 SwitchablePersistenceStream::SwitchablePersistenceStream(
-        uno::Reference< uno::XComponentContext > xContext,
         const uno::Reference< io::XInputStream >& xInputStream )
-: m_xContext(std::move( xContext ))
 {
     SwitchPersistenceTo( xInputStream );
 }

package/source/xstor/switchpersistencestream.hxx

@@ -49,8 +49,6 @@ class SwitchablePersistenceStream
 {
     std::mutex    m_aMutex;
 
-    const css::uno::Reference< css::uno::XComponentContext > m_xContext;
-
     std::unique_ptr<SPStreamData_Impl> m_pStreamData;
 
     void CloseAll_Impl();
@@ -58,11 +56,9 @@ class SwitchablePersistenceStream
 public:
 
     SwitchablePersistenceStream(
-        css::uno::Reference< css::uno::XComponentContext > xContext,
         const css::uno::Reference< css::io::XStream >& xStream );
 
     SwitchablePersistenceStream(
-        css::uno::Reference< css::uno::XComponentContext > xContext,
         const css::uno::Reference< css::io::XInputStream >& xInStream );
 
     virtual ~SwitchablePersistenceStream() override;

package/source/xstor/xstorage.cxx

@@ -165,7 +165,7 @@ OStorage_Impl::OStorage_Impl(   uno::Reference< io::XInputStream > const & xInpu
     SAL_WARN_IF( !xInputStream.is(), "package.xstor", "No input stream is provided!" );
     assert(xContext.is());
 
-    m_pSwitchStream = new SwitchablePersistenceStream(xContext, xInputStream);
+    m_pSwitchStream = new SwitchablePersistenceStream(xInputStream);
     m_xInputStream = m_pSwitchStream->getInputStream();
 
     if ( m_nStorageMode & embed::ElementModes::WRITE )
@@ -207,12 +207,12 @@ OStorage_Impl::OStorage_Impl(   uno::Reference< io::XStream > const & xStream,
 
     if ( m_nStorageMode & embed::ElementModes::WRITE )
     {
-        m_pSwitchStream = new SwitchablePersistenceStream(xContext, xStream);
+        m_pSwitchStream = new SwitchablePersistenceStream(xStream);
         m_xStream = static_cast< io::XStream* >( m_pSwitchStream.get() );
     }
     else
     {
-        m_pSwitchStream = new SwitchablePersistenceStream(xContext, xStream->getInputStream());
+        m_pSwitchStream = new SwitchablePersistenceStream(xStream->getInputStream());
         m_xInputStream = m_pSwitchStream->getInputStream();
     }
 }

reportdesign/source/ui/dlg/AddField.cxx

@@ -67,7 +67,6 @@ OAddFieldWindow::OAddFieldWindow(weld::Window* pParent, uno::Reference< beans::X
     , m_xRowSet(std::move(xRowSet))
     , m_xActions(m_xBuilder->weld_toolbar("toolbox"))
     , m_xListBox(m_xBuilder->weld_tree_view("treeview"))
-    , m_xHelpText(m_xBuilder->weld_label("helptext"))
     , m_nCommandType(0)
     , m_bEscapeProcessing(false)
 {

reportdesign/source/ui/dlg/PageNumber.cxx

@@ -38,10 +38,8 @@ OPageNumberDialog::OPageNumberDialog(weld::Window* pParent,
     : GenericDialogController(pParent, "modules/dbreport/ui/pagenumberdialog.ui", "PageNumberDialog")
     , m_pController(_pController)
     , m_xHoldAlive(std::move(_xHoldAlive))
-    , m_xPageN(m_xBuilder->weld_radio_button("pagen"))
     , m_xPageNofM(m_xBuilder->weld_radio_button("pagenofm"))
     , m_xTopPage(m_xBuilder->weld_radio_button("toppage"))
-    , m_xBottomPage(m_xBuilder->weld_radio_button("bottompage"))
     , m_xAlignmentLst(m_xBuilder->weld_combo_box("alignment"))
     , m_xShowNumberOnFirstPage(m_xBuilder->weld_check_button("shownumberonfirstpage"))
 {

reportdesign/source/ui/inc/AddField.hxx

@@ -52,7 +52,6 @@ class  OAddFieldWindow : public weld::GenericDialogController
 
     std::unique_ptr<weld::Toolbar>                                              m_xActions;
     std::unique_ptr<weld::TreeView>                                             m_xListBox;
-    std::unique_ptr<weld::Label>                                                m_xHelpText;
 
     Link<OAddFieldWindow&,void>                                                 m_aCreateLink;
     OUString                                                                    m_aCommandName;

reportdesign/source/ui/inc/PageNumber.hxx

@@ -35,10 +35,8 @@ class OPageNumberDialog : public weld::GenericDialogController
     ::rptui::OReportController*                    m_pController;
     css::uno::Reference< css::report::XReportDefinition>
                                                    m_xHoldAlive;
-    std::unique_ptr<weld::RadioButton> m_xPageN;
     std::unique_ptr<weld::RadioButton> m_xPageNofM;
     std::unique_ptr<weld::RadioButton> m_xTopPage;
-    std::unique_ptr<weld::RadioButton> m_xBottomPage;
     std::unique_ptr<weld::ComboBox> m_xAlignmentLst;
     std::unique_ptr<weld::CheckButton> m_xShowNumberOnFirstPage;
 

sfx2/source/doc/templatedlg.cxx

@@ -1265,9 +1265,7 @@ SfxTemplateCategoryDialog::SfxTemplateCategoryDialog(weld::Window* pParent)
     : GenericDialogController(pParent, "sfx/ui/templatecategorydlg.ui", "TemplatesCategoryDialog")
     , mbIsNewCategory(false)
     , mxLBCategory(m_xBuilder->weld_tree_view("categorylb"))
-    , mxSelectLabel(m_xBuilder->weld_label("select_label"))
     , mxNewCategoryEdit(m_xBuilder->weld_entry("category_entry"))
-    , mxCreateLabel(m_xBuilder->weld_label("create_label"))
     , mxOKButton(m_xBuilder->weld_button("ok"))
 {
     mxLBCategory->append_text(SfxResId(STR_CATEGORY_NONE));

svtools/source/dialogs/PlaceEditDialog.cxx

@@ -32,7 +32,6 @@ PlaceEditDialog::PlaceEditDialog(weld::Window* pParent)
     , m_xEDUsername(m_xBuilder->weld_entry("login"))
     , m_xFTUsernameLabel(m_xBuilder->weld_label("loginLabel"))
     , m_xBTOk(m_xBuilder->weld_button("ok"))
-    , m_xBTCancel(m_xBuilder->weld_button("cancel"))
     , m_xBTDelete(m_xBuilder->weld_button("delete"))
     , m_xBTRepoRefresh(m_xBuilder->weld_button("repositoriesRefresh"))
     , m_xCBPassword(m_xBuilder->weld_check_button("rememberPassword"))
@@ -84,7 +83,6 @@ PlaceEditDialog::PlaceEditDialog(weld::Window* pParent, const std::shared_ptr<Pl
     , m_xEDUsername(m_xBuilder->weld_entry("login"))
     , m_xFTUsernameLabel(m_xBuilder->weld_label("loginLabel"))
     , m_xBTOk(m_xBuilder->weld_button("ok"))
-    , m_xBTCancel(m_xBuilder->weld_button("cancel"))
     , m_xBTDelete(m_xBuilder->weld_button("delete"))
     , m_xBTRepoRefresh(m_xBuilder->weld_button("repositoriesRefresh"))
     , m_xCBPassword(m_xBuilder->weld_check_button("rememberPassword"))

svx/source/dialog/rubydialog.cxx

@@ -188,8 +188,6 @@ SvxRubyDialog::SvxRubyDialog(SfxBindings* pBind, SfxChildWindow* pCW, weld::Wind
     , bModified(false)
     , pBindings(pBind)
     , m_pImpl(new SvxRubyData_Impl)
-    , m_xLeftFT(m_xBuilder->weld_label("basetextft"))
-    , m_xRightFT(m_xBuilder->weld_label("rubytextft"))
     , m_xLeft1ED(m_xBuilder->weld_entry("Left1ED"))
     , m_xRight1ED(m_xBuilder->weld_entry("Right1ED"))
     , m_xLeft2ED(m_xBuilder->weld_entry("Left2ED"))