From a8d01742e98d29a57be6d990b7331f789bc3a5ee Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 26 Apr 2022 14:39:28 +0200 Subject: [PATCH] Improve some signed vs. unsigned comparisons p2-fwd will always be non-negative Change-Id: I143d7fd3c5ec192ffaeb56bc2e9f45ac5e83cb6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133439 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- ucb/source/ucp/ftp/ftpurl.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ucb/source/ucp/ftp/ftpurl.cxx b/ucb/source/ucp/ftp/ftpurl.cxx index 7910a293d570..13b7e839c3e9 100644 --- a/ucb/source/ucp/ftp/ftpurl.cxx +++ b/ucb/source/ucp/ftp/ftpurl.cxx @@ -30,6 +30,7 @@ #include #include #include +#include #include "ftpurl.hxx" #include "ftpcontentprovider.hxx" @@ -458,8 +459,8 @@ std::vector FTPURL::list( OUString viewurl(ident(true,false)); while(true) { - while(p2-fwd < int(len) && *p2 != '\n') ++p2; - if(p2-fwd == int(len)) break; + while(o3tl::make_unsigned(p2-fwd) < len && *p2 != '\n') ++p2; + if(o3tl::make_unsigned(p2-fwd) == len) break; *p2 = 0; switch(osKind) {