mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cppcheck: noExplicitConstructor

Browse Source 
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
This commit is contained in:
Caolán McNamara 2015-06-08 16:17:45 +01:00
parent 883ebe0283
commit a941df0f89
39 changed files with 46 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codemaker/source/javamaker/classfile.hxx
View File

@ -133,7 +133,7 @@ public:
Code(Code &) SAL_DELETED_FUNCTION;
void operator =(const Code&) SAL_DELETED_FUNCTION;
Code(ClassFile & classFile);
explicit Code(ClassFile & classFile);
void ldc(sal_uInt16 index);

2
comphelper/source/compare/AnyCompareFactory.cxx
View File

@ -61,7 +61,7 @@ class AnyCompareFactory : public cppu::WeakImplHelper3< XAnyCompareFactory, XIni
Locale m_Locale;
public:
AnyCompareFactory( Reference< XComponentContext > xContext ) : m_xContext( xContext )
explicit AnyCompareFactory( Reference< XComponentContext > xContext ) : m_xContext( xContext )
{}
// XAnyCompareFactory

2
comphelper/source/container/namecontainer.cxx
View File

@ -40,7 +40,7 @@ namespace comphelper
class NameContainer : public ::cppu::WeakImplHelper1< ::com::sun::star::container::XNameContainer >, private NameContainerImpl
{
public:
NameContainer( ::com::sun::star::uno::Type aType );
explicit NameContainer( ::com::sun::star::uno::Type aType );
virtual ~NameContainer();
// XNameContainer

2
comphelper/source/misc/accessiblewrapper.cxx
View File

@ -40,7 +40,7 @@ namespace comphelper
Reference< XEventListener > m_xListener;
public:
RemoveEventListener( const Reference< XEventListener >& _rxListener )
explicit RemoveEventListener( const Reference< XEventListener >& _rxListener )
:m_xListener( _rxListener )
{
}

2
comphelper/source/misc/asyncnotification.cxx
View File

@ -61,7 +61,7 @@ namespace comphelper
struct EqualProcessor : public ::std::unary_function< ProcessableEvent, bool >
{
const ::rtl::Reference< IEventProcessor >& rProcessor;
EqualProcessor( const ::rtl::Reference< IEventProcessor >& _rProcessor ) :rProcessor( _rProcessor ) { }
explicit EqualProcessor( const ::rtl::Reference< IEventProcessor >& _rProcessor ) :rProcessor( _rProcessor ) { }
bool operator()( const ProcessableEvent& _rEvent )
{

2
comphelper/source/misc/instancelocker.hxx
View File

@ -55,7 +55,7 @@ class OInstanceLocker : public ::cppu::WeakImplHelper3< ::com::sun::star::lang::
bool m_bInitialized;
public:
OInstanceLocker( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext );
explicit OInstanceLocker( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext );
virtual ~OInstanceLocker();
static ::com::sun::star::uno::Sequence< OUString > SAL_CALL

2
comphelper/source/misc/officerestartmanager.hxx
View File

@ -42,7 +42,7 @@ class OOfficeRestartManager : public ::cppu::WeakImplHelper3< ::com::sun::star::
bool m_bRestartRequested;
public:
OOfficeRestartManager( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext )
explicit OOfficeRestartManager( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext )
: m_xContext( xContext )
, m_bOfficeInitialized( false )
, m_bRestartRequested( false )

2
comphelper/source/misc/syntaxhighlight.cxx
View File

@ -273,7 +273,7 @@ class SyntaxHighlighter::Tokenizer
public:
HighlighterLanguage const aLanguage;
Tokenizer( HighlighterLanguage aLang );
explicit Tokenizer( HighlighterLanguage aLang );
~Tokenizer();
void getHighlightPortions(const OUString& rLine,

2
comphelper/source/misc/threadpool.cxx
View File

@ -23,7 +23,7 @@ class ThreadPool::ThreadWorker : public salhelper::Thread
bool mbWorking;
public:
ThreadWorker( ThreadPool *pPool ) :
explicit ThreadWorker( ThreadPool *pPool ) :
salhelper::Thread("thread-pool"),
mpPool( pPool ),
mbWorking( false )

2
comphelper/source/officeinstdir/officeinstallationdirectories.hxx
View File

@ -43,7 +43,7 @@ struct mutex_holder
class OfficeInstallationDirectories : public mutex_holder, public UnoImplBase
{
public:
OfficeInstallationDirectories(
explicit OfficeInstallationDirectories(
const com::sun::star::uno::Reference<
com::sun::star::uno::XComponentContext > & xCtx );
virtual ~OfficeInstallationDirectories();

2
comphelper/source/property/MasterPropertySet.cxx
View File

@ -33,7 +33,7 @@ class AutoOGuardArray
std::unique_ptr< osl::Guard< comphelper::SolarMutex > > * mpGuardArray;
public:
AutoOGuardArray( sal_Int32 nNumElements );
explicit AutoOGuardArray( sal_Int32 nNumElements );
~AutoOGuardArray();
std::unique_ptr< osl::Guard< comphelper::SolarMutex > > & operator[] ( sal_Int32 i ) { return mpGuardArray[i]; }

2
comphelper/source/property/genericpropertyset.cxx
View File

@ -64,7 +64,7 @@ namespace comphelper
virtual void _getPropertyValues( const PropertyMapEntry** ppEntries, Any* pValue ) throw( UnknownPropertyException, WrappedTargetException ) SAL_OVERRIDE;
public:
GenericPropertySet( PropertySetInfo* pInfo ) throw();
explicit GenericPropertySet( PropertySetInfo* pInfo ) throw();
virtual ~GenericPropertySet() throw();
// XInterface

2
comphelper/source/property/propagg.cxx
View File

@ -356,7 +356,7 @@ namespace internal
sal_Int32 m_nCurrentlyForwarding;
public:
PropertyForwarder( OPropertySetAggregationHelper& _rAggregationHelper );
explicit PropertyForwarder( OPropertySetAggregationHelper& _rAggregationHelper );
~PropertyForwarder();
/** declares that the forwarder should be responsible for the given property

2
comphelper/source/property/propertycontainerhelper.cxx
View File

@ -52,7 +52,7 @@ namespace
struct PropertyDescriptionNameMatch : public ::std::unary_function< PropertyDescription, bool >
{
OUString m_rCompare;
PropertyDescriptionNameMatch( const OUString& _rCompare ) : m_rCompare( _rCompare ) { }
explicit PropertyDescriptionNameMatch( const OUString& _rCompare ) : m_rCompare( _rCompare ) { }
bool operator() (const PropertyDescription& x ) const
{

2
configmgr/source/access.hxx
View File

@ -426,7 +426,7 @@ public:
com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
protected:
Access(Components & components);
explicit Access(Components & components);
virtual ~Access();

2
configmgr/source/components.hxx
View File

@ -112,7 +112,7 @@ private:
OUString const &, int, Data &, Partial const *, Modifications *,
Additions *);
public:
Components(
explicit Components(
com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >
const & context);

2
configmgr/source/configurationprovider.cxx
View File

@ -91,7 +91,7 @@ class Service:
private cppu::BaseMutex, public ServiceBase
{
public:
Service(
explicit Service(
css::uno::Reference< css::uno::XComponentContext > const context):
ServiceBase(m_aMutex), context_(context), default_(true)
{

2
configmgr/source/configurationregistry.cxx
View File

@ -73,7 +73,7 @@ class Service:
css::util::XFlushable >
{
public:
Service(css::uno::Reference< css::uno::XComponentContext > const & context);
explicit Service(css::uno::Reference< css::uno::XComponentContext > const & context);
private:
Service(const Service&) SAL_DELETED_FUNCTION;

2
configmgr/source/localizedvaluenode.hxx
View File

@ -32,7 +32,7 @@ namespace configmgr {
class LocalizedValueNode: public Node {
public:
LocalizedValueNode(int layer);
explicit LocalizedValueNode(int layer);
LocalizedValueNode(int layer, com::sun::star::uno::Any const & value);
virtual rtl::Reference< Node > clone(bool keepTemplateName) const SAL_OVERRIDE;

2
configmgr/source/update.cxx
View File

@ -60,7 +60,7 @@ class Service:
public cppu::WeakImplHelper1< css::configuration::XUpdate >
{
public:
Service(css::uno::Reference< css::uno::XComponentContext > const context):
explicit Service(css::uno::Reference< css::uno::XComponentContext > const context):
context_(context)
{
assert(context.is());

2
configmgr/source/valueparser.hxx
View File

@ -44,7 +44,7 @@ class Node;
class ValueParser {
public:
ValueParser(int layer);
explicit ValueParser(int layer);
~ValueParser();

2
connectivity/source/commontools/FValue.cxx
View File

@ -2200,7 +2200,7 @@ namespace detail
class ColumnValue : public IValueSource
{
public:
ColumnValue( const Reference< XColumn >& _rxColumn )
explicit ColumnValue( const Reference< XColumn >& _rxColumn )
:m_xColumn( _rxColumn )
{
}

10
connectivity/source/commontools/RowFunctionParser.cxx
View File

@ -58,7 +58,7 @@ class ConstantValueExpression : public ExpressionNode
public:
ConstantValueExpression( ORowSetValueDecoratorRef rValue ) :
explicit ConstantValueExpression( ORowSetValueDecoratorRef rValue ) :
maValue( rValue )
{
}
@ -171,7 +171,7 @@ class ConstantFunctor
public:
ConstantFunctor( const ParserContextSharedPtr& rContext ) :
explicit ConstantFunctor( const ParserContextSharedPtr& rContext ) :
mpContext( rContext )
{
}
@ -189,7 +189,7 @@ class IntConstantFunctor
ParserContextSharedPtr mpContext;
public:
IntConstantFunctor( const ParserContextSharedPtr& rContext ) :
explicit IntConstantFunctor( const ParserContextSharedPtr& rContext ) :
mpContext( rContext )
{
}
@ -326,7 +326,7 @@ public:
@param rParserContext
Contains context info for the parser
*/
ExpressionGrammar( const ParserContextSharedPtr& rParserContext ) :
explicit ExpressionGrammar( const ParserContextSharedPtr& rParserContext ) :
mpParserContext( rParserContext )
{
}
@ -335,7 +335,7 @@ public:
{
public:
// grammar definition
definition( const ExpressionGrammar& self )
explicit definition( const ExpressionGrammar& self )
{
using ::boost::spirit::str_p;
using ::boost::spirit::space_p;

2
connectivity/source/commontools/TColumnsHelper.cxx
View File

@ -50,7 +50,7 @@ namespace connectivity
class OColumnsHelperImpl
{
public:
OColumnsHelperImpl(bool _bCase)
explicit OColumnsHelperImpl(bool _bCase)
: m_aColumnInfo(_bCase)
{
}

2
connectivity/source/commontools/TSortIndex.cxx
View File

@ -30,7 +30,7 @@ struct TKeyValueFunc : ::std::binary_function<OSortIndex::TIntValuePairVector::v
{
OSortIndex* pIndex;
TKeyValueFunc(OSortIndex* _pIndex) : pIndex(_pIndex)
explicit TKeyValueFunc(OSortIndex* _pIndex) : pIndex(_pIndex)
{
}
// return false if compared values are equal otherwise true

4
connectivity/source/commontools/TTableHelper.cxx
View File

@ -62,7 +62,7 @@ class OTableContainerListener:
protected:
virtual ~OTableContainerListener(){}
public:
OTableContainerListener(OTableHelper* _pComponent) : m_pComponent(_pComponent){}
explicit OTableContainerListener(OTableHelper* _pComponent) : m_pComponent(_pComponent){}
virtual void SAL_CALL elementInserted( const ::com::sun::star::container::ContainerEvent& /*Event*/ ) throw (RuntimeException, std::exception) SAL_OVERRIDE
{
}
@ -114,7 +114,7 @@ namespace connectivity
Reference< ::com::sun::star::sdbc::XConnection > m_xConnection;
rtl::Reference<OTableContainerListener> m_xTablePropertyListener;
::std::vector< ColumnDesc > m_aColumnDesc;
OTableHelperImpl(const Reference< ::com::sun::star::sdbc::XConnection >& _xConnection)
explicit OTableHelperImpl(const Reference< ::com::sun::star::sdbc::XConnection >& _xConnection)
: m_xConnection(_xConnection)
{
try

2
connectivity/source/commontools/sqlerror.cxx
View File

@ -56,7 +56,7 @@ namespace connectivity
class SQLError_Impl
{
public:
SQLError_Impl( const Reference<XComponentContext> & _rxContext );
explicit SQLError_Impl( const Reference<XComponentContext> & _rxContext );
~SQLError_Impl();
// versions of the public SQLError methods which are just delegated to this impl-class

2
connectivity/source/commontools/statementcomposer.cxx
View File

@ -64,7 +64,7 @@ namespace dbtools
bool bComposerDirty;
bool bDisposeComposer;
StatementComposer_Data( const Reference< XConnection >& _rxConnection )
explicit StatementComposer_Data( const Reference< XConnection >& _rxConnection )
:xConnection( _rxConnection )
,sCommand()
,sFilter()

2
connectivity/source/cpool/ZConnectionPool.cxx
View File

@ -117,7 +117,7 @@ struct TConnectionPoolFunctor : ::std::unary_function<TConnectionMap::value_type
{
OConnectionPool* m_pConnectionPool;
TConnectionPoolFunctor(OConnectionPool* _pConnectionPool)
explicit TConnectionPoolFunctor(OConnectionPool* _pConnectionPool)
: m_pConnectionPool(_pConnectionPool)
{
OSL_ENSURE(m_pConnectionPool,"No connection pool!");

2
connectivity/source/cpool/ZConnectionWrapper.hxx
View File

@ -45,7 +45,7 @@ namespace connectivity
virtual void SAL_CALL disposing() SAL_OVERRIDE;
virtual ~OConnectionWeakWrapper();
public:
OConnectionWeakWrapper(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _xConnection);
explicit OConnectionWeakWrapper(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _xConnection);
// XServiceInfo
DECLARE_SERVICE_INFO();

2
connectivity/source/cpool/ZPoolCollection.hxx
View File

@ -80,7 +80,7 @@ namespace connectivity
OPoolCollection(const OPoolCollection&) SAL_DELETED_FUNCTION;
int operator= (const OPoolCollection&) SAL_DELETED_FUNCTION;
OPoolCollection(
explicit OPoolCollection(
const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext);
// some configuration helper methods

2
connectivity/source/drivers/evoab2/NCatalog.hxx
View File

@ -32,7 +32,7 @@ namespace connectivity
OEvoabConnection *m_pConnection;
::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData > m_xMetaData;
public:
OEvoabCatalog(OEvoabConnection *_pCon);
explicit OEvoabCatalog(OEvoabConnection *_pCon);
inline OEvoabConnection* getConnection() const { return m_pConnection; }
virtual void refreshTables() SAL_OVERRIDE;
virtual void refreshViews() SAL_OVERRIDE {}

2
connectivity/source/drivers/evoab2/NConnection.hxx
View File

@ -64,7 +64,7 @@ namespace connectivity
virtual ~OEvoabConnection();
public:
OEvoabConnection( OEvoabDriver& _rDriver );
explicit OEvoabConnection( OEvoabDriver& _rDriver );
virtual void construct(const OUString& _rUrl,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo ) throw( ::com::sun::star::sdbc::SQLException);
inline OString getPassword() { return m_aPassword; }

2
connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
View File

@ -87,7 +87,7 @@ namespace connectivity
public:
inline OEvoabConnection* getOwnConnection() const { return m_pConnection; }
OEvoabDatabaseMetaData(OEvoabConnection* _pCon);
explicit OEvoabDatabaseMetaData(OEvoabConnection* _pCon);
// as I mentioned before this interface is really BIG
// XDatabaseMetaData

2
connectivity/source/drivers/evoab2/NDriver.hxx
View File

@ -50,7 +50,7 @@ namespace connectivity
::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > m_xFactory;
public:
OEvoabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory);
explicit OEvoabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory);
virtual ~OEvoabDriver();
// OComponentHelper

2
connectivity/source/drivers/evoab2/NPreparedStatement.hxx
View File

@ -73,7 +73,7 @@ namespace connectivity
virtual ~OEvoabPreparedStatement();
public:
OEvoabPreparedStatement( OEvoabConnection* _pConnection );
explicit OEvoabPreparedStatement( OEvoabConnection* _pConnection );
void construct( const OUString& _sql );

2
connectivity/source/drivers/evoab2/NResultSetMetaData.hxx
View File

@ -42,7 +42,7 @@ namespace connectivity
protected:
virtual ~OEvoabResultSetMetaData();
public:
OEvoabResultSetMetaData(const OUString& _aTableName);
explicit OEvoabResultSetMetaData(const OUString& _aTableName);
void setEvoabFields(const ::rtl::Reference<connectivity::OSQLColumns> &xColumns) throw(::com::sun::star::sdbc::SQLException);
inline sal_uInt32 fieldAtColumn(sal_Int32 columnIndex) const
{ return m_aEvoabFields[columnIndex - 1]; }

4
connectivity/source/drivers/evoab2/NStatement.hxx
View File

@ -189,7 +189,7 @@ namespace connectivity
using OCommonStatement_IBase::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >;
protected:
OCommonStatement( OEvoabConnection* _pConnection );
explicit OCommonStatement( OEvoabConnection* _pConnection );
// OComponentHelper
virtual void SAL_CALL disposing() SAL_OVERRIDE;
@ -242,7 +242,7 @@ namespace connectivity
virtual ~OStatement(){}
public:
OStatement( OEvoabConnection* _pConnection)
explicit OStatement( OEvoabConnection* _pConnection)
:OCommonStatement( _pConnection)
{
}

4
connectivity/source/drivers/firebird/Catalog.hxx
View File

@ -23,7 +23,7 @@ namespace connectivity
m_xConnection;
public:
Catalog(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection);
explicit Catalog(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection);
// OCatalog
virtual void refreshTables() SAL_OVERRIDE;
@ -40,4 +40,4 @@ namespace connectivity
#endif // INCLUDED_CONNECTIVITY_SOURCE_DRIVERS_FIREBIRD_CATALOG_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */