mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:externvar (clang-cl)

Browse Source 
Change-Id: I81877e46cf95dcc7de16b797fca33658036bf9e8
This commit is contained in:
Stephan Bergmann 2017-01-11 13:41:01 +01:00
parent 698bdcdb0c
commit a9d06182f8
9 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/externvar.cxx
View File

@ -73,6 +73,9 @@ public:
// not needed and will not be emitted" // not needed and will not be emitted"
return true; return true;
} }
if (loplugin::DeclCheck(def).Var("_pRawDllMain").GlobalNamespace()) {
return true;
}
SourceLocation argLoc; SourceLocation argLoc;
if (compat::isMacroArgExpansion(compiler, def->getLocation(), &argLoc) if (compat::isMacroArgExpansion(compiler, def->getLocation(), &argLoc)
&& (Lexer::getImmediateMacroName( && (Lexer::getImmediateMacroName(

3
sal/osl/w32/dllentry.c
View File

@ -34,16 +34,15 @@
#include <osl/mutex.h> #include <osl/mutex.h>
#include <osl/thread.h> #include <osl/thread.h>
#include "file_url.h"
#include "rtllifecycle.h" #include "rtllifecycle.h"
#include <thread.h> #include <thread.h>
// externals // externals
extern DWORD g_dwTLSTextEncodingIndex;
extern CRITICAL_SECTION g_ThreadKeyListCS; extern CRITICAL_SECTION g_ThreadKeyListCS;
extern oslMutex g_Mutex; extern oslMutex g_Mutex;
extern oslMutex g_CurrentDirectoryMutex;
#ifdef __MINGW32__ #ifdef __MINGW32__

3
sal/osl/w32/file_url.cxx
View File

@ -42,8 +42,7 @@
// FileURL functions // FileURL functions
extern "C" oslMutex g_CurrentDirectoryMutex; /* Initialized in dllentry.c */ oslMutex g_CurrentDirectoryMutex = nullptr; /* Initialized in dllentry.c */
oslMutex g_CurrentDirectoryMutex = nullptr;
static BOOL IsValidFilePathComponent( static BOOL IsValidFilePathComponent(
LPCWSTR lpComponent, LPCWSTR *lppComponentEnd, DWORD dwFlags) LPCWSTR lpComponent, LPCWSTR *lppComponentEnd, DWORD dwFlags)

3
sal/osl/w32/file_url.h
View File

@ -23,6 +23,7 @@
#include "sal/types.h" #include "sal/types.h"
#include "rtl/ustring.h" #include "rtl/ustring.h"
#include "osl/file.h" #include "osl/file.h"
#include "osl/mutex.h"
#ifdef _MSC_VER #ifdef _MSC_VER
#pragma warning(push,1) #pragma warning(push,1)
@ -81,6 +82,8 @@ oslFileError osl_getFileURLFromSystemPath_ (
rtl_uString ** pstrURL rtl_uString ** pstrURL
); );
extern oslMutex g_CurrentDirectoryMutex;
#ifdef __cplusplus #ifdef __cplusplus
} }
#endif #endif

8
sal/osl/w32/path_helper.cxx
View File

@ -83,14 +83,14 @@ void SAL_CALL osl_systemPathRemoveSeparator(/*inout*/ rtl_uString** ppustrPath)
******************************************************************/ ******************************************************************/
// is [A-Za-z]:[/|\]\0 // is [A-Za-z]:[/|\]\0
const sal_Char* LDP = ":"; const sal_Char* const LDP = ":";
const sal_Char* LDP_WITH_BACKSLASH = ":\\"; const sal_Char* const LDP_WITH_BACKSLASH = ":\\";
const sal_Char* LDP_WITH_SLASH = ":/"; const sal_Char* const LDP_WITH_SLASH = ":/";
// degenerated case returned by the Windows FileOpen dialog // degenerated case returned by the Windows FileOpen dialog
// when someone enters for instance "x:filename", the Win32 // when someone enters for instance "x:filename", the Win32
// API accepts this case // API accepts this case
const sal_Char* LDP_WITH_DOT_BACKSLASH = ":.\\"; const sal_Char* const LDP_WITH_DOT_BACKSLASH = ":.\\";
sal_Int32 osl_systemPathIsLogicalDrivePattern(/*in*/ const rtl_uString* pustrPath) sal_Int32 osl_systemPathIsLogicalDrivePattern(/*in*/ const rtl_uString* pustrPath)
{ {

2
sal/osl/w32/process.cxx
View File

@ -436,8 +436,6 @@ oslProcessError SAL_CALL osl_clearEnvironment(rtl_uString *ustrVar)
* Current Working Directory. * Current Working Directory.
***************************************************************************/ ***************************************************************************/
extern "C" oslMutex g_CurrentDirectoryMutex;
oslProcessError SAL_CALL osl_getProcessWorkingDir( rtl_uString **pustrWorkingDir ) oslProcessError SAL_CALL osl_getProcessWorkingDir( rtl_uString **pustrWorkingDir )
{ {
::osl::LongPathBuffer< sal_Unicode > aBuffer( MAX_LONG_PATH ); ::osl::LongPathBuffer< sal_Unicode > aBuffer( MAX_LONG_PATH );

4
sal/osl/w32/procimpl.cxx
View File

@ -46,7 +46,7 @@
#include <string.h> #include <string.h>
const sal_Unicode NAME_VALUE_SEPARATOR = TEXT('='); const sal_Unicode NAME_VALUE_SEPARATOR = TEXT('=');
const sal_Char* SPACE = " "; const sal_Char SPACE[] = " ";
const rtl::OUString ENV_COMSPEC ("COMSPEC"); const rtl::OUString ENV_COMSPEC ("COMSPEC");
const rtl::OUString QUOTE("\""); const rtl::OUString QUOTE("\"");
@ -453,7 +453,7 @@ oslProcessError SAL_CALL osl_executeProcess_WithRedirectedIO(
start at 1 instead of 0 */ start at 1 instead of 0 */
for (sal_uInt32 n = (nullptr != ustrImageName) ? 0 : 1; n < nArguments; n++) for (sal_uInt32 n = (nullptr != ustrImageName) ? 0 : 1; n < nArguments; n++)
{ {
command_line.appendAscii(SPACE); command_line.append(SPACE);
/* Quote arguments containing blanks */ /* Quote arguments containing blanks */
if (rtl::OUString(ustrArguments[n]).indexOf(' ') != -1) if (rtl::OUString(ustrArguments[n]).indexOf(' ') != -1)

2
sal/osl/w32/socket.cxx
View File

@ -273,7 +273,7 @@ struct LeakWarning
SAL_WARN_IF( g_nSocketAddr, "sal.osl", "sal_socket: " << g_nSocketAddr << " socket address instances leak" ); SAL_WARN_IF( g_nSocketAddr, "sal.osl", "sal_socket: " << g_nSocketAddr << " socket address instances leak" );
} }
}; };
LeakWarning socketWarning; static LeakWarning socketWarning;
#endif #endif
oslSocket osl_createSocketImpl_(SOCKET Socket) oslSocket osl_createSocketImpl_(SOCKET Socket)

2
sal/osl/w32/thread.h
View File

@ -20,6 +20,8 @@ extern "C" {
void SAL_CALL osl_callThreadKeyCallbackOnThreadDetach(void); void SAL_CALL osl_callThreadKeyCallbackOnThreadDetach(void);
extern DWORD g_dwTLSTextEncodingIndex;
#if defined __cplusplus #if defined __cplusplus
} }
#endif #endif