mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer reference over pointer (when it makes sense).

Browse Source
This commit is contained in:
Kohei Yoshida
2011-12-13 16:18:03 -05:00
parent ccc59bc76f
commit a9d1d2f35c
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
chart2/source/view/charttypes/AreaChart.cxx
View File

@@ -647,9 +647,9 @@ void AreaChart::createShapes()
//iterate through all x slots in this category to get 100percent sum //iterate through all x slots in this category to get 100percent sum
for( ; aXSlotIter != aXSlotEnd; ++aXSlotIter ) for( ; aXSlotIter != aXSlotEnd; ++aXSlotIter )
{ {
::std::vector< VDataSeries* >* pSeriesList = &(aXSlotIter->m_aSeriesVector); std::vector<VDataSeries*>& rSeriesList = aXSlotIter->m_aSeriesVector;
std::vector<VDataSeries*>::iterator aSeriesIter = pSeriesList->begin(); std::vector<VDataSeries*>::iterator aSeriesIter = rSeriesList.begin();
const std::vector<VDataSeries*>::iterator aSeriesEnd = pSeriesList->end(); const std::vector<VDataSeries*>::iterator aSeriesEnd = rSeriesList.end();
for( ; aSeriesIter != aSeriesEnd; ++aSeriesIter ) for( ; aSeriesIter != aSeriesEnd; ++aSeriesIter )
{ {
@@ -688,9 +688,9 @@ void AreaChart::createShapes()
aXSlotIter = aZSlotIter->begin(); aXSlotIter = aZSlotIter->begin();
for( sal_Int32 nX=0; aXSlotIter != aXSlotEnd; ++aXSlotIter, ++nX ) for( sal_Int32 nX=0; aXSlotIter != aXSlotEnd; ++aXSlotIter, ++nX )
{ {
::std::vector< VDataSeries* >* pSeriesList = &(aXSlotIter->m_aSeriesVector); std::vector<VDataSeries*>& rSeriesList = aXSlotIter->m_aSeriesVector;
::std::vector< VDataSeries* >::const_iterator aSeriesIter = pSeriesList->begin(); std::vector<VDataSeries*>::const_iterator aSeriesIter = rSeriesList.begin();
const ::std::vector< VDataSeries* >::const_iterator aSeriesEnd = pSeriesList->end(); const std::vector<VDataSeries*>::const_iterator aSeriesEnd = rSeriesList.end();
std::map< sal_Int32, double > aLogicYForNextSeriesMap;//one for each different nAttachedAxisIndex std::map< sal_Int32, double > aLogicYForNextSeriesMap;//one for each different nAttachedAxisIndex
//============================================================================= //=============================================================================
@@ -704,7 +704,7 @@ void AreaChart::createShapes()
/* #i70133# ignore points outside of series length in standard area /* #i70133# ignore points outside of series length in standard area
charts. Stacked area charts will use missing points as zeros. In charts. Stacked area charts will use missing points as zeros. In
standard charts, pSeriesList contains only one series. */ standard charts, pSeriesList contains only one series. */
if( m_bArea && (pSeriesList->size() == 1) && (nIndex >= (*aSeriesIter)->getTotalPointCount()) ) if( m_bArea && (rSeriesList.size() == 1) && (nIndex >= (*aSeriesIter)->getTotalPointCount()) )
continue; continue;
uno::Reference< drawing::XShapes > xSeriesGroupShape_Shapes = getSeriesGroupShapeFrontChild(*aSeriesIter, m_xSeriesTarget); uno::Reference< drawing::XShapes > xSeriesGroupShape_Shapes = getSeriesGroupShapeFrontChild(*aSeriesIter, m_xSeriesTarget);
@@ -730,7 +730,7 @@ void AreaChart::createShapes()
{ {
if( (*aSeriesIter)->getMissingValueTreatment() == ::com::sun::star::chart::MissingValueTreatment::LEAVE_GAP ) if( (*aSeriesIter)->getMissingValueTreatment() == ::com::sun::star::chart::MissingValueTreatment::LEAVE_GAP )
{ {
if( pSeriesList->size() == 1 || nSeriesIndex == 0 ) if( rSeriesList.size() == 1 || nSeriesIndex == 0 )
{ {
fLogicY = pPosHelper->getLogicMinY(); fLogicY = pPosHelper->getLogicMinY();
if( !pPosHelper->isMathematicalOrientationY() ) if( !pPosHelper->isMathematicalOrientationY() )
@@ -741,7 +741,7 @@ void AreaChart::createShapes()
} }
} }
if( m_nDimension==3 && m_bArea && pSeriesList->size()!=1 ) if( m_nDimension==3 && m_bArea && rSeriesList.size()!=1 )
fLogicY = fabs( fLogicY ); fLogicY = fabs( fLogicY );
if( pPosHelper->isPercentY() && !::rtl::math::approxEqual( aLogicYSumMap[nAttachedAxisIndex], 0.0 ) ) if( pPosHelper->isPercentY() && !::rtl::math::approxEqual( aLogicYSumMap[nAttachedAxisIndex], 0.0 ) )