From aad94d48b19135a2e46ac7b2c0f41f3bb29bb5a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Szymon=20K=C5=82os?= <szymon.klos@collabora.com>
Date: Thu, 20 Feb 2020 10:34:59 +0100
Subject: [PATCH] Silence warnings in salvtables.hxx
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I2d621688776c789b24ec1c593da2e4880cefd3a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89103
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
---
 vcl/inc/salvtables.hxx | 108 +++++++++++++++++++++--------------------
 1 file changed, 56 insertions(+), 52 deletions(-)

diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index a239f3f3f8b6..3d41d3589871 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -17,120 +17,123 @@ private:
 public:
     SalInstanceBuilder(vcl::Window* pParent, const OUString& rUIRoot, const OUString& rUIFile);
 
-    virtual std::unique_ptr<weld::MessageDialog> weld_message_dialog(const OString& id,
-                                                                     bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::MessageDialog>
+    weld_message_dialog(const OString& id, bool bTakeOwnership = true) override;
 
-    virtual std::unique_ptr<weld::AboutDialog> weld_about_dialog(const OString& id,
-                                                                 bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::AboutDialog>
+    weld_about_dialog(const OString& id, bool bTakeOwnership = true) override;
 
     virtual std::unique_ptr<weld::Dialog> weld_dialog(const OString& id,
-                                                      bool bTakeOwnership) override;
+                                                      bool bTakeOwnership = true) override;
 
     virtual std::unique_ptr<weld::Assistant> weld_assistant(const OString& id,
-                                                            bool bTakeOwnership) override;
+                                                            bool bTakeOwnership = true) override;
 
     virtual std::unique_ptr<weld::Window> create_screenshot_window() override;
 
     virtual std::unique_ptr<weld::Window> weld_window(const OString& id,
-                                                      bool bTakeOwnership) override;
+                                                      bool bTakeOwnership = true) override;
 
     virtual std::unique_ptr<weld::Widget> weld_widget(const OString& id,
-                                                      bool bTakeOwnership) override;
+                                                      bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Container> weld_container(const OString& id,
-                                                            bool bTakeOwnership) override;
+                                                            bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::Box> weld_box(const OString& id, bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::Box> weld_box(const OString& id,
+                                                bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Frame> weld_frame(const OString& id,
-                                                    bool bTakeOwnership) override;
+                                                    bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::ScrolledWindow>
-    weld_scrolled_window(const OString& id, bool bTakeOwnership) override;
+    weld_scrolled_window(const OString& id, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Notebook> weld_notebook(const OString& id,
-                                                          bool bTakeOwnership) override;
+                                                          bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Button> weld_button(const OString& id,
-                                                      bool bTakeOwnership) override;
+                                                      bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::MenuButton> weld_menu_button(const OString& id,
-                                                               bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::MenuButton>
+    weld_menu_button(const OString& id, bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::LinkButton> weld_link_button(const OString& id,
-                                                               bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::LinkButton>
+    weld_link_button(const OString& id, bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::ToggleButton> weld_toggle_button(const OString& id,
-                                                                   bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::ToggleButton>
+    weld_toggle_button(const OString& id, bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::RadioButton> weld_radio_button(const OString& id,
-                                                                 bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::RadioButton>
+    weld_radio_button(const OString& id, bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::CheckButton> weld_check_button(const OString& id,
-                                                                 bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::CheckButton>
+    weld_check_button(const OString& id, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Scale> weld_scale(const OString& id,
-                                                    bool bTakeOwnership) override;
+                                                    bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::ProgressBar> weld_progress_bar(const OString& id,
-                                                                 bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::ProgressBar>
+    weld_progress_bar(const OString& id, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Spinner> weld_spinner(const OString& id,
-                                                        bool bTakeOwnership) override;
+                                                        bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Image> weld_image(const OString& id,
-                                                    bool bTakeOwnership) override;
+                                                    bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Calendar> weld_calendar(const OString& id,
-                                                          bool bTakeOwnership) override;
+                                                          bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Entry> weld_entry(const OString& id,
-                                                    bool bTakeOwnership) override;
+                                                    bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::SpinButton> weld_spin_button(const OString& id,
-                                                               bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::SpinButton>
+    weld_spin_button(const OString& id, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::MetricSpinButton>
-    weld_metric_spin_button(const OString& id, FieldUnit eUnit, bool bTakeOwnership) override;
+    weld_metric_spin_button(const OString& id, FieldUnit eUnit,
+                            bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::FormattedSpinButton>
-    weld_formatted_spin_button(const OString& id, bool bTakeOwnership) override;
+    weld_formatted_spin_button(const OString& id, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::TimeSpinButton>
-    weld_time_spin_button(const OString& id, TimeFieldFormat eFormat, bool bTakeOwnership) override;
+    weld_time_spin_button(const OString& id, TimeFieldFormat eFormat,
+                          bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::ComboBox> weld_combo_box(const OString& id,
-                                                           bool bTakeOwnership) override;
+                                                           bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::EntryTreeView> weld_entry_tree_view(const OString& containerid,
-                                                                      const OString& entryid,
-                                                                      const OString& treeviewid,
-                                                                      bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::EntryTreeView>
+    weld_entry_tree_view(const OString& containerid, const OString& entryid,
+                         const OString& treeviewid, bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::TreeView> weld_tree_view(const OString& id,
-                                                           bool bTakeOwnership) override;
+                                                           bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::IconView> weld_icon_view(const OString& id,
-                                                           bool bTakeOwnership) override;
+                                                           bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Label> weld_label(const OString& id,
-                                                    bool bTakeOwnership) override;
+                                                    bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::TextView> weld_text_view(const OString& id,
-                                                           bool bTakeOwnership) override;
+                                                           bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::Expander> weld_expander(const OString& id,
-                                                          bool bTakeOwnership) override;
+                                                          bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::DrawingArea>
-    weld_drawing_area(const OString& id, const a11yref& rA11yImpl,
-                      FactoryFunction pUITestFactoryFunction, void* pUserData,
-                      bool bTakeOwnership) override;
+    weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr,
+                      FactoryFunction pUITestFactoryFunction = nullptr, void* pUserData = nullptr,
+                      bool bTakeOwnership = false) override;
 
-    virtual std::unique_ptr<weld::Menu> weld_menu(const OString& id, bool bTakeOwnership) override;
+    virtual std::unique_ptr<weld::Menu> weld_menu(const OString& id,
+                                                  bool bTakeOwnership = true) override;
 
     virtual std::unique_ptr<weld::Toolbar> weld_toolbar(const OString& id,
-                                                        bool bTakeOwnership) override;
+                                                        bool bTakeOwnership = false) override;
 
     virtual std::unique_ptr<weld::SizeGroup> create_size_group() override;
 
@@ -478,7 +481,8 @@ public:
 
     virtual void response(int nResponse) override;
 
-    virtual void add_button(const OUString& rText, int nResponse, const OString& rHelpId) override;
+    virtual void add_button(const OUString& rText, int nResponse,
+                            const OString& rHelpId = OString()) override;
 
     virtual void set_modal(bool bModal) override;