mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields various

Browse Source 
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
This commit is contained in:
Noel Grandin 2015-11-25 14:45:38 +02:00
parent 7c2edb3a67
commit abc6071b7a
33 changed files with 39 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
compilerplugins/clang/unusedfields.py
View File

@ -57,10 +57,24 @@ for d in definitionSet:
if d in callSet:
continue
srcLoc = definitionToSourceLocationMap[d];
if (srcLoc.startswith("include/")):
continue
# ignore external source code
if (srcLoc.startswith("external/")):
continue
# ignore build folder
if (srcLoc.startswith("workdir/")):
continue
# ignore our stable/URE/UNO api
if (srcLoc.startswith("include/com/")
or srcLoc.startswith("include/cppu/")
or srcLoc.startswith("include/cppuhelper/")
or srcLoc.startswith("include/osl/")
or srcLoc.startswith("include/rtl/")
or srcLoc.startswith("include/sal/")
or srcLoc.startswith("include/salhelper/")
or srcLoc.startswith("include/systools/")
or srcLoc.startswith("include/typelib/")
or srcLoc.startswith("include/uno/")):
continue
# this is all representations of on-disk data structures
if (srcLoc.startswith("sc/source/filter/inc/scflt.hxx")
or srcLoc.startswith("sw/source/filter/ww8/")
@ -69,7 +83,8 @@ for d in definitionSet:
or srcLoc.startswith("vcl/inc/unx/XIM.h")
or srcLoc.startswith("vcl/inc/unx/gtk/gloactiongroup.h")
or srcLoc.startswith("include/svl/svdde.hxx")
or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")):
or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")
or srcLoc.startswith("svtools/source/dialogs/insdlg.cxx")):
continue
tmp1set.add((clazz + " " + definitionToTypeMap[d], srcLoc))

3
svtools/source/contnr/imivctl.hxx
View File

@ -175,10 +175,7 @@ class SvxIconChoiceCtrl_Impl
Size aImageSize;
Size aDefaultTextSize;
Size aOutputSize; // Pixel
Point aDDLastEntryPos;
Point aDDLastRectPos;
Point aDDPaintOffs;
Point aDDStartPos;
VclPtr<SvtIconChoiceCtrl> pView;
IcnCursor_Impl* pImpCursor;
IcnGridMap_Impl* pGridMap;

1
svx/inc/galbrws2.hxx
View File

@ -115,7 +115,6 @@ private:
VclPtr<GalleryToolBox> maViewBox;
VclPtr<FixedLine> maSeparator;
VclPtr<FixedText> maInfoBar;
Point maDragStartPos;
sal_uIntPtr mnCurActionPos;
GalleryBrowserMode meMode;
GalleryBrowserMode meLastMode;

2
svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx
View File

@ -805,14 +805,12 @@ public:
class EnumFunctor
{
const ExpressionFunct meFunct;
double mnValue;
ParserContextSharedPtr mxContext;
public:
EnumFunctor( const ExpressionFunct eFunct, const ParserContextSharedPtr& rContext )
: meFunct( eFunct )
, mnValue( 0 )
, mxContext( rContext )
{
}

6
svx/source/dialog/imapwnd.hxx
View File

@ -43,12 +43,6 @@ struct NotifyInfo
};
struct NotifyPosSize
{
Size aPictureSize;
Point aMousePos;
};
#define SVD_IMAP_USERDATA 0x0001
const sal_uInt32 IMapInventor = sal_uInt32('I') * 0x00000001+

1
svx/source/inc/frmselimpl.hxx
View File

@ -106,7 +106,6 @@ struct FrameSelectorImpl : public Resource
Color maMarkCol; /// Selection marker color.
Color maHCLineCol; /// High contrast line color.
Point maVirDevPos; /// Position of virtual device in the control.
Point maMousePos; /// Last mouse pointer position.
FrameBorder maLeft; /// All data of left frame border.
FrameBorder maRight; /// All data of right frame border.

2
svx/source/stbctrls/xmlsecctrl.cxx
View File

@ -41,8 +41,6 @@ SFX_IMPL_STATUSBAR_CONTROL( XmlSecStatusBarControl, SfxUInt16Item );
struct XmlSecStatusBarControl::XmlSecStatusBarControl_Impl
{
Point maPos;
Size maSize;
SignatureState mnState;
Image maImage;
Image maImageBroken;

1
svx/source/svdraw/svdocirc.cxx
View File

@ -355,7 +355,6 @@ struct ImpCircUser : public SdrDragStatUserData
{
Rectangle aR;
Point aCenter;
Point aRadius;
Point aP1;
Point aP2;
long nMaxRad;

1
svx/source/svdraw/svdomeas.cxx
View File

@ -300,7 +300,6 @@ struct ImpMeasurePoly
ImpLineRec aMainline3; // those in between
ImpLineRec aHelpline1;
ImpLineRec aHelpline2;
Rectangle aTextRect;
Size aTextSize;
long nLineLen;
long nLineAngle;

1
sw/source/core/access/acccontext.hxx
View File

@ -59,7 +59,6 @@ class SwAccessibleContext :
friend class SwAccessibleSelectionHelper;
protected:
mutable ::osl::Mutex m_ListenerMutex;
mutable ::osl::Mutex m_Mutex;
private:

3
sw/source/uibase/config/cfgitems.cxx
View File

@ -31,8 +31,7 @@
SwDocDisplayItem::SwDocDisplayItem( sal_uInt16 _nWhich ) :
SfxPoolItem(_nWhich),
aIndexBackgrndCol(COL_GRAY)
SfxPoolItem(_nWhich)
{
bParagraphEnd =
bTab =

2
sw/source/uibase/inc/cfgitems.hxx
View File

@ -54,8 +54,6 @@ class SW_DLLPUBLIC SwDocDisplayItem : public SfxPoolItem
bool bManualBreak :1;
bool bShowHiddenPara :1;
Color aIndexBackgrndCol;
public:
SwDocDisplayItem( sal_uInt16 nWhich = FN_PARAM_DOCDISP );
SwDocDisplayItem(

3
sw/source/uibase/inc/drawbase.hxx
View File

@ -35,8 +35,7 @@ protected:
SwWrtShell* m_pSh;
VclPtr<SwEditWin> m_pWin;
Point m_aStartPos; // position of BeginCreate
Point m_aMDPos; // position of MouseButtonDown
sal_uInt16 m_nSlotId;
sal_uInt16 m_nSlotId;
bool m_bCreateObj :1;
bool m_bInsForm :1;

1
sw/source/uibase/inc/navipi.hxx
View File

@ -67,7 +67,6 @@ class SwNavigationPI : public vcl::Window,
OUString m_sContentFileName;
OUString m_aContextArr[3];
OUString m_aStatusArr[4];
Point m_aBoxBottomLeft; // Pos when Box is at bottom
SfxObjectShellLock *m_pxObjectShell;
SwView *m_pContentView;

6
tools/source/inet/inetmime.cxx
View File

@ -467,14 +467,12 @@ struct Parameter
Parameter * m_pNext;
OString m_aAttribute;
OString m_aCharset;
OString m_aLanguage;
OString m_aValue;
sal_uInt32 m_nSection;
bool m_bExtended;
inline Parameter(Parameter * pTheNext, const OString& rTheAttribute,
const OString& rTheCharset,
const OString& rTheLanguage,
const OString& rTheValue, sal_uInt32 nTheSection,
bool bTheExtended);
};
@ -482,13 +480,11 @@ struct Parameter
inline Parameter::Parameter(Parameter * pTheNext,
const OString& rTheAttribute,
const OString& rTheCharset,
const OString& rTheLanguage,
const OString& rTheValue,
sal_uInt32 nTheSection, bool bTheExtended):
m_pNext(pTheNext),
m_aAttribute(rTheAttribute),
m_aCharset(rTheCharset),
m_aLanguage(rTheLanguage),
m_aValue(rTheValue),
m_nSection(nTheSection),
m_bExtended(bTheExtended)
@ -2001,7 +1997,7 @@ sal_Unicode const * scanParameters(sal_Unicode const * pBegin,
RTL_TEXTENCODING_UTF8);
}
*pPos = new Parameter(*pPos, aAttribute, aCharset, aLanguage, aValue,
*pPos = new Parameter(*pPos, aAttribute, aCharset, aValue,
nSection, bExtended);
}
return parseParameters(aList, pParameters) ? pParameterBegin : pBegin;

1
ucb/source/ucp/ftp/ftpcontent.cxx
View File

@ -254,7 +254,6 @@ public:
return new ResultSetI(m_xContext,
m_xProvider,
m_seq,
m_seqSort,
m_dirvec);
}

3
ucb/source/ucp/ftp/ftpresultsetI.cxx
View File

@ -41,9 +41,8 @@ using namespace com::sun::star::sdbc;
ResultSetI::ResultSetI(const Reference<XComponentContext>& rxContext,
const Reference<XContentProvider>& xProvider,
const Sequence<Property>& seqProp,
const Sequence< NumberedSortingInfo >& seqSort,
const std::vector<FTPDirentry>& dirvec)
: ResultSetBase(rxContext,xProvider,seqProp,seqSort)
: ResultSetBase(rxContext,xProvider,seqProp)
{
for( size_t i = 0; i < dirvec.size(); ++i)
m_aPath.push_back(dirvec[i].m_aURL);

1
ucb/source/ucp/ftp/ftpresultsetI.hxx
View File

@ -38,7 +38,6 @@ namespace ftp {
const css::uno::Reference< css::uno::XComponentContext>& rxContext,
const css::uno::Reference< css::ucb::XContentProvider>& xProvider,
const css::uno::Sequence< css::beans::Property >& seq,
const css::uno::Sequence< css::ucb::NumberedSortingInfo >& seqSort,
const std::vector<FTPDirentry>& dirvec);
private:

4
ucb/source/ucp/ftp/ftpresultsetbase.cxx
View File

@ -33,15 +33,13 @@ using namespace com::sun::star;
ResultSetBase::ResultSetBase(
const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< ucb::XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq,
const uno::Sequence< ucb::NumberedSortingInfo >& seqSort )
const uno::Sequence< beans::Property >& seq )
: m_xContext( rxContext ),
m_xProvider( xProvider ),
m_nRow( -1 ),
m_nWasNull( true ),
m_bRowCountFinal( true ),
m_sProperty( seq ),
m_sSortingInfo( seqSort ),
m_pDisposeEventListeners( nullptr ),
m_pRowCountListeners( nullptr ),
m_pIsFinalListeners( nullptr )

28
ucb/source/ucp/ftp/ftpresultsetbase.hxx
View File

@ -52,8 +52,7 @@ namespace ftp {
ResultSetBase(const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::ucb::XContentProvider >& xProvider,
const css::uno::Sequence< css::beans::Property >& seq,
const css::uno::Sequence< css::ucb::NumberedSortingInfo >& seqSort);
const css::uno::Sequence< css::beans::Property >& seq);
virtual ~ResultSetBase();
@ -516,29 +515,26 @@ namespace ftp {
protected:
css::uno::Reference<
css::uno::XComponentContext > m_xContext;
css::uno::Reference<
css::ucb::XContentProvider > m_xProvider;
css::uno::Reference< css::uno::XComponentContext >
m_xContext;
css::uno::Reference< css::ucb::XContentProvider >
m_xProvider;
sal_Int32 m_nRow;
bool m_nWasNull;
bool m_bRowCountFinal;
typedef std::vector< css::uno::Reference<
css::ucb::XContentIdentifier > > IdentSet;
typedef std::vector< css::uno::Reference<
css::sdbc::XRow > > ItemSet;
typedef std::vector< OUString >
PathSet;
typedef std::vector< css::uno::Reference<css::ucb::XContentIdentifier > >
IdentSet;
typedef std::vector< css::uno::Reference< css::sdbc::XRow > >
ItemSet;
typedef std::vector< OUString > PathSet;
IdentSet m_aIdents;
ItemSet m_aItems;
PathSet m_aPath;
css::uno::Sequence<
css::beans::Property > m_sProperty;
css::uno::Sequence<
css::ucb::NumberedSortingInfo > m_sSortingInfo;
css::uno::Sequence< css::beans::Property >
m_sProperty;
osl::Mutex m_aMutex;
cppu::OInterfaceContainerHelper* m_pDisposeEventListeners;

1
ucbhelper/source/provider/contentidentifier.cxx
View File

@ -49,7 +49,6 @@ struct ContentIdentifier_Impl
{
OUString m_aContentId;
OUString m_aProviderScheme;
osl::Mutex m_aMutex;
explicit ContentIdentifier_Impl( const OUString& rURL );
};

1
unotools/source/config/dynamicmenuoptions.cxx
View File

@ -66,7 +66,6 @@ using namespace ::com::sun::star::beans;
****************************************************************************************************************-*/
struct SvtDynMenuEntry
{
OUString sName;
OUString sURL;
OUString sTitle;
OUString sImageIdentifier;

1
unoxml/source/dom/notation.cxx
View File

@ -32,7 +32,6 @@ namespace DOM
xmlNotationPtr const pNotation)
: CNotation_Base(rDocument, rMutex,
NodeType_NOTATION_NODE, reinterpret_cast<xmlNodePtr>(pNotation))
, m_aNotationPtr(pNotation)
{
}

3
unoxml/source/dom/notation.hxx
View File

@ -38,9 +38,6 @@ namespace DOM
private:
friend class CDocument;
private:
xmlNotationPtr m_aNotationPtr;
protected:
CNotation(CDocument const& rDocument, ::osl::Mutex const& rMutex,
xmlNotationPtr const pNotation);

1
uui/source/iahndl.hxx
View File

@ -80,7 +80,6 @@ typedef std::unordered_map< OUString, OUString, OUStringHash > StringHashMap;
class UUIInteractionHelper
{
private:
mutable osl::Mutex m_aPropertyMutex;
css::uno::Reference< css::uno::XComponentContext > m_xContext;
css::uno::Reference< css::awt::XWindow > m_xWindowParam;
const OUString m_aContextParam;

2
xmlhelp/source/cxxhelp/provider/content.cxx
View File

@ -196,7 +196,6 @@ public:
return new ResultSetForRoot( m_xContext,
m_xProvider,
m_seq,
m_seqSort,
m_aURLParameter,
m_pDatabases );
}
@ -237,7 +236,6 @@ public:
return new ResultSetForQuery( m_xContext,
m_xProvider,
m_seq,
m_seqSort,
m_aURLParameter,
m_pDatabases );
}

4
xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
View File

@ -33,15 +33,13 @@ using namespace com::sun::star;
ResultSetBase::ResultSetBase( const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< ucb::XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq,
const uno::Sequence< ucb::NumberedSortingInfo >& seqSort )
const uno::Sequence< beans::Property >& seq )
: m_xContext( rxContext ),
m_xProvider( xProvider ),
m_nRow( -1 ),
m_nWasNull( true ),
m_bRowCountFinal( true ),
m_sProperty( seq ),
m_sSortingInfo( seqSort ),
m_pDisposeEventListeners( nullptr ),
m_pRowCountListeners( nullptr ),
m_pIsFinalListeners( nullptr )

4
xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
View File

@ -52,8 +52,7 @@ namespace chelp {
ResultSetBase( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::ucb::XContentProvider >& xProvider,
const css::uno::Sequence< css::beans::Property >& seq,
const css::uno::Sequence< css::ucb::NumberedSortingInfo >& seqSort );
const css::uno::Sequence< css::beans::Property >& seq );
virtual ~ResultSetBase();
@ -547,7 +546,6 @@ namespace chelp {
PathSet m_aPath;
css::uno::Sequence< css::beans::Property > m_sProperty;
css::uno::Sequence< css::ucb::NumberedSortingInfo > m_sSortingInfo;
osl::Mutex m_aMutex;
cppu::OInterfaceContainerHelper* m_pDisposeEventListeners;

3
xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx
View File

@ -82,10 +82,9 @@ struct HitItem
ResultSetForQuery::ResultSetForQuery( const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq,
const uno::Sequence< NumberedSortingInfo >& seqSort,
URLParameter& aURLParameter,
Databases* pDatabases )
: ResultSetBase( rxContext,xProvider,seq,seqSort ),
: ResultSetBase( rxContext,xProvider,seq ),
m_aURLParameter( aURLParameter )
{
Reference< XExtendedTransliteration > xTrans = Transliteration::create( rxContext );

1
xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx
View File

@ -39,7 +39,6 @@ namespace chelp {
ResultSetForQuery( const css::uno::Reference<css::uno::XComponentContext>& rxContext,
const css::uno::Reference<css::ucb::XContentProvider>& xProvider,
const css::uno::Sequence< css::beans::Property >& seq,
const css::uno::Sequence< css::ucb::NumberedSortingInfo >& seqSort,
URLParameter& aURLParameter,
Databases* pDatabases );

3
xmlhelp/source/cxxhelp/provider/resultsetforroot.cxx
View File

@ -33,10 +33,9 @@ using namespace com::sun::star::ucb;
ResultSetForRoot::ResultSetForRoot( const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq,
const uno::Sequence< NumberedSortingInfo >& seqSort,
URLParameter& aURLParameter,
Databases* pDatabases )
: ResultSetBase( rxContext, xProvider,seq,seqSort ),
: ResultSetBase( rxContext, xProvider,seq ),
m_aURLParameter( aURLParameter ),
m_pDatabases( pDatabases )
{

1
xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx
View File

@ -39,7 +39,6 @@ namespace chelp {
ResultSetForRoot( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::ucb::XContentProvider >& xProvider,
const css::uno::Sequence< css::beans::Property >& seq,
const css::uno::Sequence< css::ucb::NumberedSortingInfo >& seqSort,
URLParameter& aURLParameter,
Databases* pDatabases );

1
xmloff/source/forms/attriblistmerge.hxx
View File

@ -41,7 +41,6 @@ namespace xmloff
class OAttribListMerger : public OAttribListMerger_Base
{
protected:
::osl::Mutex m_aMutex;
typedef std::vector< css::uno::Reference< css::xml::sax::XAttributeList > > AttributeListArray;
AttributeListArray m_aLists;