loplugin:sequenceloop in postprocess..reportdesign

Change-Id: I86b9174c37e4a347a3a8ac6c2707052167e6fdc0
Reviewed-on: https://gerrit.libreoffice.org/77522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

postprocess/qa/services.cxx

@@ -106,7 +106,8 @@ void addService(
     if (!allServices->insert(service).second) {
         return;
     }
-    for (auto const & serv: service->getMandatoryServices()) {
+    const auto aMandatoryServices = service->getMandatoryServices();
+    for (auto const & serv : aMandatoryServices) {
         addService(serv, allServices);
     }
 }
@@ -400,7 +401,7 @@ void Test::createInstance(
             + msg(name) + "\" reports wrong implementation name")
          .getStr()),
         expImpl, info->getImplementationName());
-    css::uno::Sequence<OUString> servs(info->getSupportedServiceNames());
+    const css::uno::Sequence<OUString> servs(info->getSupportedServiceNames());
     CPPUNIT_ASSERT_MESSAGE(
         (OString(
             "instantiating \"" + msg(implementationName) + "\" via \""

pyuno/source/module/pyuno_struct.cxx

@@ -105,7 +105,8 @@ static PyObject* PyUNOStruct_dir( PyObject *self )
     try
     {
         member_list = PyList_New( 0 );
-        for( const auto& aMember : me->members->xInvocation->getMemberNames() )
+        const css::uno::Sequence<OUString> aMemberNames = me->members->xInvocation->getMemberNames();
+        for( const auto& aMember : aMemberNames )
         {
             // setitem steals a reference
             PyList_Append( member_list, ustring2PyString( aMember ).getAcquired() );

reportdesign/source/core/api/ReportDefinition.cxx

@@ -2475,7 +2475,7 @@ OUString OReportDefinition::getDocumentBaseURL() const
 
     ::osl::MutexGuard aGuard(m_aMutex);
     ::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
-    for (beans::PropertyValue const& it : m_pImpl->m_aArgs)
+    for (beans::PropertyValue const& it : std::as_const(m_pImpl->m_aArgs))
     {
         if (it.Name == "DocumentBaseURL")
             return it.Value.get<OUString>();

reportdesign/source/ui/inspection/GeometryHandler.cxx

@@ -803,11 +803,11 @@ inspection::LineDescriptor SAL_CALL GeometryHandler::describePropertyLine(const
                 }
                 else
                 {
-                    for (auto const& it : m_aFieldNames)
+                    for (auto const& it : std::as_const(m_aFieldNames))
                     {
                         xListControl->appendListEntry(it);
                     }
-                    for (auto const& it : m_aParamNames)
+                    for (auto const& it : std::as_const(m_aParamNames))
                     {
                         xListControl->appendListEntry(it);
                     }

reportdesign/source/ui/inspection/metadata.cxx

@@ -226,7 +226,7 @@ namespace rptui
 
     void OPropertyInfoService::getExcludeProperties(::std::vector< beans::Property >& _rExcludeProperties,const css::uno::Reference< css::inspection::XPropertyHandler >& _xFormComponentHandler)
     {
-        uno::Sequence< beans::Property > aProps = _xFormComponentHandler->getSupportedProperties();
+        const uno::Sequence< beans::Property > aProps = _xFormComponentHandler->getSupportedProperties();
         static const OUStringLiteral pExcludeProperties[] =
         {
                 "Enabled",

reportdesign/source/ui/report/ViewsWindow.cxx

@@ -1227,7 +1227,7 @@ void OViewsWindow::EndDragObj(bool _bControlKeyPressed, const OSectionView* _pSe
                     aNewPos.setY( 0 );
 
                 Point aPrevious;
-                for (beans::NamedValue const & namedVal : aAllreadyCopiedObjects)
+                for (beans::NamedValue const & namedVal : std::as_const(aAllreadyCopiedObjects))
                 {
                     uno::Sequence< uno::Reference<report::XReportComponent> > aClones;
                     namedVal.Value >>= aClones;