mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve warning messages

Browse Source 
Change-Id: I75eb9f17a3dcc688314355fa957e3f34086b161a
This commit is contained in:
Stephan Bergmann
2015-11-05 09:30:42 +01:00
parent ffde331fbe
commit b16a337231
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
compilerplugins/clang/vclwidgets.cxx
View File

@@ -189,7 +189,7 @@ bool VCLWidgets::VisitCXXDestructorDecl(const CXXDestructorDecl* pCXXDestructorD
if (bFoundVclPtrField && pCompoundStatement && pCompoundStatement->size() == 0) { if (bFoundVclPtrField && pCompoundStatement && pCompoundStatement->size() == 0) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass with VclPtr field must call disposeOnce() from its destructor.", "OutputDevice subclass with VclPtr field must call disposeOnce() from its destructor",
pCXXDestructorDecl->getLocStart()) pCXXDestructorDecl->getLocStart())
<< pCXXDestructorDecl->getSourceRange(); << pCXXDestructorDecl->getSourceRange();
return true; return true;
@@ -225,7 +225,7 @@ bool VCLWidgets::VisitCXXDestructorDecl(const CXXDestructorDecl* pCXXDestructorD
{ {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass should have nothing in its destructor but a call to disposeOnce().", "OutputDevice subclass should have nothing in its destructor but a call to disposeOnce()",
pCXXDestructorDecl->getLocStart()) pCXXDestructorDecl->getLocStart())
<< pCXXDestructorDecl->getSourceRange(); << pCXXDestructorDecl->getSourceRange();
} }
@@ -264,9 +264,9 @@ bool VCLWidgets::VisitVarDecl(const VarDecl * pVarDecl) {
{ {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass should be wrapped in VclPtr. " + pVarDecl->getType().getAsString(), "OutputDevice subclass %0 should be wrapped in VclPtr",
pVarDecl->getLocation()) pVarDecl->getLocation())
<< pVarDecl->getSourceRange(); << pVarDecl->getType() << pVarDecl->getSourceRange();
return true; return true;
} }
@@ -282,7 +282,7 @@ bool VCLWidgets::VisitVarDecl(const VarDecl * pVarDecl) {
if (isDerivedFromWindow(recordDecl)) { if (isDerivedFromWindow(recordDecl)) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass allocated on stack, should be allocated via VclPtr or via *.", "OutputDevice subclass allocated on stack, should be allocated via VclPtr or via *",
pVarDecl->getLocation()) pVarDecl->getLocation())
<< pVarDecl->getSourceRange(); << pVarDecl->getSourceRange();
} }
@@ -302,9 +302,9 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * fieldDecl) {
if (!(pParentRecordDecl != nullptr && pParentRecordDecl->getQualifiedNameAsString() == "ErrorContextImpl")) { if (!(pParentRecordDecl != nullptr && pParentRecordDecl->getQualifiedNameAsString() == "ErrorContextImpl")) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass declared as a pointer field, should be wrapped in VclPtr." + fieldDecl->getType().getAsString(), "OutputDevice subclass %0 declared as a pointer member, should be wrapped in VclPtr",
fieldDecl->getLocation()) fieldDecl->getLocation())
<< fieldDecl->getSourceRange(); << fieldDecl->getType() << fieldDecl->getSourceRange();
return true; return true;
} }
} }
@@ -321,7 +321,7 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * fieldDecl) {
if (isDerivedFromWindow(recordDecl)) { if (isDerivedFromWindow(recordDecl)) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass allocated as a class member, should be allocated via VclPtr.", "OutputDevice subclass allocated as a class member, should be allocated via VclPtr",
fieldDecl->getLocation()) fieldDecl->getLocation())
<< fieldDecl->getSourceRange(); << fieldDecl->getSourceRange();
} }
@@ -342,14 +342,14 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * fieldDecl) {
if (!bFoundDispose) { if (!bFoundDispose) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass with a VclPtr field MUST have a dispose() method.", "OutputDevice subclass with a VclPtr field MUST override dispose() (and call its superclass dispose() as the last thing it does)",
fieldDecl->getLocation()) fieldDecl->getLocation())
<< fieldDecl->getSourceRange(); << fieldDecl->getSourceRange();
} }
if (!pParentRecordDecl->hasUserDeclaredDestructor()) { if (!pParentRecordDecl->hasUserDeclaredDestructor()) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass with a VclPtr field MUST have an explicit destructor.", "OutputDevice subclass with a VclPtr field MUST have a user-provided destructor (that calls disposeOnce())",
fieldDecl->getLocation()) fieldDecl->getLocation())
<< fieldDecl->getSourceRange(); << fieldDecl->getSourceRange();
} }
@@ -402,7 +402,7 @@ bool VCLWidgets::VisitFunctionDecl( const FunctionDecl* functionDecl )
if (!isDisposeCallingSuperclassDispose(pMethodDecl)) { if (!isDisposeCallingSuperclassDispose(pMethodDecl)) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"OutputDevice subclass dispose() method MUST call dispose() of its superclass as the last thing it does", "OutputDevice subclass dispose() function MUST call dispose() of its superclass as the last thing it does",
functionDecl->getLocStart()) functionDecl->getLocStart())
<< functionDecl->getSourceRange(); << functionDecl->getSourceRange();
} }
@@ -601,7 +601,7 @@ bool VCLWidgets::VisitCXXConstructExpr( const CXXConstructExpr* constructExpr )
if (isDerivedFromWindow(recordDecl)) { if (isDerivedFromWindow(recordDecl)) {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"Calling constructor of a Window-derived type directly. All such creation should go via VclPtr<>::Create", "Calling constructor of a Window-derived type directly; all such creation should go via VclPtr<>::Create",
constructExpr->getExprLoc()); constructExpr->getExprLoc());
} }
return true; return true;