mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:constparams in formula,xmlhelp

Browse Source 
Change-Id: I1c987d991a5b292df327d1bb921099233b5531fe
Reviewed-on: https://gerrit.libreoffice.org/40584
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-07-31 10:51:42 +02:00
parent 4732e65646
commit b1a1baa66a
11 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
connectivity/source/drivers/firebird/Catalog.cxx
View File

@@ -67,7 +67,7 @@ void Catalog::refreshGroups()
//----- IRefreshableUsers ---------------------------------------------------- //----- IRefreshableUsers ----------------------------------------------------
void Catalog::refreshUsers() void Catalog::refreshUsers()
{ {
OUString sSql("SELECT DISTINCT RDB$USER FROM RDB$USER_PRIVILEGES"); OUString const sSql("SELECT DISTINCT RDB$USER FROM RDB$USER_PRIVILEGES");
uno::Reference< XResultSet > xUsers = m_xMetaData->getConnection() uno::Reference< XResultSet > xUsers = m_xMetaData->getConnection()
->createStatement()->executeQuery(sSql); ->createStatement()->executeQuery(sSql);

4
formula/source/core/api/FormulaCompiler.cxx
View File

@@ -2590,7 +2590,7 @@ formula::ParamClass FormulaCompiler::GetForceArrayParameter( const FormulaToken*
return ParamClass::Unknown; return ParamClass::Unknown;
} }
void FormulaCompiler::ForceArrayOperator( FormulaTokenRef& rCurr ) void FormulaCompiler::ForceArrayOperator( FormulaTokenRef const & rCurr )
{ {
if (!pCurrentFactorToken || (pCurrentFactorToken.get() == rCurr.get())) if (!pCurrentFactorToken || (pCurrentFactorToken.get() == rCurr.get()))
return; return;
@@ -2628,7 +2628,7 @@ void FormulaCompiler::ForceArrayOperator( FormulaTokenRef& rCurr )
} }
} }
void FormulaCompiler::CheckSetForceArrayParameter( FormulaTokenRef& rCurr, sal_uInt8 nParam ) void FormulaCompiler::CheckSetForceArrayParameter( FormulaTokenRef const & rCurr, sal_uInt8 nParam )
{ {
if (!pCurrentFactorToken) if (!pCurrentFactorToken)
return; return;

8
formula/source/ui/dlg/formula.cxx
View File

@@ -121,7 +121,7 @@ public:
void UpdateParaWin( const Selection& _rSelection, const OUString& _sRefStr); void UpdateParaWin( const Selection& _rSelection, const OUString& _sRefStr);
void SetData( sal_Int32 nFStart, sal_Int32 nNextFStart, sal_Int32 nNextFEnd, sal_Int32& PrivStart, sal_Int32& PrivEnd); void SetData( sal_Int32 nFStart, sal_Int32 nNextFStart, sal_Int32 nNextFEnd, sal_Int32& PrivStart, sal_Int32& PrivEnd);
void PreNotify( NotifyEvent& rNEvt ); void PreNotify( NotifyEvent const & rNEvt );
RefEdit* GetCurrRefEdit(); RefEdit* GetCurrRefEdit();
@@ -381,7 +381,7 @@ void FormulaDlg_Impl::StoreFormEditData(FormEditData* pData)
} }
void FormulaDlg_Impl::PreNotify( NotifyEvent& rNEvt ) void FormulaDlg_Impl::PreNotify( NotifyEvent const & rNEvt )
{ {
if (m_bIsShutDown) if (m_bIsShutDown)
return; return;
@@ -1745,7 +1745,7 @@ void FormulaDlg_Impl::SetEdSelection()
} }
FormulaModalDialog::FormulaModalDialog( vcl::Window* pParent FormulaModalDialog::FormulaModalDialog( vcl::Window* pParent
, IFunctionManager* _pFunctionMgr , IFunctionManager const * _pFunctionMgr
, IControlReferenceHandler* _pDlg ) , IControlReferenceHandler* _pDlg )
: ModalDialog(pParent, "FormulaDialog", "formula/ui/formuladialog.ui") : ModalDialog(pParent, "FormulaDialog", "formula/ui/formuladialog.ui")
, m_pImpl(new FormulaDlg_Impl(this, false/*_bSupportFunctionResult*/, , m_pImpl(new FormulaDlg_Impl(this, false/*_bSupportFunctionResult*/,
@@ -1816,7 +1816,7 @@ void FormulaModalDialog::StoreFormEditData(FormEditData* pData)
FormulaDlg::FormulaDlg( SfxBindings* pB, SfxChildWindow* pCW, FormulaDlg::FormulaDlg( SfxBindings* pB, SfxChildWindow* pCW,
vcl::Window* pParent vcl::Window* pParent
, IFunctionManager* _pFunctionMgr, IControlReferenceHandler* _pDlg ) : , IFunctionManager const * _pFunctionMgr, IControlReferenceHandler* _pDlg ) :
SfxModelessDialog( pB, pCW, pParent, "FormulaDialog", "formula/ui/formuladialog.ui" ), SfxModelessDialog( pB, pCW, pParent, "FormulaDialog", "formula/ui/formuladialog.ui" ),
m_pImpl( new FormulaDlg_Impl(this, true/*_bSupportFunctionResult*/ m_pImpl( new FormulaDlg_Impl(this, true/*_bSupportFunctionResult*/
, true/*_bSupportResult*/ , true/*_bSupportResult*/

6
include/formula/FormulaCompiler.hxx
View File

@@ -368,9 +368,9 @@ private:
set ForceArray at rCurr if so. Set nParam+1 as 1-based set ForceArray at rCurr if so. Set nParam+1 as 1-based
nCurrentFactorParam for subsequent ForceArrayOperator() calls. nCurrentFactorParam for subsequent ForceArrayOperator() calls.
*/ */
void CheckSetForceArrayParameter( FormulaTokenRef& rCurr, sal_uInt8 nParam ); void CheckSetForceArrayParameter( FormulaTokenRef const & rCurr, sal_uInt8 nParam );
void ForceArrayOperator( FormulaTokenRef& rCurr ); void ForceArrayOperator( FormulaTokenRef const & rCurr );
class CurrentFactor class CurrentFactor
{ {
@@ -391,7 +391,7 @@ private:
pCompiler->nCurrentFactorParam = nPrevParam; pCompiler->nCurrentFactorParam = nPrevParam;
} }
// yes, this operator= may modify the RValue // yes, this operator= may modify the RValue
void operator=( FormulaTokenRef& r ) void operator=( FormulaTokenRef const & r )
{ {
pCompiler->ForceArrayOperator( r ); pCompiler->ForceArrayOperator( r );
pCompiler->pCurrentFactorToken = r; pCompiler->pCurrentFactorToken = r;

4
include/formula/formula.hxx
View File

@@ -64,7 +64,7 @@ class FORMULA_DLLPUBLIC FormulaModalDialog : public ModalDialog, public formul
friend class FormulaDlg_Impl; friend class FormulaDlg_Impl;
public: public:
FormulaModalDialog( vcl::Window* pParent FormulaModalDialog( vcl::Window* pParent
,IFunctionManager* _pFunctionMgr ,IFunctionManager const * _pFunctionMgr
,IControlReferenceHandler* _pDlg ); ,IControlReferenceHandler* _pDlg );
virtual ~FormulaModalDialog() override; virtual ~FormulaModalDialog() override;
virtual void dispose() override; virtual void dispose() override;
@@ -95,7 +95,7 @@ public:
FormulaDlg( SfxBindings* pB FormulaDlg( SfxBindings* pB
, SfxChildWindow* pCW , SfxChildWindow* pCW
, vcl::Window* pParent , vcl::Window* pParent
, IFunctionManager* _pFunctionMgr , IFunctionManager const * _pFunctionMgr
, IControlReferenceHandler* _pDlg ); , IControlReferenceHandler* _pDlg );
virtual ~FormulaDlg() override; virtual ~FormulaDlg() override;
virtual void dispose() override; virtual void dispose() override;

2
include/formula/token.hxx
View File

@@ -423,7 +423,7 @@ private:
pJump; pJump;
ParamClass eInForceArray; ParamClass eInForceArray;
public: public:
FormulaJumpToken( OpCode e, short* p ) : FormulaJumpToken( OpCode e, short const * p ) :
FormulaToken( formula::svJump , e), FormulaToken( formula::svJump , e),
eInForceArray( ParamClass::Unknown) eInForceArray( ParamClass::Unknown)
{ {

2
sc/source/core/tool/token.cxx
View File

@@ -430,7 +430,7 @@ FormulaToken* ScRawToken::CreateToken() const
return new ScExternalNameToken( extname.nFileId, aName ); return new ScExternalNameToken( extname.nFileId, aName );
} }
case svJump : case svJump :
return new FormulaJumpToken( eOp, const_cast<short*>(nJump) ); return new FormulaJumpToken( eOp, nJump );
case svExternal : case svExternal :
return new FormulaExternalToken( eOp, sbyte.cByte, OUString( cStr+1 ) ); return new FormulaExternalToken( eOp, sbyte.cByte, OUString( cStr+1 ) );
case svFAP : case svFAP :

6
xmlhelp/source/cxxhelp/provider/databases.cxx
View File

@@ -595,10 +595,10 @@ namespace chelp {
} }
KeywordInfo::KeywordElement::KeywordElement( Databases *pDatabases, KeywordInfo::KeywordElement::KeywordElement( Databases const *pDatabases,
helpdatafileproxy::Hdf* pHdf, helpdatafileproxy::Hdf* pHdf,
OUString& ky, OUString const & ky,
OUString& data ) OUString const & data )
: key( ky ) : key( ky )
{ {
pDatabases->replaceName( key ); pDatabases->replaceName( key );

6
xmlhelp/source/cxxhelp/provider/databases.hxx
View File

@@ -92,10 +92,10 @@ namespace chelp {
public: public:
KeywordElement( Databases* pDatabases, KeywordElement( Databases const * pDatabases,
helpdatafileproxy::Hdf* pHdf, helpdatafileproxy::Hdf* pHdf,
OUString& key, OUString const & key,
OUString& ids ); OUString const & ids );
private: private:

2
xmlhelp/source/cxxhelp/provider/resultsetforroot.cxx
View File

@@ -32,7 +32,7 @@ using namespace com::sun::star::ucb;
ResultSetForRoot::ResultSetForRoot( const uno::Reference< uno::XComponentContext >& rxContext, ResultSetForRoot::ResultSetForRoot( const uno::Reference< uno::XComponentContext >& rxContext,
const uno::Reference< XContentProvider >& xProvider, const uno::Reference< XContentProvider >& xProvider,
const uno::Sequence< beans::Property >& seq, const uno::Sequence< beans::Property >& seq,
URLParameter& aURLParameter, URLParameter const & aURLParameter,
Databases* pDatabases ) Databases* pDatabases )
: ResultSetBase( rxContext, xProvider,seq ), : ResultSetBase( rxContext, xProvider,seq ),
m_aURLParameter( aURLParameter ), m_aURLParameter( aURLParameter ),

2
xmlhelp/source/cxxhelp/provider/resultsetforroot.hxx
View File

@@ -39,7 +39,7 @@ namespace chelp {
ResultSetForRoot( const css::uno::Reference< css::uno::XComponentContext >& rxContext, ResultSetForRoot( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::ucb::XContentProvider >& xProvider, const css::uno::Reference< css::ucb::XContentProvider >& xProvider,
const css::uno::Sequence< css::beans::Property >& seq, const css::uno::Sequence< css::beans::Property >& seq,
URLParameter& aURLParameter, URLParameter const & aURLParameter,
Databases* pDatabases ); Databases* pDatabases );