mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

calling GetChar() only once suffices

Browse Source
This commit is contained in:
Takeshi Abe
2012-04-18 00:23:42 +09:00
parent f00d60997e
commit b1bee56af9
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
basctl/source/basicide/basobj2.cxx
View File

@@ -108,10 +108,11 @@ sal_Bool IsValidSbxName( const String& rName )
{ {
for ( sal_uInt16 nChar = 0; nChar < rName.Len(); nChar++ ) for ( sal_uInt16 nChar = 0; nChar < rName.Len(); nChar++ )
{ {
sal_Bool bValid = ( ( rName.GetChar(nChar) >= 'A' && rName.GetChar(nChar) <= 'Z' ) || sal_Unicode c = rName.GetChar(nChar);
( rName.GetChar(nChar) >= 'a' && rName.GetChar(nChar) <= 'z' ) || sal_Bool bValid = ( ( c >= 'A' && c <= 'Z' ) ||
( rName.GetChar(nChar) >= '0' && rName.GetChar(nChar) <= '9' && nChar ) || ( c >= 'a' && c <= 'z' ) ||
( rName.GetChar(nChar) == '_' ) ); ( c >= '0' && c <= '9' && nChar ) ||
( c == '_' ) );
if ( !bValid ) if ( !bValid )
return sal_False; return sal_False;
} }