mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:returnconstval in writerperfect

Browse Source 
Change-Id: I86e9977438c69c19adafc3743e618321a05e3923
Reviewed-on: https://gerrit.libreoffice.org/78064
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-08-24 20:35:36 +02:00
parent 502d73cda8
commit b26a3db534
9 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
writerperfect/inc/DirectoryStream.hxx
View File

@@ -44,7 +44,7 @@ public:
static std::unique_ptr<DirectoryStream> static std::unique_ptr<DirectoryStream>
createForParent(const css::uno::Reference<css::ucb::XContent>& xContent); createForParent(const css::uno::Reference<css::ucb::XContent>& xContent);
const css::uno::Reference<css::ucb::XContent> getContent() const; css::uno::Reference<css::ucb::XContent> getContent() const;
virtual bool isStructured() override; virtual bool isStructured() override;
virtual unsigned subStreamCount() override; virtual unsigned subStreamCount() override;

2
writerperfect/inc/DocumentHandlerFor.hxx
View File

@@ -16,7 +16,7 @@ namespace writerperfect
*/ */
template <class Generator> struct DocumentHandlerFor template <class Generator> struct DocumentHandlerFor
{ {
// static const OUString name(); // static OUString name();
}; };
} }

2
writerperfect/inc/DocumentHandlerForOdg.hxx
View File

@@ -16,7 +16,7 @@ namespace writerperfect
{ {
template <> struct DocumentHandlerFor<OdgGenerator> template <> struct DocumentHandlerFor<OdgGenerator>
{ {
static const OUString name() { return "com.sun.star.comp.Draw.XMLOasisImporter"; } static OUString name() { return "com.sun.star.comp.Draw.XMLOasisImporter"; }
}; };
} }

2
writerperfect/inc/DocumentHandlerForOdp.hxx
View File

@@ -16,7 +16,7 @@ namespace writerperfect
{ {
template <> struct DocumentHandlerFor<OdpGenerator> template <> struct DocumentHandlerFor<OdpGenerator>
{ {
static const OUString name() { return "com.sun.star.comp.Impress.XMLOasisImporter"; } static OUString name() { return "com.sun.star.comp.Impress.XMLOasisImporter"; }
}; };
} }

2
writerperfect/inc/DocumentHandlerForOds.hxx
View File

@@ -16,7 +16,7 @@ namespace writerperfect
{ {
template <> struct DocumentHandlerFor<OdsGenerator> template <> struct DocumentHandlerFor<OdsGenerator>
{ {
static const OUString name() { return "com.sun.star.comp.Calc.XMLOasisImporter"; } static OUString name() { return "com.sun.star.comp.Calc.XMLOasisImporter"; }
}; };
} }

2
writerperfect/inc/DocumentHandlerForOdt.hxx
View File

@@ -16,7 +16,7 @@ namespace writerperfect
{ {
template <> struct DocumentHandlerFor<OdtGenerator> template <> struct DocumentHandlerFor<OdtGenerator>
{ {
static const OUString name() { return "com.sun.star.comp.Writer.XMLOasisImporter"; } static OUString name() { return "com.sun.star.comp.Writer.XMLOasisImporter"; }
}; };
} }

5
writerperfect/qa/unit/WPXSvStreamTest.cxx
View File

@@ -83,7 +83,7 @@ shared_ptr<RVNGInputStream> lcl_createStream()
return pInputStream; return pInputStream;
} }
const shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL) shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL)
{ {
using uno::Reference; using uno::Reference;
using uno::UNO_QUERY_THROW; using uno::UNO_QUERY_THROW;
@@ -97,8 +97,7 @@ const shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL)
const Reference<io::XInputStream> xInputStream(xFileAccess->openFileRead(rURL), const Reference<io::XInputStream> xInputStream(xFileAccess->openFileRead(rURL),
css::uno::UNO_SET_THROW); css::uno::UNO_SET_THROW);
const shared_ptr<RVNGInputStream> pInput(new WPXSvInputStream(xInputStream)); return shared_ptr<RVNGInputStream>(new WPXSvInputStream(xInputStream));
return pInput;
} }
void lcl_testSubStreams(const shared_ptr<RVNGInputStream>& pInput) void lcl_testSubStreams(const shared_ptr<RVNGInputStream>& pInput)

2
writerperfect/source/common/DirectoryStream.cxx
View File

@@ -157,7 +157,7 @@ DirectoryStream::createForParent(const css::uno::Reference<css::ucb::XContent>&
} }
} }
const css::uno::Reference<css::ucb::XContent> DirectoryStream::getContent() const css::uno::Reference<css::ucb::XContent> DirectoryStream::getContent() const
{ {
if (!m_pImpl) if (!m_pImpl)
return css::uno::Reference<css::ucb::XContent>(); return css::uno::Reference<css::ucb::XContent>();

2
writerperfect/source/common/WPXSvInputStream.cxx
View File

@@ -86,7 +86,7 @@ OUString lcl_normalizeSubStreamPath(const OUString& rPath)
namespace namespace
{ {
const OUString concatPath(const OUString& lhs, const OUString& rhs) OUString concatPath(const OUString& lhs, const OUString& rhs)
{ {
if (lhs.isEmpty()) if (lhs.isEmpty())
return rhs; return rhs;