mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

new loplugin: change virtual methods to non-virtual

Browse Source 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
This commit is contained in:
Noel Grandin
2015-01-20 12:38:10 +02:00
parent 26ad60aec6
commit b44cbb26ef
615 changed files with 1921 additions and 1965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/vbahelper/vbadocumentbase.hxx
View File

@@ -31,7 +31,7 @@ protected:
css::uno::Reference< css::frame::XModel > mxModel;
css::uno::Reference< css::uno::XInterface > mxVBProject;
protected:
virtual css::uno::Reference< css::frame::XModel > getModel() { return mxModel; }
css::uno::Reference< css::frame::XModel > getModel() { return mxModel; }
public:
VbaDocumentBase( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext,
css::uno::Reference< css::frame::XModel > xModel );

6
include/vbahelper/vbashape.hxx
View File

@@ -44,9 +44,9 @@ protected:
sal_Int32 m_nType;
css::uno::Reference< css::frame::XModel > m_xModel;
css::uno::Any m_aRange;
virtual void addListeners();
virtual void removeShapeListener() throw( css::uno::RuntimeException );
virtual void removeShapesListener() throw( css::uno::RuntimeException );
void addListeners();
void removeShapeListener() throw( css::uno::RuntimeException );
void removeShapesListener() throw( css::uno::RuntimeException );
virtual OUString getServiceImplName() SAL_OVERRIDE;
virtual css::uno::Sequence<OUString> getServiceNames() SAL_OVERRIDE;
public:

2
include/vbahelper/vbashapes.hxx
View File

@@ -41,7 +41,7 @@ protected:
css::uno::Reference< css::frame::XModel > m_xModel;
virtual OUString getServiceImplName() SAL_OVERRIDE;
virtual css::uno::Sequence<OUString> getServiceNames() SAL_OVERRIDE;
virtual css::uno::Reference< css::container::XIndexAccess > getShapesByArrayIndices( const css::uno::Any& Index ) throw (css::uno::RuntimeException);
css::uno::Reference< css::container::XIndexAccess > getShapesByArrayIndices( const css::uno::Any& Index ) throw (css::uno::RuntimeException);
css::uno::Reference< css::drawing::XShape > createShape( const OUString& service ) throw (css::uno::RuntimeException);
css::uno::Any AddRectangle( sal_Int32 startX, sal_Int32 startY, sal_Int32 nLineWidth, sal_Int32 nLineHeight, css::uno::Any aRange ) throw (css::uno::RuntimeException);
css::uno::Any AddEllipse( sal_Int32 startX, sal_Int32 startY, sal_Int32 nLineWidth, sal_Int32 nLineHeight, css::uno::Any aRange ) throw (css::uno::RuntimeException);

2
include/vbahelper/vbatextframe.hxx
View File

@@ -33,7 +33,7 @@ protected:
protected:
virtual OUString getServiceImplName() SAL_OVERRIDE;
virtual css::uno::Sequence<OUString> getServiceNames() SAL_OVERRIDE;
virtual void setAsMSObehavior();
void setAsMSObehavior();
sal_Int32 getMargin( const OUString& sMarginType );
void setMargin( const OUString& sMarginType, float fMargin );
public: