loplugin: unnecessary destructor forms..idlc

Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054
Reviewed-on: https://gerrit.libreoffice.org/33492
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

forms/source/xforms/NameContainer.hxx

@@ -78,7 +78,6 @@ protected:
 public:
 
     NameContainer() {}
-    virtual ~NameContainer() override {}
 
 
     // methods for XElementAccess

forms/source/xforms/collection.hxx

@@ -61,7 +61,6 @@ protected:
 public:
 
     Collection() {}
-    virtual ~Collection() override {}
 
     const T& getItem( sal_Int32 n ) const
     {

forms/source/xforms/model_helper.hxx

@@ -53,7 +53,6 @@ class BindingCollection : public NamedCollection<css::uno::Reference<css::beans:
 
 public:
     explicit BindingCollection( Model* pModel ) : mpModel( pModel ) {}
-    virtual ~BindingCollection() override {}
 
     virtual bool isValid( const T& t ) const override
     {
@@ -80,9 +79,7 @@ class SubmissionCollection : public NamedCollection<css::uno::Reference<css::bea
 
 public:
     explicit SubmissionCollection( Model* pModel ) : mpModel( pModel ) {}
-    virtual ~SubmissionCollection() override {}
 
-public:
     virtual bool isValid( const T& t ) const override
     {
         return Submission::getSubmission( t ) != nullptr;

forms/source/xforms/namedcollection.hxx

@@ -37,7 +37,6 @@ class NamedCollection : public cppu::ImplInheritanceHelper<
 
 public:
     NamedCollection() {}
-    virtual ~NamedCollection() {}
 
     const T& getItem( const OUString& rName ) const
     {

forms/source/xforms/xformsevent.hxx

@@ -40,7 +40,6 @@ class XFormsEventConcrete : public cppu::WeakImplHelper< XFormsEvent > {
             , m_cancelable(false)
         {
         }
-        virtual ~XFormsEventConcrete() override {}
 
         virtual OUString SAL_CALL getType() throw (css::uno::RuntimeException, std::exception) override;
         virtual css::uno::Reference< css::xml::dom::events::XEventTarget > SAL_CALL getTarget() throw (css::uno::RuntimeException, std::exception) override;

formula/source/ui/dlg/ControlHelper.hxx

@@ -104,8 +104,6 @@ public:
 
     ArgInput();
 
-    ~ArgInput() {}
-
     void        InitArgInput (  FixedText*      pftArg,
                                 PushButton*    pbtnFx,
                                 ArgEdit*        pedArg,

formula/source/ui/resource/ModuleHelper.cxx

@@ -48,7 +48,6 @@ class OModuleImpl
 public:
     /// ctor
     OModuleImpl();
-    ~OModuleImpl();
 
     /// get the manager for the resources of the module
     ResMgr* getResManager();
@@ -59,11 +58,6 @@ OModuleImpl::OModuleImpl()
 }
 
 
-OModuleImpl::~OModuleImpl()
-{
-}
-
-
 ResMgr* OModuleImpl::getResManager()
 {
     // note that this method is not threadsafe, which counts for the whole class !

framework/inc/helper/mischelper.hxx

@@ -153,10 +153,6 @@ class WeakContainerListener : public ::cppu::WeakImplHelper<css::container::XCon
         {
         }
 
-        virtual ~WeakContainerListener() override
-        {
-        }
-
         // container.XContainerListener
         virtual void SAL_CALL elementInserted(const css::container::ContainerEvent& rEvent)
             throw(css::uno::RuntimeException, std::exception) override
@@ -208,10 +204,6 @@ class WeakChangesListener : public ::cppu::WeakImplHelper<css::util::XChangesLis
         {
         }
 
-        virtual ~WeakChangesListener() override
-        {
-        }
-
         // util.XChangesListener
         virtual void SAL_CALL changesOccurred(const css::util::ChangesEvent& rEvent)
             throw(css::uno::RuntimeException, std::exception) override
@@ -245,10 +237,6 @@ class WeakDocumentEventListener : public ::cppu::WeakImplHelper<css::document::X
         {
         }
 
-        virtual ~WeakDocumentEventListener() override
-        {
-        }
-
         virtual void SAL_CALL documentEventOccured(const css::document::DocumentEvent& rEvent)
             throw(css::uno::RuntimeException, std::exception) override
         {

framework/inc/xml/imagesconfiguration.hxx

@@ -62,8 +62,6 @@ struct ImageListItemDescriptor
 {
     ImageListItemDescriptor() : nMaskMode( ImageMaskMode_Color ) {}
 
-    ~ImageListItemDescriptor() {}
-
     OUString                    aURL;               // an URL to a bitmap with several images inside
     Color                       aMaskColor;         // a color used as transparent
     OUString                    aMaskURL;           // an URL to an optional bitmap used as a mask

framework/source/accelerators/presethandler.cxx

@@ -63,8 +63,6 @@ struct TSharedStorages final
             : m_lStoragesShare()
             , m_lStoragesUser ()
         {};
-
-        ~TSharedStorages() {};
 };
 
 /** @short  provides access to the:

framework/source/inc/dispatch/dispatchdisabler.hxx

@@ -46,7 +46,6 @@ class DispatchDisabler : public ::cppu::WeakImplHelper<
     css::uno::Reference< css::frame::XDispatchProvider > mxMaster;
 public:
              DispatchDisabler(const css::uno::Reference< css::uno::XComponentContext >& rxContext);
-    virtual ~DispatchDisabler() override {}
 
     // XInitialization
     virtual void SAL_CALL initialize( const ::css::uno::Sequence< ::css::uno::Any >& aArguments )

framework/source/inc/loadenv/loadenvexception.hxx

@@ -83,8 +83,6 @@ class LoadEnvException
             css::uno::Any const & original = css::uno::Any()):
             m_nID(id), m_sMessage(message), m_exOriginal(original)
         {}
-
-        ~LoadEnvException() {}
 };
 
 } // namespace framework

framework/source/layoutmanager/layoutmanager.cxx

@@ -3132,9 +3132,6 @@ namespace detail
             rManager.describeProperties(aProperties);
             m_pInfoHelper.reset( new ::cppu::OPropertyArrayHelper(aProperties, true) );
         }
-        ~InfoHelperBuilder()
-        {
-        }
         InfoHelperBuilder(const InfoHelperBuilder&) = delete;
         InfoHelperBuilder& operator=(const InfoHelperBuilder&) = delete;
 

helpcompiler/inc/BasCodeTagger.hxx

@@ -54,7 +54,6 @@ class L10N_DLLPUBLIC LibXmlTreeWalker
 
   public:
     LibXmlTreeWalker( xmlDocPtr doc );
-    ~LibXmlTreeWalker() {}
     void nextNode();
     xmlNodePtr currentNode() { return m_pCurrentNode;}
     bool end();

helpcompiler/inc/HelpLinker.hxx

@@ -60,9 +60,6 @@ public:
         , m_bUseLangRoot(true)
         , m_bCreateIndex(true)
     {}
-    ~HelpLinker()
-    {
-    }
 
 private:
     Stringtable additionalFiles;

hwpfilter/source/formula.h

@@ -36,7 +36,6 @@ public:
         eq = _eq;
         trim();
     }
-    ~Formula(){ }
 
     void setDocumentHandler(Reference < XDocumentHandler > const & xHandler )
     {

hwpfilter/source/hbox.h

@@ -394,7 +394,6 @@ struct Columns
           nTotal = INIT_SIZE;
           data.reset(new int[nTotal]);
      }
-     ~Columns() {}
 
      void AddColumnsSize(){
           if (nTotal + ADD_AMOUNT < nTotal) // overflow
@@ -454,7 +453,6 @@ struct Rows
           nTotal = INIT_SIZE;
           data.reset( new int[nTotal] );
      }
-     ~Rows() {}
 
      void AddRowsSize(){
           if (nTotal + ADD_AMOUNT < nTotal) // overflow

i18npool/source/search/levdis.hxx

@@ -122,7 +122,6 @@ public:
     {
         NewMem(s);
     }
-    ~WLevDisDistanceMem()           {}
     int* GetPtr() const             { return p.get(); }
     int* NewMem( size_t s )
     {

idlc/inc/astattribute.hxx

@@ -41,7 +41,6 @@ public:
         , m_flags(flags)
         , m_pType(pType)
         {}
-    virtual ~AstAttribute() override {}
 
     void setExceptions(
         OUString const * getDoc, DeclList const * getExc,

idlc/inc/astbasetype.hxx

@@ -31,8 +31,6 @@ public:
         , m_exprType(type)
         {}
 
-    virtual ~AstBaseType() override {}
-
     virtual bool isUnsigned() const override {
         switch (m_exprType) {
         case ET_ushort:

idlc/inc/astconstants.hxx

@@ -27,7 +27,6 @@ public:
     AstConstants(const OString& name, AstScope* pScope)
         : AstModule(NT_constants, name, pScope)
     {}
-    virtual ~AstConstants() override {}
 };
 
 #endif // INCLUDED_IDLC_INC_ASTCONSTANTS_HXX

idlc/inc/astexception.hxx

@@ -27,8 +27,6 @@ public:
     AstException(const OString& name, AstException* pBaseType, AstScope* pScope)
         : AstStruct(NT_exception, name, pBaseType, pScope)
         {}
-
-    virtual ~AstException() override {}
 };
 
 #endif // INCLUDED_IDLC_INC_ASTEXCEPTION_HXX

idlc/inc/astinterfacemember.hxx

@@ -30,7 +30,6 @@ public:
         , m_flags(flags)
         , m_pRealInterface(pRealInterface)
         {}
-    virtual ~AstInterfaceMember() override {}
 
     AstInterface* getRealInterface()
         { return m_pRealInterface; }

idlc/inc/astmember.hxx

@@ -31,8 +31,6 @@ public:
         AstType const * pType, OString const & name, AstScope * pScope):
         AstDeclaration(NT_member, name, pScope), m_pType(pType) {}
 
-    virtual ~AstMember() override {}
-
     AstType const * getType() const { return m_pType; }
 
 protected:

idlc/inc/astmodule.hxx

@@ -34,7 +34,6 @@ public:
         : AstDeclaration(type, name, pScope)
         , AstScope(type)
     {}
-    virtual ~AstModule() override {}
 
     virtual bool dump(RegistryKey& rKey) override;
 };

idlc/inc/astneeds.hxx

@@ -28,7 +28,6 @@ public:
         : AstDeclaration(NT_needs, name, pScope)
         , m_pRealService(pRealService)
         {}
-    virtual ~AstNeeds() override {}
 
     AstService* getRealService()
         { return m_pRealService; }

idlc/inc/astobserves.hxx

@@ -28,7 +28,6 @@ public:
         : AstDeclaration(NT_observes, name, pScope)
         , m_pRealInterface(pRealInterface)
         {}
-    virtual ~AstObserves() override {}
 
     AstInterface* getRealInterface()
         { return m_pRealInterface; }

idlc/inc/astoperation.hxx

@@ -35,7 +35,6 @@ public:
         , AstScope(NT_operation)
         , m_pReturnType(pReturnType)
         {}
-    virtual ~AstOperation() override {}
 
     bool isVariadic() const;
 

idlc/inc/astparameter.hxx

@@ -32,8 +32,6 @@ public:
         AstMember(NT_parameter, type, name, scope), m_direction(direction),
         m_rest(rest) {}
 
-    virtual ~AstParameter() override {}
-
     Direction getDirection() const { return m_direction; }
 
     bool isRest() const { return m_rest; }

idlc/inc/astservice.hxx

@@ -38,7 +38,6 @@ public:
         , m_singleInterfaceBasedService(false)
         , m_defaultConstructor(false)
         {}
-    virtual ~AstService() override {}
 
     virtual bool dump(RegistryKey& rKey) override;
 

idlc/inc/astservicemember.hxx

@@ -30,7 +30,6 @@ public:
         , m_flags(flags)
         , m_pRealService(pRealService)
         {}
-    virtual ~AstServiceMember() override {}
 
     AstService* getRealService()
         { return m_pRealService; }

idlc/inc/asttype.hxx

@@ -28,8 +28,6 @@ public:
         : AstDeclaration(type, name, pScope)
         {}
 
-    virtual ~AstType() override {}
-
     virtual bool isUnsigned() const { return false; }
 };
 

idlc/inc/asttypedef.hxx

@@ -28,8 +28,6 @@ public:
         AstType const * baseType, OString const & name, AstScope * scope):
         AstType(NT_typedef, name, scope), m_pBaseType(baseType) {}
 
-    virtual ~AstTypeDef() override {}
-
     AstType const * getBaseType() const
         { return m_pBaseType; }