mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tdf#90994 The accessible name should not contain the accessible role

Browse Source 
The accessible role (PANEL) is added as a prefix to the title bar
in the sidebar. That is redundant and can even make things confusing
for the users of screen-readers.

Change-Id: I743defa0b1b9f3f278d0cabc7196054796fb3c47
Reviewed-on: https://gerrit.libreoffice.org/15636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Niklas Johansson
2015-05-05 13:52:15 +02:00
committed by Caolán McNamara
parent 0fc79344ce
commit b4d7f82484
4 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sfx2/source/sidebar/PanelTitleBar.cxx
View File

@@ -48,8 +48,7 @@ PanelTitleBar::PanelTitleBar (
mpPanel(pPanel), mpPanel(pPanel),
mnMenuItemIndex(1), mnMenuItemIndex(1),
mxFrame(), mxFrame(),
msMoreOptionsCommand(), msMoreOptionsCommand()
msAccessibleNamePrefix(SFX2_RESSTR(SFX_STR_SIDEBAR_ACCESSIBILITY_PANEL_PREFIX))
{ {
OSL_ASSERT(mpPanel != nullptr); OSL_ASSERT(mpPanel != nullptr);
@@ -168,9 +167,8 @@ void PanelTitleBar::HandleToolBoxItemClick (const sal_uInt16 nItemIndex)
Reference<accessibility::XAccessible> PanelTitleBar::CreateAccessible() Reference<accessibility::XAccessible> PanelTitleBar::CreateAccessible()
{ {
const ::rtl::OUString sAccessibleName(msAccessibleNamePrefix + msTitle); SetAccessibleName(msTitle);
SetAccessibleName(sAccessibleName); SetAccessibleDescription(msTitle);
SetAccessibleDescription(sAccessibleName);
return TitleBar::CreateAccessible(); return TitleBar::CreateAccessible();
} }

1
sfx2/source/sidebar/PanelTitleBar.hxx
View File

@@ -61,7 +61,6 @@ private:
const sal_uInt16 mnMenuItemIndex; const sal_uInt16 mnMenuItemIndex;
css::uno::Reference<css::frame::XFrame> mxFrame; css::uno::Reference<css::frame::XFrame> mxFrame;
::rtl::OUString msMoreOptionsCommand; ::rtl::OUString msMoreOptionsCommand;
::rtl::OUString msAccessibleNamePrefix;
}; };
} } // end of namespace sfx2::sidebar } } // end of namespace sfx2::sidebar

1
sfx2/source/sidebar/Sidebar.hrc
View File

@@ -56,6 +56,5 @@
#define SFX_STR_SIDEBAR_MORE_OPTIONS (RID_SFX_SIDEBAR_START + 1) #define SFX_STR_SIDEBAR_MORE_OPTIONS (RID_SFX_SIDEBAR_START + 1)
#define SFX_STR_SIDEBAR_CLOSE_DECK (RID_SFX_SIDEBAR_START + 2) #define SFX_STR_SIDEBAR_CLOSE_DECK (RID_SFX_SIDEBAR_START + 2)
#define SFX_STR_SIDEBAR_ACCESSIBILITY_PANEL_PREFIX (RID_SFX_SIDEBAR_START + 3)
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

4
sfx2/source/sidebar/Sidebar.src
View File

@@ -170,9 +170,5 @@ String SFX_STR_SIDEBAR_CLOSE_DECK
Text [en-US] = "Close Sidebar Deck"; Text [en-US] = "Close Sidebar Deck";
}; };
String SFX_STR_SIDEBAR_ACCESSIBILITY_PANEL_PREFIX
{
Text [en-US] = "Panel: ";
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */