From b98cb40d974d40d131b6b25f96e9c53890154296 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 17 Oct 2019 15:42:13 +0200 Subject: [PATCH] loplugin:virtualdead unused param in ValueGetter::processValue Change-Id: Id2b514b0892f8d7cf93fe3c5884e8d89a6f0a7b1 Reviewed-on: https://gerrit.libreoffice.org/81076 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../clang/virtualdead.unusedparams.results | 3 --- sc/source/ui/vba/vbarange.cxx | 12 ++++++------ sc/source/ui/vba/vbarange.hxx | 2 +- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results index ef8a78956ccb..3ac03d4acaa3 100644 --- a/compilerplugins/clang/virtualdead.unusedparams.results +++ b/compilerplugins/clang/virtualdead.unusedparams.results @@ -238,9 +238,6 @@ sc/inc/formulagroup.hxx:145 sc/source/core/opencl/formulagroupcl.cxx:1059 void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream &,) 0 -sc/source/ui/vba/vbarange.hxx:68 - void ValueGetter::processValue(int,int,const class com::sun::star::uno::Any &,) - 001 sdext/source/pdfimport/inc/contentsink.hxx:150 void pdfi::ContentSink::drawMask(const class com::sun::star::uno::Sequence &,_Bool,) 10 diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index f3b5480e1420..311cb9c1fc22 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -772,17 +772,17 @@ protected: public: CellValueGetter() {} virtual void visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) override; - virtual void processValue( sal_Int32 x, sal_Int32 y, const uno::Any& aValue ) override; + virtual void processValue( const uno::Any& aValue ) override; const uno::Any& getValue() const override { return maValue; } }; void -CellValueGetter::processValue( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Any& aValue ) +CellValueGetter::processValue( const uno::Any& aValue ) { maValue = aValue; } -void CellValueGetter::visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) +void CellValueGetter::visitNode( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Reference< table::XCell >& xCell ) { uno::Any aValue; table::CellContentType eType = xCell->getType(); @@ -830,7 +830,7 @@ void CellValueGetter::visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< uno::Reference< text::XTextRange > xTextRange(xCell, ::uno::UNO_QUERY_THROW); aValue <<= xTextRange->getString(); } - processValue( x,y,aValue ); + processValue( aValue ); } class CellFormulaValueSetter : public CellValueSetter @@ -889,7 +889,7 @@ private: formula::FormulaGrammar::Grammar const m_eGrammar; public: CellFormulaValueGetter(ScDocument* pDoc, formula::FormulaGrammar::Grammar eGram ) : CellValueGetter( ), m_pDoc( pDoc ), m_eGrammar( eGram ) {} - virtual void visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) override + virtual void visitNode( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Reference< table::XCell >& xCell ) override { uno::Any aValue; aValue <<= xCell->getFormula(); @@ -911,7 +911,7 @@ public: aValue <<= sVal; } - processValue( x,y,aValue ); + processValue( aValue ); } }; diff --git a/sc/source/ui/vba/vbarange.hxx b/sc/source/ui/vba/vbarange.hxx index 7a9b1b21b1d8..9cc7f6ded196 100644 --- a/sc/source/ui/vba/vbarange.hxx +++ b/sc/source/ui/vba/vbarange.hxx @@ -65,7 +65,7 @@ class ValueGetter : public ArrayVisitor { public: - virtual void processValue( sal_Int32 x, sal_Int32 y, const css::uno::Any& aValue ) = 0; + virtual void processValue( const css::uno::Any& aValue ) = 0; virtual const css::uno::Any& getValue() const = 0; };