mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disable the 'two different log areas in the same file' loplugin check

Browse Source 
too many false+ to leave it alive by default

Change-Id: I6d8f92b630c351c1ac788fad79f8d7c435ba4963
This commit is contained in:
Noel Grandin
2016-12-15 14:11:16 +02:00
parent 8ad521d914
commit bd6723fd53
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/sallogareas.cxx
View File

@@ -110,6 +110,8 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location )
checkAreaSyntax(area, location); checkAreaSyntax(area, location);
return; return;
} }
// don't leave this alive by default, generates too many false+
#if 0
if (compiler.getSourceManager().isInMainFile(location)) if (compiler.getSourceManager().isInMainFile(location))
{ {
auto matchpair = [this,area](StringRef p1, StringRef p2) { auto matchpair = [this,area](StringRef p1, StringRef p2) {
@@ -166,6 +168,7 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location )
firstSeenLocation ); firstSeenLocation );
} }
} }
#endif
} }
void SalLogAreas::checkAreaSyntax(StringRef area, SourceLocation location) { void SalLogAreas::checkAreaSyntax(StringRef area, SourceLocation location) {

2
compilerplugins/clang/sallogareas.hxx
View File

@@ -35,8 +35,10 @@ class SalLogAreas
const FunctionDecl* inFunction; const FunctionDecl* inFunction;
SourceLocation lastSalDetailLogStreamMacro; SourceLocation lastSalDetailLogStreamMacro;
set< string > logAreas; set< string > logAreas;
#if 0
string firstSeenLogArea; string firstSeenLogArea;
SourceLocation firstSeenLocation; SourceLocation firstSeenLocation;
#endif
}; };
} // namespace } // namespace