mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve warning message in passstringbyref compiler plugin

Browse Source 
Change-Id: Ia8470bbd04c841e6c44c182493fede3dc312f635
This commit is contained in:
Noel Grandin
2014-03-19 08:57:07 +02:00
parent 96710f8e46
commit be878d7cc5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
compilerplugins/clang/passstringbyref.cxx
View File

@@ -49,14 +49,14 @@ bool PassStringByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) {
if (typeName == "class rtl::OUString") { if (typeName == "class rtl::OUString") {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"passing OUString by value, rather pass by reference", "passing OUString by value, rather pass by reference .e.g. 'const OUString&'",
pvDecl->getSourceRange().getBegin()) pvDecl->getSourceRange().getBegin())
<< pvDecl->getSourceRange(); << pvDecl->getSourceRange();
} }
else if (typeName == "class rtl::OString") { else if (typeName == "class rtl::OString") {
report( report(
DiagnosticsEngine::Warning, DiagnosticsEngine::Warning,
"passing OString by value, rather pass by reference", "passing OString by value, rather pass by reference .e.g. 'const OString&'",
pvDecl->getSourceRange().getBegin()) pvDecl->getSourceRange().getBegin())
<< pvDecl->getSourceRange(); << pvDecl->getSourceRange();
} }