mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-tidy performance-unnecessary-value-param in svl

Browse Source 
Change-Id: I8abc272d12e62e25be358dc4c73008971f1cd609
This commit is contained in:
Noel Grandin 2016-04-11 10:07:25 +02:00
parent 9f877f6773
commit bfff081e74
10 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/svl/IndexedStyleSheets.hxx
View File

@ -86,15 +86,15 @@ public:
* If the style sheet is already contained, this call has no effect. * If the style sheet is already contained, this call has no effect.
*/ */
void void
AddStyleSheet(rtl::Reference< SfxStyleSheetBase > style); AddStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style);
/** Removes a style sheet. */ /** Removes a style sheet. */
bool bool
RemoveStyleSheet(rtl::Reference< SfxStyleSheetBase > style); RemoveStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style);
/** Check whether a specified style sheet is stored. */ /** Check whether a specified style sheet is stored. */
bool bool
HasStyleSheet(rtl::Reference< SfxStyleSheetBase > style) const; HasStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style) const;
/** Obtain the number of style sheets which are held */ /** Obtain the number of style sheets which are held */
unsigned unsigned

2
include/svl/currencytable.hxx
View File

@ -36,7 +36,7 @@ public:
size_t size() const; size_t size() const;
void insert(iterator it, std::unique_ptr<NfCurrencyEntry> p); void insert(const iterator& it, std::unique_ptr<NfCurrencyEntry> p);
}; };
#endif #endif

2
include/svl/documentlockfile.hxx
View File

@ -39,7 +39,7 @@ class SVL_DLLPUBLIC DocumentLockFile : public LockFileCommon
css::uno::Reference< css::io::XInputStream > OpenStream(); css::uno::Reference< css::io::XInputStream > OpenStream();
void WriteEntryToStream( const LockFileEntry& aEntry, css::uno::Reference< css::io::XOutputStream > xStream ); void WriteEntryToStream( const LockFileEntry& aEntry, const css::uno::Reference< css::io::XOutputStream >& xStream );
public: public:
DocumentLockFile( const OUString& aOrigURL ); DocumentLockFile( const OUString& aOrigURL );

2
include/svl/style.hxx
View File

@ -208,7 +208,7 @@ protected:
virtual ~SfxStyleSheetBasePool(); virtual ~SfxStyleSheetBasePool();
void StoreStyleSheet(rtl::Reference< SfxStyleSheetBase >); void StoreStyleSheet(const rtl::Reference< SfxStyleSheetBase >&);
/** Obtain the indexed style sheets. /** Obtain the indexed style sheets.
*/ */

2
include/svl/stylepool.hxx
View File

@ -69,7 +69,7 @@ public:
virtual ~StylePool(); virtual ~StylePool();
static OUString nameOf( SfxItemSet_Pointer_t pSet ); static OUString nameOf( const SfxItemSet_Pointer_t& pSet );
}; };
class SVL_DLLPUBLIC IStylePoolIteratorAccess class SVL_DLLPUBLIC IStylePoolIteratorAccess

6
svl/source/items/IndexedStyleSheets.cxx
View File

@ -86,7 +86,7 @@ IndexedStyleSheets::GetNumberOfStyleSheets() const
} }
void void
IndexedStyleSheets::AddStyleSheet(rtl::Reference< SfxStyleSheetBase > style) IndexedStyleSheets::AddStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style)
{ {
if (!HasStyleSheet(style)) { if (!HasStyleSheet(style)) {
mStyleSheets.push_back(style); mStyleSheets.push_back(style);
@ -96,7 +96,7 @@ IndexedStyleSheets::AddStyleSheet(rtl::Reference< SfxStyleSheetBase > style)
} }
bool bool
IndexedStyleSheets::RemoveStyleSheet(rtl::Reference< SfxStyleSheetBase > style) IndexedStyleSheets::RemoveStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style)
{ {
rtl::OUString styleName = style->GetName(); rtl::OUString styleName = style->GetName();
std::vector<unsigned> positions = FindPositionsByName(styleName); std::vector<unsigned> positions = FindPositionsByName(styleName);
@ -207,7 +207,7 @@ IndexedStyleSheets::~IndexedStyleSheets()
{;} {;}
bool bool
IndexedStyleSheets::HasStyleSheet(rtl::Reference< SfxStyleSheetBase > style) const IndexedStyleSheets::HasStyleSheet(const rtl::Reference< SfxStyleSheetBase >& style) const
{ {
rtl::OUString styleName = style->GetName(); rtl::OUString styleName = style->GetName();
std::vector<unsigned> positions = FindPositionsByName(styleName); std::vector<unsigned> positions = FindPositionsByName(styleName);

2
svl/source/items/style.cxx
View File

@ -965,7 +965,7 @@ SfxUnoStyleSheet* SfxUnoStyleSheet::getUnoStyleSheet( const css::uno::Reference<
} }
void void
SfxStyleSheetBasePool::StoreStyleSheet(rtl::Reference< SfxStyleSheetBase > xStyle) SfxStyleSheetBasePool::StoreStyleSheet(const rtl::Reference< SfxStyleSheetBase >& xStyle)
{ {
pImp->mxIndexedStyleSheets->AddStyleSheet(xStyle); pImp->mxIndexedStyleSheets->AddStyleSheet(xStyle);
} }

2
svl/source/items/stylepool.cxx
View File

@ -332,7 +332,7 @@ namespace {
* This static method creates a unique name from a shared pointer to a SfxItemSet * This static method creates a unique name from a shared pointer to a SfxItemSet
* The name is the memory address of the SfxItemSet itself. * The name is the memory address of the SfxItemSet itself.
*/ */
OUString StylePool::nameOf( SfxItemSet_Pointer_t pSet ) OUString StylePool::nameOf( const SfxItemSet_Pointer_t& pSet )
{ {
return OUString::number( reinterpret_cast<sal_IntPtr>( pSet.get() ), 16 ); return OUString::number( reinterpret_cast<sal_IntPtr>( pSet.get() ), 16 );
} }

2
svl/source/misc/documentlockfile.cxx
View File

@ -63,7 +63,7 @@ DocumentLockFile::~DocumentLockFile()
} }
void DocumentLockFile::WriteEntryToStream( const LockFileEntry& aEntry, uno::Reference< io::XOutputStream > xOutput ) void DocumentLockFile::WriteEntryToStream( const LockFileEntry& aEntry, const uno::Reference< io::XOutputStream >& xOutput )
{ {
::osl::MutexGuard aGuard( m_aMutex ); ::osl::MutexGuard aGuard( m_aMutex );

2
svl/source/numbers/currencytable.cxx
View File

@ -29,7 +29,7 @@ size_t NfCurrencyTable::size() const
return maData.size(); return maData.size();
} }
void NfCurrencyTable::insert(iterator it, std::unique_ptr<NfCurrencyEntry> p) void NfCurrencyTable::insert(const iterator& it, std::unique_ptr<NfCurrencyEntry> p)
{ {
maData.insert(it, std::move(p)); maData.insert(it, std::move(p));
} }