mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1371219 Missing move assignment operator

Browse Source 
Change-Id: I72ed6082b561079b45e82d8258fa1abbe23117e2
Reviewed-on: https://gerrit.libreoffice.org/29228
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara 2016-09-23 11:59:16 +01:00
parent 3de2567853
commit c136c97875
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pyuno/inc/pyuno.hxx
View File

@ -101,7 +101,8 @@ public:
throw std::bad_alloc();
}
PyRef( const PyRef &r ) : m( r.get() ) { Py_XINCREF( m ); }
PyRef(const PyRef &r) : m(r.get()) { Py_XINCREF(m); }
PyRef(PyRef &&r) : m(r.get()) { r.scratch(); }
~PyRef() { Py_XDECREF( m ); }
@ -113,11 +114,20 @@ public:
return m;
}
PyRef & operator = ( const PyRef & r )
PyRef& operator=(const PyRef& r)
{
PyObject *tmp = m;
m = r.getAcquired();
Py_XDECREF( tmp );
Py_XDECREF(tmp);
return *this;
}
PyRef& operator=(PyRef&& r)
{
PyObject *tmp = m;
m = r.get();
r.scratch();
Py_XDECREF(tmp);
return *this;
}