loplugin:unusedfields

Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0
Reviewed-on: https://gerrit.libreoffice.org/34513
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2017-02-21 13:10:45 +02:00
parent f0c7cbe1d8
commit c1877a16b3
10 changed files with 14 additions and 44 deletions

View File

@ -49,8 +49,6 @@ public:
private:
struct ValueSetWithTextItem
{
Image maItemImage;
Image maSelectedItemImage;
OUString maItemText;
OUString maItemText2;
};

View File

@ -969,8 +969,7 @@ static gboolean postDocumentLoad(gpointer pData)
// Total number of columns in this document.
guint nColumns = ceil((double)nDocumentWidthPixels / nTileSizePixels);
priv->m_pTileBuffer = std::unique_ptr<TileBuffer>(new TileBuffer(priv->m_pDocument,
nColumns));
priv->m_pTileBuffer = std::unique_ptr<TileBuffer>(new TileBuffer(nColumns));
gtk_widget_set_size_request(GTK_WIDGET(pLOKDocView),
nDocumentWidthPixels,
nDocumentHeightPixels);
@ -3289,8 +3288,7 @@ lok_doc_view_set_zoom (LOKDocView* pDocView, float fZoom)
// Total number of columns in this document.
guint nColumns = ceil((double)nDocumentWidthPixels / nTileSizePixels);
priv->m_pTileBuffer = std::unique_ptr<TileBuffer>(new TileBuffer(priv->m_pDocument,
nColumns));
priv->m_pTileBuffer = std::unique_ptr<TileBuffer>(new TileBuffer(nColumns));
gtk_widget_set_size_request(GTK_WIDGET(pDocView),
nDocumentWidthPixels,
nDocumentHeightPixels);

View File

@ -90,10 +90,8 @@ private:
class TileBuffer
{
public:
TileBuffer(LibreOfficeKitDocument *document = nullptr,
int columns = 0)
: m_pLOKDocument(document)
, m_nWidth(columns)
TileBuffer(int columns = 0)
: m_nWidth(columns)
{
cairo_surface_t *pSurface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, nTileSizePixels, nTileSizePixels);
m_DummyTile.setSurface(pSurface);
@ -135,8 +133,6 @@ class TileBuffer
*/
void setInvalid(int x, int y, float zoom, GTask* task, GThreadPool*);
/// Contains the reference to the LOK Document that this tile buffer is for.
LibreOfficeKitDocument *m_pLOKDocument;
/// Stores all the tiles cached by this tile buffer.
std::map<int, Tile> m_mTiles;
/// Width of the current tile buffer (number of columns)

View File

@ -174,19 +174,17 @@ struct XmlFilterBaseImpl
{
typedef RefMap< OUString, Relations > RelationsMap;
Reference<XComponentContext> mxContext;
FastParser maFastParser;
const OUString maBinSuffix;
RelationsMap maRelationsMap;
TextFieldStack maTextFieldStack;
const NamespaceMap& mrNamespaceMap;
const NamespaceMap& mrNamespaceMap;
/// @throws RuntimeException
explicit XmlFilterBaseImpl( const Reference< XComponentContext >& rxContext );
explicit XmlFilterBaseImpl();
};
XmlFilterBaseImpl::XmlFilterBaseImpl( const Reference< XComponentContext >& rxContext ) :
mxContext(rxContext),
XmlFilterBaseImpl::XmlFilterBaseImpl() :
maBinSuffix( ".bin" ),
mrNamespaceMap(StaticNamespaceMap::get())
{
@ -196,7 +194,7 @@ XmlFilterBaseImpl::XmlFilterBaseImpl( const Reference< XComponentContext >& rxCo
XmlFilterBase::XmlFilterBase( const Reference< XComponentContext >& rxContext ) :
FilterBase( rxContext ),
mxImpl( new XmlFilterBaseImpl( rxContext ) ),
mxImpl( new XmlFilterBaseImpl ),
mnRelId( 1 ),
mnMaxDocId( 0 ),
mbMSO2007(false),

View File

@ -246,12 +246,6 @@ private:
*/
bool mbFoundObject;
/** When set to <TRUE/> this flag indicates that an error has occurred
that should terminate the iteration over the objects to search/spell
check.
*/
bool mbError;
/** This flag indicates whether to search forward or backwards.
*/
bool mbDirectionIsForward;

View File

@ -155,7 +155,6 @@ SdOutliner::SdOutliner( SdDrawDocument* pDoc, OutlinerMode nMode )
mnPageCount(0),
mbEndOfSearch(false),
mbFoundObject(false),
mbError(false),
mbDirectionIsForward(true),
mbRestrictSearchToSelection(false),
maMarkListCopy(),

View File

@ -25,17 +25,9 @@
namespace sw
{
enum class UnoCursorHintType
{
DOC_DISPOSING,
LEAVES_SECTION
};
struct SW_DLLPUBLIC UnoCursorHint final : public SfxHint
{
UnoCursorHintType m_eType;
UnoCursorHint(UnoCursorHintType eType)
: m_eType(eType) {};
UnoCursorHint() {}
virtual ~UnoCursorHint() override;
};
}

View File

@ -159,7 +159,7 @@ void PaMCorrAbs( const SwPaM& rRange,
if (bChange && bLeaveSection)
{
// the UNO cursor has left its section. We need to notify it!
sw::UnoCursorHint aHint(sw::UnoCursorHintType::LEAVES_SECTION);
sw::UnoCursorHint aHint;
pUnoCursor->m_aNotifier.Broadcast(aHint);
}
}

View File

@ -414,7 +414,7 @@ SwDoc::~SwDoc()
getIDocumentRedlineAccess().GetRedlineTable().DeleteAndDestroyAll();
getIDocumentRedlineAccess().GetExtraRedlineTable().DeleteAndDestroyAll();
const sw::UnoCursorHint aHint(sw::UnoCursorHintType::DOC_DISPOSING);
const sw::UnoCursorHint aHint;
cleanupUnoCursorTable();
for(const auto& pWeakCursor : mvUnoCursorTable)
{

View File

@ -320,15 +320,12 @@ class ExtendedAttributes :
OUString * m_pQNames;
OUString * m_pValues;
rtl::Reference<DocumentHandlerImpl> m_xHandler;
public:
inline ExtendedAttributes(
sal_Int32 nAttributes,
sal_Int32 * pUids,
OUString * pLocalNames, OUString * pQNames,
Reference< xml::sax::XAttributeList > const & xAttributeList,
DocumentHandlerImpl * pHandler );
Reference< xml::sax::XAttributeList > const & xAttributeList );
virtual ~ExtendedAttributes() throw () override;
// XAttributes
@ -355,14 +352,12 @@ inline ExtendedAttributes::ExtendedAttributes(
sal_Int32 nAttributes,
sal_Int32 * pUids,
OUString * pLocalNames, OUString * pQNames,
Reference< xml::sax::XAttributeList > const & xAttributeList,
DocumentHandlerImpl * pHandler )
Reference< xml::sax::XAttributeList > const & xAttributeList )
: m_nAttributes( nAttributes )
, m_pUids( pUids )
, m_pLocalNames( pLocalNames )
, m_pQNames( pQNames )
, m_pValues( new OUString[ nAttributes ] )
, m_xHandler( pHandler )
{
for ( sal_Int32 nPos = 0; nPos < nAttributes; ++nPos )
{
@ -542,7 +537,7 @@ void DocumentHandlerImpl::startElement(
xAttributes = static_cast< xml::input::XAttributes * >(
new ExtendedAttributes(
nAttribs, pUids, pLocalNames, pQNames,
xAttribs, this ) );
xAttribs ) );
getElementName( rQElementName, &nUid, &aLocalName );