mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead in dbaccess

Browse Source 
Change-Id: I030283816185f42f9012c8dfb2d745164abd7234
Reviewed-on: https://gerrit.libreoffice.org/79644
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-09-26 13:47:08 +02:00
parent 616d47dbbe
commit c1e31ee043
5 changed files with 1 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.results
View File

@@ -13,9 +13,6 @@ chart2/source/controller/dialogs/ChartTypeDialogController.hxx:99
chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx:30 chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx:30
void chart::sidebar::ChartSidebarSelectionListenerParent::SelectionInvalid() void chart::sidebar::ChartSidebarSelectionListenerParent::SelectionInvalid()
empty empty
dbaccess/source/ui/inc/IUpdateHelper.hxx:38
void dbaui::IUpdateHelper::moveToInsertRow()
empty
desktop/source/deployment/registry/inc/dp_backenddb.hxx:119 desktop/source/deployment/registry/inc/dp_backenddb.hxx:119
class rtl::OUString dp_registry::backend::BackendDb::getDbNSName() class rtl::OUString dp_registry::backend::BackendDb::getDbNSName()
"http://openoffi "http://openoffi

1
dbaccess/source/ui/inc/IUpdateHelper.hxx
View File

@@ -35,7 +35,6 @@ namespace dbaui
virtual void updateDate(sal_Int32 _nPos,const css::util::Date& _nValue) = 0; virtual void updateDate(sal_Int32 _nPos,const css::util::Date& _nValue) = 0;
virtual void updateTime(sal_Int32 _nPos,const css::util::Time& _nValue) = 0; virtual void updateTime(sal_Int32 _nPos,const css::util::Time& _nValue) = 0;
virtual void updateTimestamp(sal_Int32 _nPos,const css::util::DateTime& _nValue) = 0; virtual void updateTimestamp(sal_Int32 _nPos,const css::util::DateTime& _nValue) = 0;
virtual void moveToInsertRow() = 0;
virtual void insertRow() = 0; virtual void insertRow() = 0;
protected: protected:

14
dbaccess/source/ui/misc/HtmlReader.cxx
View File

@@ -156,19 +156,7 @@ void OHTMLReader::NextToken( HtmlTokenId nToken )
} }
break; break;
case HtmlTokenId::TABLEROW_ON: case HtmlTokenId::TABLEROW_ON:
if ( m_pUpdateHelper.get() ) if ( !m_pUpdateHelper.get() )
{
try
{
m_pUpdateHelper->moveToInsertRow(); // otherwise append new line
}
catch(SQLException& e)
// handling update failure
{
showErrorDialog(e);
}
}
else
m_bError = true; m_bError = true;
break; break;
case HtmlTokenId::TEXTTOKEN: case HtmlTokenId::TEXTTOKEN:

14
dbaccess/source/ui/misc/RtfReader.cxx
View File

@@ -134,31 +134,17 @@ void ORTFReader::NextToken( int nToken )
case RTF_TROWD: case RTF_TROWD:
{ {
bool bInsertRow = true;
if ( !m_xTable.is() ) // use first line as header if ( !m_xTable.is() ) // use first line as header
{ {
sal_uInt64 const nTell = rInput.Tell(); // perhaps alters position of the stream sal_uInt64 const nTell = rInput.Tell(); // perhaps alters position of the stream
m_bError = !CreateTable(nToken); m_bError = !CreateTable(nToken);
bInsertRow = m_bAppendFirstLine;
if ( m_bAppendFirstLine ) if ( m_bAppendFirstLine )
{ {
rInput.Seek(nTell); rInput.Seek(nTell);
rInput.ResetError(); rInput.ResetError();
} }
} }
if ( bInsertRow && !m_bError)
{
try
{
m_pUpdateHelper->moveToInsertRow(); // otherwise append new line
}
catch(SQLException& e)
// handling update failure
{
showErrorDialog(e);
}
}
} }
break; break;
case RTF_INTBL: case RTF_INTBL:

3
dbaccess/source/ui/misc/UpdateHelperImpl.hxx
View File

@@ -69,9 +69,6 @@ namespace dbaui
{ {
m_xParameters->setNull(_nPos,sqlType); m_xParameters->setNull(_nPos,sqlType);
} }
virtual void moveToInsertRow() override
{
}
virtual void insertRow() override virtual void insertRow() override
{ {
m_xPrepared->executeUpdate(); m_xPrepared->executeUpdate();