Document fishy loplugin:fakebool behavior
...as exploited in the change of LockingGuard
(extensions/source/activex/SOActiveX.cxx) in
55e596956e
"loplugin:external (clang-cl)"
Change-Id: I599ac72b68651fc733dd37c95ce9105c175fee9e
Reviewed-on: https://gerrit.libreoffice.org/83995
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
@@ -17,6 +17,20 @@ struct S {
|
|||||||
sal_Bool b; // expected-error {{FieldDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
|
sal_Bool b; // expected-error {{FieldDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
struct S2 {
|
||||||
|
sal_Bool & b_;
|
||||||
|
// The following should arguably not warn, but currently does (and does find cases that actually
|
||||||
|
// can be cleaned up; if it ever produces false warnings for cases that cannot, we need to fix
|
||||||
|
// it):
|
||||||
|
S2(sal_Bool & b): // expected-error {{ParmVarDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
|
||||||
|
b_(b) {}
|
||||||
|
};
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
struct S3 {
|
||||||
|
sal_Bool b_;
|
||||||
|
void f() { S2 s(b_); }
|
||||||
|
};
|
||||||
|
|
||||||
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
||||||
|
Reference in New Issue
Block a user