loplugin:unnecessaryvirtual

Change-Id: I5696c853daa16c9e55ff046d67102ba3042bfea8
Reviewed-on: https://gerrit.libreoffice.org/44459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unnecessaryvirtual.results

@@ -26,7 +26,9 @@ basic/source/comp/codegen.cxx:539
     BufferTransformer::void-end()
 chart2/source/inc/WeakListenerAdapter.hxx:58
     chart::WeakListenerAdapter::void-disposing(const css::lang::EventObject &,)
-extensions/source/dbpilots/unoautopilot.hxx:99
+connectivity/source/drivers/firebird/SubComponent.hxx:72
+    connectivity::firebird::OPropertyArrayUsageHelper::void-~OPropertyArrayUsageHelper<TYPE>()
+extensions/source/dbpilots/unoautopilot.hxx:98
     dbp::OUnoAutoPilot::::cppu::IPropertyArrayHelper *-createArrayHelper()const
 extensions/source/propctrlr/commoncontrol.hxx:127
     pcr::CommonBehaviourControl::::sal_Int16-getControlType()
@@ -64,9 +66,9 @@ forms/source/xforms/namedcollection.hxx:92
     NamedCollection::sal_Bool-hasElements()
 forms/source/xforms/namedcollection.hxx:98
     NamedCollection::css::uno::Any-getByName(const class rtl::OUString &,)
-forms/source/xforms/namedcollection.hxx:108
+forms/source/xforms/namedcollection.hxx:106
     NamedCollection::css::uno::Sequence<OUString>-getElementNames()
-forms/source/xforms/namedcollection.hxx:113
+forms/source/xforms/namedcollection.hxx:111
     NamedCollection::sal_Bool-hasByName(const class rtl::OUString &,)
 include/comphelper/IdPropArrayHelper.hxx:53
     comphelper::OIdPropertyArrayUsageHelper::void-~OIdPropertyArrayUsageHelper<TYPE>()
@@ -92,10 +94,6 @@ include/comphelper/unique_disposing_ptr.hxx:168
     comphelper::unique_disposing_solar_mutex_reset_ptr::void-reset(T *,)
 include/comphelper/weakeventlistener.hxx:118
     comphelper::OWeakListenerAdapter::void-disposing(const css::lang::EventObject &,)
-include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:58
-    drawinglayer::primitive2d::BorderLine::void-~BorderLine()
-include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:66
-    drawinglayer::primitive2d::BorderLine::_Bool-operator==(const class drawinglayer::primitive2d::BorderLine &,)const
 include/sfx2/controlwrapper.hxx:257
     sfx::MetricFieldWrapper::_Bool-IsControlDontKnow()const
 include/sfx2/controlwrapper.hxx:258
@@ -130,21 +128,21 @@ include/sfx2/itemwrapper.hxx:156
     sfx::IdentItemWrapper::const ItemT &-GetItemValue(const ItemT &,)const
 include/sfx2/itemwrapper.hxx:158
     sfx::IdentItemWrapper::void-SetItemValue(ItemT &,const ItemT &,)const
-include/svl/itempool.hxx:171
-    SfxItemPool::class SvStream &-Store(class SvStream &,)const
 include/svl/svdde.hxx:307
     DdeService::void-~DdeService()
-include/svtools/svparser.hxx:91
-    SvParser::void-NextToken(T,)
-include/svtools/svparser.hxx:127
-    SvParser::void-Continue(T,)
 include/toolkit/controls/geometrycontrolmodel.hxx:192
     OGeometryControlModel::void-fillProperties(css::uno::Sequence<css::beans::Property> &,css::uno::Sequence<css::beans::Property> &,)const
-include/vbahelper/vbacollectionimpl.hxx:291
+include/tools/stream.hxx:294
+    SvStream::_Bool-ReadLine(class rtl::OString &,sal_Int32,)
+include/tools/stream.hxx:410
+    SvStream::_Bool-good()const
+include/unotools/fontcvt.hxx:55
+    StarSymbolToMSMultiFont::void-~StarSymbolToMSMultiFont()
+include/vbahelper/vbacollectionimpl.hxx:290
     ScVbaCollectionBase::::sal_Int32-getCount()
-include/vbahelper/vbacollectionimpl.hxx:296
+include/vbahelper/vbacollectionimpl.hxx:295
     ScVbaCollectionBase::css::uno::Any-Item(const css::uno::Any &,const css::uno::Any &,)
-include/vbahelper/vbacollectionimpl.hxx:325
+include/vbahelper/vbacollectionimpl.hxx:324
     ScVbaCollectionBase::sal_Bool-hasElements()
 include/vbahelper/vbahelperinterface.hxx:77
     InheritedHelperInterfaceImpl::::sal_Int32-getCreator()
@@ -166,23 +164,25 @@ include/vcl/vclptr.hxx:110
     VclPtr::void-~VclPtr<T>()
 mysqlc/source/mysqlc_subcomponent.hxx:104
     connectivity::mysqlc::OPropertyArrayUsageHelper::void-~OPropertyArrayUsageHelper<TYPE>()
-sc/inc/compressedarray.hxx:65
+oox/source/drawingml/diagram/diagramlayoutatoms.hxx:109
+    oox::drawingml::LayoutAtom::void-addChild(const oox::drawingml::LayoutAtomPtr &,)
+sc/inc/compressedarray.hxx:72
     ScCompressedArray::void-~ScCompressedArray<A, D>()
-sc/source/core/opencl/formulagroupcl.cxx:936
+sc/source/core/opencl/formulagroupcl.cxx:934
     sc::opencl::DynamicKernelSlidingArgument::_Bool-NeedParallelReduction()const
-sc/source/core/opencl/formulagroupcl.cxx:943
+sc/source/core/opencl/formulagroupcl.cxx:941
     sc::opencl::DynamicKernelSlidingArgument::void-GenSlidingWindowFunction(std::stringstream &,)
-sc/source/core/opencl/formulagroupcl.cxx:945
+sc/source/core/opencl/formulagroupcl.cxx:943
     sc::opencl::DynamicKernelSlidingArgument::std::string-GenSlidingWindowDeclRef(_Bool,)const
-sc/source/core/opencl/formulagroupcl.cxx:968
+sc/source/core/opencl/formulagroupcl.cxx:966
     sc::opencl::DynamicKernelSlidingArgument::size_t-GenReductionLoopHeader(std::stringstream &,_Bool &,)
-sc/source/core/opencl/formulagroupcl.cxx:1224
+sc/source/core/opencl/formulagroupcl.cxx:1222
     sc::opencl::ParallelReductionVectorRef::void-GenSlidingWindowFunction(std::stringstream &,)
-sc/source/core/opencl/formulagroupcl.cxx:1403
+sc/source/core/opencl/formulagroupcl.cxx:1401
     sc::opencl::ParallelReductionVectorRef::std::string-GenSlidingWindowDeclRef(_Bool,)const
-sc/source/core/opencl/formulagroupcl.cxx:1413
+sc/source/core/opencl/formulagroupcl.cxx:1411
     sc::opencl::ParallelReductionVectorRef::size_t-GenReductionLoopHeader(std::stringstream &,int,_Bool &,)
-sc/source/core/opencl/formulagroupcl.cxx:1437
+sc/source/core/opencl/formulagroupcl.cxx:1435
     sc::opencl::ParallelReductionVectorRef::size_t-Marshal(cl_kernel,int,int,cl_program,)
 sc/source/ui/inc/anyrefdg.hxx:220
     ScRefHdlrImpl::void-dispose()
@@ -274,19 +274,19 @@ slideshow/source/engine/animationfactory.cxx:442
     slideshow::internal::(anonymous namespace)::GenericAnimation::void-prefetch(const slideshow::internal::AnimatableShapeSharedPtr &,const slideshow::internal::ShapeAttributeLayerSharedPtr &,)
 slideshow/source/engine/animationfactory.cxx:446
     slideshow::internal::(anonymous namespace)::GenericAnimation::void-start(const slideshow::internal::AnimatableShapeSharedPtr &,const slideshow::internal::ShapeAttributeLayerSharedPtr &,)
+sw/inc/doc.hxx:436
+    SwDoc::void-~SwDoc()
 sw/inc/docary.hxx:116
     SwVectorModifyBase::void-~SwVectorModifyBase<Value>()
 sw/inc/flypos.hxx:37
     SwPosFlyFrame::void-~SwPosFlyFrame()
 sw/inc/ring.hxx:45
     sw::Ring::void-~Ring<value_type>()
-sw/inc/SwNumberTree.hxx:399
-    SwNumberTreeNode::void-IsSane(_Bool,std::vector<const SwNumberTreeNode *>,)const
 vcl/inc/opengl/BufferObject.hxx:31
     vcl::BufferObject::void-~BufferObject<TYPE, BUFFER_TYPE>()
-vcl/inc/salframe.hxx:178
+vcl/inc/salframe.hxx:177
     SalFrame::void-Flush(const tools::Rectangle &,)
-vcl/inc/sallayout.hxx:181
+vcl/inc/sallayout.hxx:180
     SalLayout::_Bool-GetBoundRect(class SalGraphics &,tools::Rectangle &,)const
 vcl/inc/salmenu.hxx:92
     SalMenu::tools::Rectangle-GetMenuBarButtonRectPixel(sal_uInt16,class SalFrame *,)
@@ -306,8 +306,6 @@ vcl/inc/unx/saldisp.hxx:169
     SalXLib::_Bool-Yield(_Bool,_Bool,)
 vcl/inc/unx/saldisp.hxx:170
     SalXLib::void-Wakeup()
-vcl/inc/unx/saldisp.hxx:171
-    SalXLib::void-PostUserEvent()
 vcl/inc/unx/saldisp.hxx:173
     SalXLib::void-Insert(int,void *,YieldFunc,YieldFunc,YieldFunc,)
 vcl/inc/unx/saldisp.hxx:177
@@ -316,7 +314,9 @@ vcl/inc/unx/saldisp.hxx:179
     SalXLib::void-StartTimer(sal_uLong,)
 vcl/inc/unx/saldisp.hxx:180
     SalXLib::void-StopTimer()
-vcl/inc/unx/saldisp.hxx:392
+vcl/inc/unx/saldisp.hxx:182
+    SalXLib::_Bool-CheckTimeout(_Bool,)
+vcl/inc/unx/saldisp.hxx:390
     SalX11Display::void-Yield()
 vcl/inc/unx/salinst.h:47
     X11SalInstance::class SalX11Display *-CreateDisplay()const
@@ -332,12 +332,12 @@ writerfilter/source/ooxml/OOXMLFactory.hxx:76
     writerfilter::ooxml::OOXMLFactory_ns::void-~OOXMLFactory_ns()
 writerperfect/inc/ImportFilter.hxx:178
     writerperfect::detail::ImportFilterImpl::void-doRegisterHandlers(Generator &,)
-xmloff/source/forms/elementimport.hxx:575
+xmloff/source/forms/elementimport.hxx:573
-    xmloff::OContainerImport::class SvXMLImportContext *-CreateChildContext(sal_uInt16,const class rtl::OUString &,const css::uno::Reference<css::xml::sax::XAttributeList> &,)
+    xmloff::OContainerImport::SvXMLImportContextRef-CreateChildContext(sal_uInt16,const class rtl::OUString &,const css::uno::Reference<css::xml::sax::XAttributeList> &,)
-xmloff/source/forms/elementimport.hxx:578
+xmloff/source/forms/elementimport.hxx:576
     xmloff::OContainerImport::void-EndElement()
-xmloff/source/forms/elementimport.hxx:583
+xmloff/source/forms/elementimport.hxx:581
     xmloff::OContainerImport::css::uno::Reference<css::beans::XPropertySet>-createElement()
-xmloff/source/forms/elementimport.hxx:611
+xmloff/source/forms/elementimport.hxx:609
     xmloff::OColumnImport::css::uno::Reference<css::beans::XPropertySet>-createElement()
 

include/tools/stream.hxx

@@ -292,7 +292,7 @@ public:
               @endcode
               causing endless loops ...
     */
-    virtual bool    ReadLine( OString& rStr, sal_Int32 nMaxBytesToRead = 0xFFFE );
+    bool            ReadLine( OString& rStr, sal_Int32 nMaxBytesToRead = 0xFFFE );
     bool            WriteLine( const OString& rStr );
 
     /** Read a line of bytes.
@@ -408,7 +408,7 @@ public:
         If we try to read into a variable v and the operation fails, the value
         of v should be unchanged,
     */
-    virtual bool good() const { return !(eof() || bad()); }
+    bool good() const { return !(eof() || bad()); }
 
 private:
     template<typename T>

oox/source/drawingml/diagram/diagramlayoutatoms.hxx

@@ -106,7 +106,7 @@ public:
     const OUString& getName() const
         { return msName; }
 
-    virtual void addChild( const LayoutAtomPtr & pNode )
+    void addChild( const LayoutAtomPtr & pNode )
         { mpChildNodes.push_back( pNode ); }
     virtual const std::vector<LayoutAtomPtr>& getChildren() const
         { return mpChildNodes; }

sw/inc/doc.hxx

@@ -226,7 +226,7 @@ void SetAllScriptItem( SfxItemSet& rSet, const SfxPoolItem& rItem );
 using SwRubyList = std::vector<std::unique_ptr<SwRubyListEntry>>;
 
 // Represents the model of a Writer document.
-class SW_DLLPUBLIC SwDoc
+class SW_DLLPUBLIC SwDoc final
 {
     friend class ::sw::DocumentContentOperationsManager;
 
@@ -433,7 +433,7 @@ public:
 
     // Life cycle
     SwDoc();
-    virtual ~SwDoc();
+    ~SwDoc();
 
     bool IsInDtor() const { return mbDtor; }