From c5de4d0277e18fbf79f8f80fbe49d2d25be1fb4c Mon Sep 17 00:00:00 2001 From: Xisco Fauli Date: Thu, 21 Apr 2022 13:37:29 +0200 Subject: [PATCH] tdf#148669: sc_uicalc: Add unittest Change-Id: I2991ef99f5a617e36cfbe9499ef1c4195d52fdf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133254 Tested-by: Jenkins Reviewed-by: Xisco Fauli --- sc/qa/unit/uicalc/data/tdf148669.xlsx | Bin 0 -> 11607 bytes sc/qa/unit/uicalc/uicalc.cxx | 11 +++++++++++ 2 files changed, 11 insertions(+) create mode 100644 sc/qa/unit/uicalc/data/tdf148669.xlsx diff --git a/sc/qa/unit/uicalc/data/tdf148669.xlsx b/sc/qa/unit/uicalc/data/tdf148669.xlsx new file mode 100644 index 0000000000000000000000000000000000000000..ac2634913972c4766ac2aaef72ef9c36f99be396 GIT binary patch literal 11607 zcmeHN1y>x|wr<>A0|a-s1P@Mdcelpf2^QSlHE0MHoZ#*Rg1bv_cYmGC%*&nJxxe7v zTC2;t_P46e`Sw2B z9nevS(aqY5I2RI}IvW5Edj5agfAI*ECJfkgGNT3^C*C2)mSeG8$g5!a3Y$kWDDFbw zdI-@s4;a;bIqs$p4iklC3`O^NvVE#Fz3Zxd)q_rIaZEc+*Hj9iY8kgtty~!}-A=?x z2~g^EgTYz=RIRO^=J3x!w)^G2R4tXDX||850;8+A03#@ye4`n=!#3iE>cD8y{-J3J zhp|O!RgtO|&uWxNkO7+#i^%e>W!Sj*CEfCudrjpY5m+&)SZak@9J{ zPU~T}#=OmyLgeMQl_MF_1{lucwtFP=h3gVa*)G_0cqG3o_du2_$k9FoPHlYOO<$Ax&Dx}jlybc7aa4>o;!j`Icr0C;|e0LcGMV{28I$u2-Nlm;mz z0!U-^9Dr7iOpHJF|I^g}V)gu&PcMy=k?Uec3_2En2=2e0T8cpxl5!OkZz56lelM|z zQX82^j=$7KMS!Y|=MVALr^WkWaAAoza<8A{YMs3_937K~tj@J8DEZFb8HSe9AxX@> zbgdiBW$JS3D)p_TJGDzoG;K-!ryQw)6*94jQ;|y4Z;Wbqa2N#yLD+n$zM8!<8q0<^ zpTVYtln%>+D!y=J@5O&h_nArhxQoOe!XfZ5=EPZEY=oENS`5E4Jy(sNNrHo;%KXw%$UJ ze99jb$`hUcXmL27ESYGOp+7bIHHA`P>e`W`LSjq}qPCR57-B5X-MVnB>@7=lr8x3i^Y zMcgD+u^~FWRDqPCevz7uj=9)bqyE=~P9$C?2dPeqBUJQ9Ld05ahe1}+^f-wLUo*-O zusi3DlE$}myB@2OxkPD$ImM*_!wx8p1#HZ`ILh-xXNe1^ks}KBv?XYi*KHM^2+hftUmRrPp048CF(%I!x{8@M*K%vS^x?r1sca3fK_jb%-1h67 zxLm?a;X!N0?64*irm$jf;Z*WjdOo*fbN4`e`X0MWHFtr%B88XLHtKffl5DiiA#CeW z2ezQ<(lyuU9qXr)JIs*Wpy{s&O$b@L#3YDlwlr_!ZUb)zE5_pHw9?AfO8dTosGEe- zZ=InMlL&Q?TZpZmfQJCpL6614gOb_Olw2!QZ|=>Wuw$KLx>1Ca;q~bGqOIlZvsh?$ zwk40o+wxaej~)*oa{fDeBZKGdRza*~05KR301F0U?;lqFUpf4j#RmiVW*{B-@7_vd zhb+37QAMuvlN#^1>@`<4gp+RjK6mQ#yZie|z9_^kS%gC2wU^W1AM@;dWNa}P)0`Lj)^*>>wXv%^V~j9D zX9=Hng(2AvOP8pDb@6Du+*H^NV?$nE=Ick;KC!!bWzt-2b4d4IAV%L)umm+NgN2E9 zbn)660@_q^pB?39SM@6gay>8fZW>U6)i8}tST11E*Qd=S;(`2OCX>`0W(QbNy^&)WUfV}MR%$M)sv`7>uFRkhF<1R_P zpre#Zi5=&Bfk^m+Ik0qN2v5%V19CmFN3dGZ^-`k#vTjk6G2=-7m8?r=KE!wZ5UWf<%w=p|~ZX$G0psH;?1l@+NO z#lO=^NG4CNZ%#I&Yf(V(kttDl@!)#}xcpG`Ke0q2rI0(B z5k<<;ZvhF>sNk=3Dh)b{shB5a=p_jn#IQ25uxSiAY{l4=Oc9+#kut9#*HSfX3u@i{QtaPIgK9bF$@ZA4QnuYR+NUm`coOdzPOJ5W$%V~uOZ#{j3` zx>TgjFGv=$2$m$ z<=xv9gwD7my;k`%zKn?36!M8AA4^VZc27C+ga|YsoXsr){e#rP2X6;7>jBulS%_N^ ztDGbv39bcN>>k*l*!p%8PTv*Eh(7U7vJcpO1TX!UQ?Tg@6w7eQ;%;>P4COt%SV_nZ zkP;<*Jc^p-)>vYNkRqs8)QT%9aw<2vs)RxUcNC9alFXkOWU=rNu6vAMQ=_AMo83}8 zZsUAm!X8tl6xo8-5VpyFW^Itx_f#KqJlpNC7$=7H*YqgRgZQM~ce($l*;Y4R2xi9a zm-w-6mU}L;c{oTEu&u&J~B93k2%D zP|dt;mUE3nrw!y$spVpoP>V(pF1W7TtHo(UCnt7U(o6B@4WUh;qp_ApjFP2*>ut7d zwROe0$O_YlIC$ zhB|@70rO|W%hu&xpDd^NJdMc=K<~lq9a6N_J7mVFaG=N~!t&~6Yq;?ytAkI+TguN& zU6)3lXBP@ZwSX_i{*2fjg;qgoR^O4@Ajrd zCJ~Kw^_Rf$jGp5W;S(m1uVPvJ0$11hXhK>KwP}%-KoxQa9C=yU9Ff{WgyZB_5e}T^ zt(&bK4rSxvJ}*j~Z^Bh_is;4l`0~b4ebj($XuDxdjZ{DJ<$+`=UH^#6WrjW&Fs|5g zn#Lg+mJWD*nqXaFYHRQ3hD{xcwvvB~C$c1|!?~5A{4O&JS!VSW_!iM-_yo-i)DCl8 zQ=7zoB&>#M@;mG!PaQitZ`y?XKdeJ9YDXUu-g=`=%T?Vwrlb*?W0)DQJ<}?CCp5d3?5$CD&ZJ z#YU2FGz8VtB;@J^**q2j!~AJMp^>V=0&IlzChb)U{bB+c!-hR2KNahI^eCdHFmS0o zBTV{I*^P}d+bBQSnGWm2XxY8&xm$GPgsf>pX=7Ru0#w|s8;y3PaI)mb9ZkOD<+90r z?;T}Vjbv!*xd~hYX%l<}XIuq6WFbsl(*WJMRP`|@^)dOqg`z?58Yb-3ct*ceh zmaSmHdBGqPf`n}&tiqbq=7`VmBdKEV;@OH)!Q>5@*odQ@l;#@k-7TEWi(5qV8OS1> zsw0`lnf-9q=y`^d?lpQFQ-dd2u0ob9k?)$)XS=83o|TuS9BBFK>P&PnQK9d{{T=p(S$xwguwu7vUDx#o&1Raz#<>!r$hgDhU2;>5vpQde ze*QWpM@NJ!H<#9tv(LzzQVem`BDcgrG&Sf5ZT{W#V-M}#q*MHEFwZ7Z$(itE6>Wjd zqb!5NXG_KgWb`R_$>z05uW*PCW`+-6S!FbuWxK+vs}&Y%*yv#qSUZbx@|}LB z;_uJ=s_861zb~12b2qryJY@po>dX7i&WE#5aYtUrHkpk2ZXCZq;kADFV!TEq>`F5i z6~nVPjTOw2o+O@m&R_!@Y`(rfX%=_BGYz=D{i$IfFK5EDo*}Tz%Y3@MX zGOc5zcS{vx1iU9LWJt*KQ#SJZ9PqUcU$kH?D1hF18lPYiC3!x5!GFwtB&IXc-=gs{ zZUtOhG}S%-V+`y!W(yt$%JNzX0{}>WEWeIU?p8p@AFkn7Z7th%F--6B$!C3yJ+jl6 z2e9f;=wIlpClX()+*?F|akLV9i07z0dwh#vV(VfMHe{u%!MEaFx&5ADJF;kn!f!nx z;vO2tI#L~LvA9!=4m5ZZUA-m#_&9LfP^_3soDL(AB}(RulekxS8qJR=RU?&aTS6@a zFJQbSu0vAOI#t7}Eov^mytz;9uZQg(3k{1LUZDCpoH`}BUOvt20~kERKEMl)`;LPc>)gSd@N|B;K;Ou8BL^SM==0R|mw(bz*JIiPmGdB&H|_`S$9Y zz*Yf{_a$55q6A{WPJF`?eletAXA3ciZzp6vA1$m$ir1-%FtH$i;3i}|Lrj!Rv1Mgf zlnJ3IIy`htdd|GP;efUGnsZZs%4>#%%V1Hq=0!XwXTpT6gqVqC(})q9!kQosH5H9u z(t%C-pbHwNj@^| z>3i*hv|y&hQxHkExBev_?=2xBp!b>e(UW`*nVW?=+wd2qkb3%1Iky5E+2ZE#?1k#R zAr0&JIVacK`-n6&ACQ9})zkom?H207LBjU0qwB^z^BXUL*KRlq@#Xz= zI*Dmz<6JUKHQdBuOnZfK(egg^dveO}9m_SnLfm1+Z8oaYbY7xUV+z+dO)=IdRn7hy z?-r#&U)XKyjGlQ#^soz2ImCXHIQHC@WL z;WI;I59Z;)mYgo_Vr~vX$}#YcuVw9)qbE39mN!00WRUn+8*9ACN$%L>ZZih&mZ4bn9jIZXM@bis@h;~F*IHT=MH1Dc z-CtdXvAyZ`U`j;TPi4}n8nb)YJAq3g&Y_IOrU#^%k&~$BhI5ZoD2{QnQgrY2W1^Ol zDdm!34WA=fQ60g|UhC*kRp*6YIuM*RbLcTR?tD`VCpg_H0XB{fcXt!9hGAOaOT)1& zF+)K*cO|%`+eE$QwHaG?_Hj)9kf%`iZilOrTB3DL`)ND(@QwbKA@3q%f>rz-%^l)U zas@_&t6q9}1+ThKS!389pfN@%P@3AOIR?FSX5h#^ek8Y(O6##3k1ITxWOpp!!v5lh zF*I2NFSZt^*6&txlNuha0n4}aHf!A|bJb{4fYfu@XyuIo(F6HG^!03T!{eCSd%gU5 zm`sT=h_7MzJ_4}n3LiEm3P=s0XPDm;_v-_yBZI*Dm7pPTUvMA_WG8@)a^;0x*FfM> zf1wnFm?WQVOOohkkzwG9S1a8rxd&q3$pmV9hWAf%xEGMY%-7YkxWZ@?b3>(3$P=U;D%EvS(cL#)VT;9*OtLMLYv zj{86)qj4LH<^KR_J}4OzfxEf=R!P;{xQCcuQ1c8XCh6h9Ooxl#;=s?m)^o5lV?Ef2 zQIAulF5CqwaTS8JnsumrsO}2uAp_1^a+|84a50diG{Enkjv8Xf9)qePFe@|hp$E9_&Bx1-lrm7H;cC>u<$6|hX$;k{_rsfgIhw~F+5Z!;WT(0@8BP-l;- z?_q6)AxkzK<6K9M?Er7k37hI2>%C1dbTX@=5AyBkbi|o3LaN8u5qp+c316SNE zlyka%X^pT4x)Zxz9mbHNLW`Nk=6*cyx10%iPPu>P#{#7Tj`A@m9g+|ts8BEcb9^#F zmTf3|=q@e%heVo#k97i`9_>q?U`M-LG9fkIpBWbNifT=Eo(j4`u6d7~Pru~_&*BY1 zy@Mib2r6tybg}EOoUKRwXpPY9aRRZ1!8woKxMr;5BtvaXi@F zd|JMCQu^@J*NnIJl1Yr%*5UnbyunHmT=ScpPjp)G&tl&qmA_}_${j(2&(phpJJ@%P z%DMKG;&|u6Z|7mN;_$B3DCOGA<81W?xogRN0|C=%n7LSuMgMGsA#8#=w3<>?CSbN2 zm7J4T39c+OKuj;5<%#H@at14i&&md%)RrG8wT1tO(_-vk;A(DT>d53`Z6)%@ISV7` zJVJTEW`P;C1!spJ^=k(XT~b0190MGz;^s888NvnbD5*6|4yPYy(w3)JaNGg8sDkqQ zq&dRvmKQwxmP0!(x=vgxwX!!=@s%uCT9+;E zoF*U2u+MF*z2HC*!XZj(D|yDOfp(`;umM%cPi%rNo%olTz`&-eM$sr@1@ zZa6Ksv4a;8=WZ1Nn)s84voG>g!BH3L6ki5Gwm zE$#U(UDx3?c9vH*$7>eLc6|2L0Bw&7p2-q{;-tgr`u;tnu<-D7pl55dh25(LG`!ee zIIb%(1B$r)OLJ?rXxQ&WO$W@tDZVrNPj#cmL z-g$KT8ZQ2Y(Smq^tc!7Vf6_gNU^{enIFODoUMVkLMfJd zN18Ga9|Cv>o`WZmGraLp$9v0iOyeDV{aFq0$o0q>!bX?r>G6zGS(jK?CKVQ~GGYBj z!mI?xNSL&o4EMkxYKQq;QIk10}-r)}}@`1>32?e&?z-K-ID;j5}?_wS8p0lkV z!|z8Dv1*KrtX}91&jDFY2YND=z7DizR=crQi!v>nVtjuY`;NFM9LBtb5Irg@)|{!e zt2IQJ+>;>lx<;m!F3BF9G#<;(-<_1}iLsE661Wpxcmwj5|2>;E#mU2W0%D{Nh@E7A zF!M(`{?DZAANl!Tsn?&``O>%!NeC8D#oX^0^}9_~5i#lTm12Ny?HhrwBS%3tlq8{3 ztu0EB&Qd*6wyC!R97J98YD5O;9$$OjvStGzzz2FpCiGW<_im0Txyn+RnWQ6Z-kMbV@JlxIl$F1xjYXl5#1 zxr?|d-t{=Vd*-rg zukDxLL>kL=75E#H9-f9I^u}p`a#-hV(}TL_NSVfa`O{}p6AFsMQMr#GW&QU7!?AA> z1%)1fMbMAxj{&oDFb8#)I4A*~oPKKbZ`Ul0hUPYg`q_xgRm{~(V0de#BkkS&?E}o= z3jt(-zOlX^NWl9|A>+OZjK_8a2zkWRvI%h!r@?gx!Pk30=c$A0<^S*=Utq@h-9Qo2 z0%+n;|9B50TWf1jlZ)fe9Av3thh#U%jvzb<_qU|0I>nB=oMscdon$As04H`|&yoWv zwHm{okDL~;y2D|FQ@%EnAInfGS&7Yrg2h;!6ns@J!d#X4RJM|QcDY5;km#3tReR(Y ztVrm)`LVH?TG|fTle_~mOLDGvc3U#myu(~GkdXJ79V|17U|m-sI@{6$EO&oWCGB(K z#Pm=qiR*VJa@mcA969xtnXw})(~Z+^ia@s8jb)h0rYMY;r_#LZOopaN(C{+aEV1x1 zMo15XOiik={+YC7B|=1o_%S20&aPnyuQsOU)*z&SS@b=}0>tbEi#BXD-w~pnX&R;{ z_Xx3lx*zmkJc%dAo-}4jr{&MYuh~2D+j=`lqKT;rWPP)8DW=`gL2TUcX^taE9fiW2 zo?!+*UpB!ALFwqboea0}pTL+kGi}<4$ogE20o2w_#R&_X%&!S~{4zQT!F4%*^36US zbrle|a3D)R^)MnZT&{{RV*dE)nk#n?;h$#7(K@fg2sBG}pjko#)x3;tjpQ9{?Hrkm zY#o3kRB$}GrG6&wlx)sP{n!dywX7Q$rk;&$q! zm^|T5Ng!<>{EtUlV$GYT2AfYwV>UgvlaG1G2^rmw7X8OHNYF9e-Z%)1`T-4-vWEux z`Glfgi!jIGfTP!dM+WUa=}H4d5TLe;W3r{8=PSu`$Y?RxImE3i{1JH!+pqzkGBKYKa42sJ|&CtwYBrwRGW(00vPh)uU+RtMc3%%z0HoCpEo8lsgIo!*WHxftu^CK?~G4Ki$AhGLPe$Plla{~ z8h#p-%U&-KGoOCikAGpNft}s|hzVlkpIb)UknGPItoVcQCZ97rY|bEy5N|iQNCCDw zzUjDnz02l{+@x~TxR5w-I+yeM#y72XjkBd*(?UWx!XzK#wT)4&=ylYw*3I2LoETZj zF(fyP-V0fQ^#s1*l|RSC7vBW1)xoNVql|Q6F{X zh2*iHEz-r>!OdxJHuddbko(-FLNtvwi1rEYZvm+H#Z zL;@zP35NDos<&F1bX+!5op>l}R;6?sXbBI5pLm#c%p5n+EvCjxp`=)VJ8wAajAC2x z0+0()%Opl14NGNTvwI!l=jZDgzU#t!FE4?O*wsp4*;mUmHKE(y(^|oXE8tccUGKCB zMpV)uaRGDcB)!On*bFg}yMaGKaDJ)wJ>J`GrRgL{ZkSaU->>}OD%e6H9g?E2Wypm? z-jzV>EOS7`x)XkoY4}+5di-0L>-0pmgm>IIS(J&Sw~zKC++W5N44eV*pZYrgnxems z|IpV2nsI(>#Q9zL@0}07L;-+A(1-r# zK8W9Oey@=KLaGI=KL4p+{yWO=1lX` zA^a)&pTeTwfqwT}e*w{w{5}-_=*9jH_`6^C3s8&nC*W^h9n){uKfS!)L4SABet~ZM z0s1$W?RV+FI}g8P0f10)0N~$TiQmQlZsGq`oDAf+{=fL2_Fi5J3Pj`|Idvp}B}f;h IX?|S&AGEX;vj6}9 literal 0 HcmV?d00001 diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx index 9b3fb5c8a73f..2d3f48a8387b 100644 --- a/sc/qa/unit/uicalc/uicalc.cxx +++ b/sc/qa/unit/uicalc/uicalc.cxx @@ -2261,6 +2261,17 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf118207) pMod->SetInputOptions(aInputOption); } +CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf148669) +{ + // Without the fix in place, this test would have failed with an assert + ScModelObj* pModelObj = createDoc("tdf148669.xlsx"); + + ScDocument* pDoc = pModelObj->GetDocument(); + CPPUNIT_ASSERT(pDoc); + + CPPUNIT_ASSERT_MESSAGE("There should be a note", pDoc->HasNote(ScAddress(701, 0, 0))); +} + CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf124778) { mxComponent = loadFromDesktop("private:factory/scalc");